[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194065#comment-16194065
]
Hudson commented on HADOOP-14521:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13039 (See
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193956#comment-16193956
]
Andrew Wang commented on HADOOP-14521:
--
+1 based on the diff, thanks Xiao and Rushabh!
> KMS
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192965#comment-16192965
]
Rushabh S Shah commented on HADOOP-14521:
-
thanks [~xiaochen] for the latest patch.
+1
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186697#comment-16186697
]
Xiao Chen commented on HADOOP-14521:
Thanks for the ping Arun.
I'm hoping to get this in soon. Does
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179539#comment-16179539
]
Xiao Chen commented on HADOOP-14521:
Hi [~shahrs87],
I understand this was missed in my initial
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175841#comment-16175841
]
Hadoop QA commented on HADOOP-14521:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169559#comment-16169559
]
Xiao Chen commented on HADOOP-14521:
Sorry for my delayed response here, was on leave last week.
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164778#comment-16164778
]
Rushabh S Shah commented on HADOOP-14521:
-
bq. I'll take the simple route to revert this
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164088#comment-16164088
]
Hudson commented on HADOOP-14521:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12858 (See
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164065#comment-16164065
]
Xiao Chen commented on HADOOP-14521:
Reverted from trunk, branch-2 and branch-2.8.
> KMS client
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164064#comment-16164064
]
Xiao Chen commented on HADOOP-14521:
Thanks Andrew for reverting.
I'll take the simple route to
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161948#comment-16161948
]
Andrew Wang commented on HADOOP-14521:
--
I reverted this from branch-3.0 as well, leaving it in
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159248#comment-16159248
]
Xiao Chen commented on HADOOP-14521:
Thanks a lot [~djp] for the quick actions!
> KMS client needs
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159210#comment-16159210
]
Junping Du commented on HADOOP-14521:
-
I have revert the patch from branch-2.8.2. Mark fix version
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159084#comment-16159084
]
Junping Du commented on HADOOP-14521:
-
Thanks [~xiaochen] for notification here. I prefer to revert
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159027#comment-16159027
]
Xiao Chen commented on HADOOP-14521:
Thanks for the prompt response [~shahrs87].
bq. The previous
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158976#comment-16158976
]
Rushabh S Shah commented on HADOOP-14521:
-
bq. As a result, this fix made HADOOP-14841 and
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158148#comment-16158148
]
Xiao Chen commented on HADOOP-14521:
Unfortunately, this turns out still brought some incompatible
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088600#comment-16088600
]
Rushabh S Shah commented on HADOOP-14521:
-
Thanks [~xiaochen] for the reviews and commits.
>
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088477#comment-16088477
]
Hudson commented on HADOOP-14521:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12013 (See
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087931#comment-16087931
]
Rushabh S Shah commented on HADOOP-14521:
-
[~xiaochen]: Pre-commit ran on branch-2.8 patch also.
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087905#comment-16087905
]
Hadoop QA commented on HADOOP-14521:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087449#comment-16087449
]
Hadoop QA commented on HADOOP-14521:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084177#comment-16084177
]
Rushabh S Shah commented on HADOOP-14521:
-
bq.+1 on patch 10. Will commit on Friday if no
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083482#comment-16083482
]
Xiao Chen commented on HADOOP-14521:
Thanks for the patch [~shahrs87], +1 on patch 10. Will commit
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082717#comment-16082717
]
Xiao Chen commented on HADOOP-14521:
Sure, will take a look today.
> KMS client needs retry logic
>
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16082253#comment-16082253
]
Rushabh S Shah commented on HADOOP-14521:
-
{noformat}
Running
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16081327#comment-16081327
]
Hadoop QA commented on HADOOP-14521:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080574#comment-16080574
]
Rushabh S Shah commented on HADOOP-14521:
-
bq. I tried to ran TestAclsEndToEnd before and after
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16055963#comment-16055963
]
Xiao Chen commented on HADOOP-14521:
bq. pre-commit
I tried to ran {{TestAclsEndToEnd}} before and
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16055823#comment-16055823
]
Rushabh S Shah commented on HADOOP-14521:
-
bq. In general it'd be nice to confirm the failed
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16055821#comment-16055821
]
Rushabh S Shah commented on HADOOP-14521:
-
bq. TestAclsEndToEnd failure seems to be caused by
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16055215#comment-16055215
]
Xiao Chen commented on HADOOP-14521:
Thanks for the review Daryn.
[~shahrs87],
In general it'd be
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16055027#comment-16055027
]
Rushabh S Shah commented on HADOOP-14521:
-
[~xiaochen]: Thanks [~daryn] and Xiao for reviewing
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16054520#comment-16054520
]
Daryn Sharp commented on HADOOP-14521:
--
+1 Assuming test failures are unrelated.
> KMS client
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16052694#comment-16052694
]
Hadoop QA commented on HADOOP-14521:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051637#comment-16051637
]
Hadoop QA commented on HADOOP-14521:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051137#comment-16051137
]
Rushabh S Shah commented on HADOOP-14521:
-
bq. Will fix that.
By doing that, it will violate 80
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051066#comment-16051066
]
Xiao Chen commented on HADOOP-14521:
I know this probably isn't anyone's favorite part (at least not
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050844#comment-16050844
]
Rushabh S Shah commented on HADOOP-14521:
-
bq. The checkstyle looks relevant though...
Following
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050834#comment-16050834
]
Xiao Chen commented on HADOOP-14521:
Thanks for patiently revving [~shahrs87].
I already gave a +1
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050827#comment-16050827
]
Rushabh S Shah commented on HADOOP-14521:
-
Test failures are not relevant.
{noformat}
Running
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049812#comment-16049812
]
Hadoop QA commented on HADOOP-14521:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048629#comment-16048629
]
Xiao Chen commented on HADOOP-14521:
I feel printing the information in the log message will at
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048566#comment-16048566
]
Rushabh S Shah commented on HADOOP-14521:
-
bq. We can either update the message, or update the
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047443#comment-16047443
]
Hadoop QA commented on HADOOP-14521:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047382#comment-16047382
]
Xiao Chen commented on HADOOP-14521:
Thanks for sticking with this Rushabh.
bq. From this comment,
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047207#comment-16047207
]
Xiao Chen commented on HADOOP-14521:
Thanks for revving Rushabh. Looks pretty close to me.
Thanks
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047200#comment-16047200
]
Daryn Sharp commented on HADOOP-14521:
--
I'd revert the change that breaks instead of returning.
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046980#comment-16046980
]
Hadoop QA commented on HADOOP-14521:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046793#comment-16046793
]
Rushabh S Shah commented on HADOOP-14521:
-
bq. Should this JIRA be moved to project "Hadoop
51 matches
Mail list logo
