[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963229#comment-16963229
]
Steve Loughran commented on HADOOP-15356:
-
it's a bit noisy; seeing "No valid ADL SDK timeout
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676736#comment-16676736
]
Sunil Govindan commented on HADOOP-15356:
-
Updated Fixed version to 3.3.0 and 3.2.0
> Make
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469554#comment-16469554
]
Hudson commented on HADOOP-15356:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14152 (See
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469413#comment-16469413
]
Aaron Fabbri commented on HADOOP-15356:
---
Thanks for adding the extra validation of the timeout
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469354#comment-16469354
]
genericqa commented on HADOOP-15356:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468997#comment-16468997
]
Sean Mackrory commented on HADOOP-15356:
{quote}what if someone sets adl.http.timeout to 0?
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468245#comment-16468245
]
Aaron Fabbri commented on HADOOP-15356:
---
Patch looks good to me, +1.
One question, what if
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463165#comment-16463165
]
genericqa commented on HADOOP-15356:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462994#comment-16462994
]
Sean Mackrory commented on HADOOP-15356:
Addressing the findbugs and checkstyle complaints. The
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462831#comment-16462831
]
Sean Mackrory commented on HADOOP-15356:
Remaining feedback is actually active. Addressing...
>
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462823#comment-16462823
]
genericqa commented on HADOOP-15356:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462564#comment-16462564
]
Sean Mackrory commented on HADOOP-15356:
The patch I just posted is the same one - I'm just
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462400#comment-16462400
]
Sean Mackrory commented on HADOOP-15356:
Right. Don't know about Atul, but I tested this on East
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462156#comment-16462156
]
Steve Loughran commented on HADOOP-15356:
-
as usual for a cloud store, will need that
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461857#comment-16461857
]
Sean Mackrory commented on HADOOP-15356:
Oh I still haven't committed the SDK upgrade - Yetus
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461839#comment-16461839
]
genericqa commented on HADOOP-15356:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461728#comment-16461728
]
Sean Mackrory commented on HADOOP-15356:
Good one - attached an addition to core-default.xml and
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461714#comment-16461714
]
Aaron Fabbri commented on HADOOP-15356:
---
Thanks for the contributions guys. For the v2 patch,
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459906#comment-16459906
]
Sean Mackrory commented on HADOOP-15356:
Patch .002. works without modification on the new SDK,
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458732#comment-16458732
]
Steve Loughran commented on HADOOP-15356:
-
oh, see you did the one I was thinking of,
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458683#comment-16458683
]
Sean Mackrory commented on HADOOP-15356:
{quote}I think there are some existing update ADL
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457611#comment-16457611
]
Steve Loughran commented on HADOOP-15356:
-
I think there are some existing update ADL JIRAs.Why
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457255#comment-16457255
]
genericqa commented on HADOOP-15356:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457204#comment-16457204
]
Sean Mackrory commented on HADOOP-15356:
Took a stab at the tests as suggested, without the SDK
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422201#comment-16422201
]
Steve Loughran commented on HADOOP-15356:
-
# JAR updates should be isolated & linked off
[
https://issues.apache.org/jira/browse/HADOOP-15356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421164#comment-16421164
]
genericqa commented on HADOOP-15356:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
26 matches
Mail list logo