[jira] Commented: (HADOOP-6298) BytesWritable#getBytes is a bad name that leads to programming mistakes

2010-12-20 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973380#action_12973380 ] Hudson commented on HADOOP-6298: Integrated in Hadoop-Common-22-branch #8 (See [https://h

[jira] Commented: (HADOOP-6298) BytesWritable#getBytes is a bad name that leads to programming mistakes

2010-12-17 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972447#action_12972447 ] Hudson commented on HADOOP-6298: Integrated in Hadoop-Common-trunk #548 (See [https://hud

[jira] Commented: (HADOOP-6298) BytesWritable#getBytes is a bad name that leads to programming mistakes

2010-12-16 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972166#action_12972166 ] Hudson commented on HADOOP-6298: Integrated in Hadoop-Common-trunk-Commit #458 (See [http

[jira] Commented: (HADOOP-6298) BytesWritable#getBytes is a bad name that leads to programming mistakes

2010-12-16 Thread Tom White (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972097#action_12972097 ] Tom White commented on HADOOP-6298: --- +1 This looks good to me. Minor nit/improvement: t

[jira] Commented: (HADOOP-6298) BytesWritable#getBytes is a bad name that leads to programming mistakes

2010-12-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971395#action_12971395 ] Hadoop QA commented on HADOOP-6298: --- +1 overall. Here are the results of testing the la

[jira] Commented: (HADOOP-6298) BytesWritable#getBytes is a bad name that leads to programming mistakes

2010-12-14 Thread David Rosenstrauch (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971281#action_12971281 ] David Rosenstrauch commented on HADOOP-6298: Or maybe copyBytes()? > BytesWri

[jira] Commented: (HADOOP-6298) BytesWritable#getBytes is a bad name that leads to programming mistakes

2010-12-13 Thread Konstantin Boudnik (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971174#action_12971174 ] Konstantin Boudnik commented on HADOOP-6298: I think Tom's idea makes sense if

[jira] Commented: (HADOOP-6298) BytesWritable#getBytes is a bad name that leads to programming mistakes

2010-12-13 Thread Tom White (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971040#action_12971040 ] Tom White commented on HADOOP-6298: --- How about adding {{getBytesNonPadded()}} which crea

[jira] Commented: (HADOOP-6298) BytesWritable#getBytes is a bad name that leads to programming mistakes

2010-12-13 Thread David Rosenstrauch (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971034#action_12971034 ] David Rosenstrauch commented on HADOOP-6298: Yeesh. I just got bit on this sa

[jira] Commented: (HADOOP-6298) BytesWritable#getBytes is a bad name that leads to programming mistakes

2010-08-24 Thread David Rosenstrauch (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902051#action_12902051 ] David Rosenstrauch commented on HADOOP-6298: We just got hit with this problem

[jira] Commented: (HADOOP-6298) BytesWritable#getBytes is a bad name that leads to programming mistakes

2009-12-02 Thread Owen O'Malley (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784894#action_12784894 ] Owen O'Malley commented on HADOOP-6298: --- This *would be* an API change. Renaming met

[jira] Commented: (HADOOP-6298) BytesWritable#getBytes is a bad name that leads to programming mistakes

2009-10-08 Thread Nathan Marz (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763841#action_12763841 ] Nathan Marz commented on HADOOP-6298: - Yes - I'm proposing solely a rename, not an API

[jira] Commented: (HADOOP-6298) BytesWritable#getBytes is a bad name that leads to programming mistakes

2009-10-08 Thread Owen O'Malley (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763598#action_12763598 ] Owen O'Malley commented on HADOOP-6298: --- I think this is a very bad idea. It introdu

[jira] Commented: (HADOOP-6298) BytesWritable#getBytes is a bad name that leads to programming mistakes

2009-10-08 Thread Chris Douglas (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763568#action_12763568 ] Chris Douglas commented on HADOOP-6298: --- bq. I don't think this proposal is about ch

[jira] Commented: (HADOOP-6298) BytesWritable#getBytes is a bad name that leads to programming mistakes

2009-10-08 Thread Tom White (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763520#action_12763520 ] Tom White commented on HADOOP-6298: --- I don't think this proposal is about changing the A

[jira] Commented: (HADOOP-6298) BytesWritable#getBytes is a bad name that leads to programming mistakes

2009-10-07 Thread Chris Douglas (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763295#action_12763295 ] Chris Douglas commented on HADOOP-6298: --- bq. I propose "getPaddedBytes()" or "getPad