[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-12 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789713#action_12789713 ] Hudson commented on HADOOP-6323: Integrated in Hadoop-Common-trunk #185 (See [http://huds

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-11 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789646#action_12789646 ] Hudson commented on HADOOP-6323: Integrated in Hadoop-Common-trunk-Commit #106 (See [http

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789565#action_12789565 ] Hadoop QA commented on HADOOP-6323: --- +1 overall. Here are the results of testing the la

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-10 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789033#action_12789033 ] Doug Cutting commented on HADOOP-6323: -- +1 This looks good to me. I'll commit it tom

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789017#action_12789017 ] Hadoop QA commented on HADOOP-6323: --- +1 overall. Here are the results of testing the la

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788914#action_12788914 ] Hadoop QA commented on HADOOP-6323: --- +1 overall. Here are the results of testing the la

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-10 Thread Aaron Kimball (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788847#action_12788847 ] Aaron Kimball commented on HADOOP-6323: --- With Writable serialization, yes, you've al

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-10 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788813#action_12788813 ] Doug Cutting commented on HADOOP-6323: -- > AvroSpecificSerialization calls t.getSchema

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-09 Thread Tom White (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788503#action_12788503 ] Tom White commented on HADOOP-6323: --- Could we do it using reflection in the serializer's

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-09 Thread Aaron Kimball (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788425#action_12788425 ] Aaron Kimball commented on HADOOP-6323: --- Tom - is that a mandate we are comfortable

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-09 Thread Tom White (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788408#action_12788408 ] Tom White commented on HADOOP-6323: --- bq. The class name should be in the metadata. Yes.

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-09 Thread Aaron Kimball (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788394#action_12788394 ] Aaron Kimball commented on HADOOP-6323: --- ... but AvroSpecificSerialization calls t.g

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788393#action_12788393 ] Hadoop QA commented on HADOOP-6323: --- +1 overall. Here are the results of testing the la

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-09 Thread Aaron Kimball (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788390#action_12788390 ] Aaron Kimball commented on HADOOP-6323: --- The metadata field is required in all Seria

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-09 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788388#action_12788388 ] Doug Cutting commented on HADOOP-6323: -- > AvroSerialization.getSchema() method takes

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788383#action_12788383 ] Hadoop QA commented on HADOOP-6323: --- +1 overall. Here are the results of testing the la

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-09 Thread Aaron Kimball (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788382#action_12788382 ] Aaron Kimball commented on HADOOP-6323: --- @Tom this isn't a new check -- MapOutputBuf

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-09 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788379#action_12788379 ] Doug Cutting commented on HADOOP-6323: -- - WritableSerialization should just throw an

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-09 Thread Tom White (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788376#action_12788376 ] Tom White commented on HADOOP-6323: --- bq. WritableSerialization now checks that the seria

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787809#action_12787809 ] Hadoop QA commented on HADOOP-6323: --- +1 overall. Here are the results of testing the la

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-08 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787807#action_12787807 ] Doug Cutting commented on HADOOP-6323: -- +1 This looks good to me. I'll commit tomorr

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1278#action_1278 ] Hadoop QA commented on HADOOP-6323: --- +1 overall. Here are the results of testing the la

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-08 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787611#action_12787611 ] Doug Cutting commented on HADOOP-6323: -- I'd prefer we throw an exception rather than

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787327#action_12787327 ] Hadoop QA commented on HADOOP-6323: --- +1 overall. Here are the results of testing the la

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787313#action_12787313 ] Hadoop QA commented on HADOOP-6323: --- -1 overall. Here are the results of testing the la

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-07 Thread Aaron Kimball (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787301#action_12787301 ] Aaron Kimball commented on HADOOP-6323: --- also, you'll need to run: {code} svn add s

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-07 Thread Tom White (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787285#action_12787285 ] Tom White commented on HADOOP-6323: --- The reason for this was as a test that older Serial

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-07 Thread Aaron Kimball (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787280#action_12787280 ] Aaron Kimball commented on HADOOP-6323: --- I just realized that {{JavaSerialization}}

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-07 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787205#action_12787205 ] Doug Cutting commented on HADOOP-6323: -- > What needs to be done to implement this API

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-07 Thread Aaron Kimball (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787197#action_12787197 ] Aaron Kimball commented on HADOOP-6323: --- Looking at this issue, it seems that the AP

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-12-07 Thread Jacob Rideout (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786973#action_12786973 ] Jacob Rideout commented on HADOOP-6323: --- What needs to be done to implement this API

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-10-22 Thread Hong Tang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768860#action_12768860 ] Hong Tang commented on HADOOP-6323: --- Makes sense. On a side note, I wonder if we could

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-10-22 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768812#action_12768812 ] Doug Cutting commented on HADOOP-6323: -- > what key should be used in the metadata to

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-10-21 Thread Hong Tang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768531#action_12768531 ] Hong Tang commented on HADOOP-6323: --- I see. One concern I have with this solution is tha

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-10-21 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768367#action_12768367 ] Doug Cutting commented on HADOOP-6323: -- > What is the intended use of the metadata pa

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-10-21 Thread Hong Tang (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768341#action_12768341 ] Hong Tang commented on HADOOP-6323: --- What is the intended use of the metadata parameter?

[jira] Commented: (HADOOP-6323) Serialization should provide comparators

2009-10-20 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-6323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767880#action_12767880 ] Doug Cutting commented on HADOOP-6323: -- We should add a method to SerializationBase l