[jira] Commented: (JELLY-236) Whitespace normalization in Jelly is wrong

2006-08-08 Thread Kohsuke Kawaguchi (JIRA)
[ http://issues.apache.org/jira/browse/JELLY-236?page=comments#action_12426637 ] Kohsuke Kawaguchi commented on JELLY-236: - The change I made was to change the way the trimming happens. Specifically, I changed TagUtils.trimScript

[jira] Created: (JEXL-18) Whitespace normalization in Jelly is wrong

2006-08-07 Thread Kohsuke Kawaguchi (JIRA)
Whitespace normalization in Jelly is wrong -- Key: JEXL-18 URL: http://issues.apache.org/jira/browse/JEXL-18 Project: Commons JEXL Issue Type: Bug Reporter: Kohsuke Kawaguchi In XML

[jira] Commented: (JEXL-18) Whitespace normalization in Jelly is wrong

2006-08-07 Thread Kohsuke Kawaguchi (JIRA)
[ http://issues.apache.org/jira/browse/JEXL-18?page=comments#action_12426389 ] Kohsuke Kawaguchi commented on JEXL-18: --- D'oh! This is supposed to be filed against Jelly, not Jexl. But I don't seem to be able to reassign it, or even just

[jira] Commented: (JEXL-17) ExpressionFactory.createNewExpression should throw an Exception in case of a parsing error, not Error

2006-08-06 Thread Kohsuke Kawaguchi (JIRA)
[ http://issues.apache.org/jira/browse/JEXL-17?page=comments#action_12426031 ] Kohsuke Kawaguchi commented on JEXL-17: --- For example, a?b:c should do, since the lexer wouldn't understand '?'. I overlooked that existing exception, and I

[jira] Created: (JELLY-234) Nested DynamicTag and invokeBody/ doesn't work correctly

2006-08-06 Thread Kohsuke Kawaguchi (JIRA)
Components: core / taglib.core Affects Versions: 1.0 Reporter: Kohsuke Kawaguchi Consider a doubly nested invokeBody/ invocations like the following sequence, where tag A and B are DynamicTag: A X/ /A where A is defined as ... B Y define:invokeBody/ /Y /B where B is defined

[jira] Commented: (JELLY-234) Nested DynamicTag and invokeBody/ doesn't work correctly

2006-08-06 Thread Kohsuke Kawaguchi (JIRA)
[ http://issues.apache.org/jira/browse/JELLY-234?page=comments#action_12426066 ] Kohsuke Kawaguchi commented on JELLY-234: - Sorry, cut and paste error. The bug report text is meant to be as follows: Consider a doubly nested invokeBody

[jira] Updated: (JELLY-234) Nested DynamicTag and invokeBody/ doesn't work correctly

2006-08-06 Thread Kohsuke Kawaguchi (JIRA)
[ http://issues.apache.org/jira/browse/JELLY-234?page=all ] Kohsuke Kawaguchi updated JELLY-234: Attachment: JELLY-234.patch And a patch to fix this. Nested DynamicTag and invokeBody/ doesn't work correctly

[jira] Created: (JELLY-235) nested exceptions are displayed incorrectly with JellyException

2006-08-06 Thread Kohsuke Kawaguchi (JIRA)
: Improvement Components: core / taglib.core Affects Versions: 1.0 Reporter: Kohsuke Kawaguchi Attachments: JELLY.diff JellyException has some built-in support for nested exceptions. In particular, when it displays a stack trace, it tries to also displays the nested

[jira] Created: (JEXL-17) ExpressionFactory.createNewExpression should throw an Exception in case of a parsing error, not Error

2006-08-05 Thread Kohsuke Kawaguchi (JIRA)
/JEXL-17 Project: Commons JEXL Issue Type: Improvement Affects Versions: Nightly Builds Reporter: Kohsuke Kawaguchi Attachments: JEXL-17.diff When ExpressionFactory.createNewExpression(...) takes an syntactically incorrect expression, JEXL throws

[jira] Updated: (JEXL-17) ExpressionFactory.createNewExpression should throw an Exception in case of a parsing error, not Error

2006-08-05 Thread Kohsuke Kawaguchi (JIRA)
[ http://issues.apache.org/jira/browse/JEXL-17?page=all ] Kohsuke Kawaguchi updated JEXL-17: -- Attachment: JEXL-17.diff Patch for this change. ExpressionFactory.createNewExpression should throw an Exception in case of a parsing error, not Error

[jira] Created: (JELLY-233) JellyException.getMessage() shouldn't show pointless null:-1:-1:null in the error message

2006-08-05 Thread Kohsuke Kawaguchi (JIRA)
Project: Commons Jelly Issue Type: Improvement Components: core / taglib.core Affects Versions: 1.1 Reporter: Kohsuke Kawaguchi JellyExceptions are often created without supplying location information. A little change to the JellyException.getMessage() can

svn commit: r377074 - in /jakarta/commons/sandbox/javaflow/trunk: project.properties src/java/org/apache/commons/javaflow/ContinuationDeath.java src/java/org/apache/commons/javaflow/bytecode/Continuat

2006-02-11 Thread kohsuke
Author: kohsuke Date: Sat Feb 11 14:40:03 2006 New Revision: 377074 URL: http://svn.apache.org/viewcvs?rev=377074view=rev Log: forgot to commit this change, d'oh! Added: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/ContinuationDeath.java (contents, props

svn commit: r375299 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/Continuation.java

2006-02-06 Thread kohsuke
Author: kohsuke Date: Mon Feb 6 07:45:56 2006 New Revision: 375299 URL: http://svn.apache.org/viewcvs?rev=375299view=rev Log: bug fix in the again() method implementationn. Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/Continuation.java Modified

svn commit: r375300 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/StackRecorder.java

2006-02-06 Thread kohsuke
Author: kohsuke Date: Mon Feb 6 07:46:25 2006 New Revision: 375300 URL: http://svn.apache.org/viewcvs?rev=375300view=rev Log: bug fix in the again() method implementationn. Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/StackRecorder.java

svn commit: r373215 - /jakarta/commons/sandbox/javaflow/trunk/project.xml

2006-01-28 Thread kohsuke
Author: kohsuke Date: Sat Jan 28 11:03:52 2006 New Revision: 373215 URL: http://svn.apache.org/viewcvs?rev=373215view=rev Log: reordered dependency list and classified it into categories. Modified: jakarta/commons/sandbox/javaflow/trunk/project.xml Modified: jakarta/commons/sandbox/javaflow

svn commit: r373217 - in /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow: Continuation.java bytecode/ContinuationDeath.java bytecode/StackRecorder.java

2006-01-28 Thread kohsuke
Author: kohsuke Date: Sat Jan 28 11:04:48 2006 New Revision: 373217 URL: http://svn.apache.org/viewcvs?rev=373217view=rev Log: implemented Continuation.exit() Added: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/ContinuationDeath.java (with props

Re: [Javaflow] Continuation questions

2006-01-28 Thread Kohsuke Kawaguchi
. -- Kohsuke Kawaguchi Sun Microsystems [EMAIL PROTECTED] In no particular order: o integrate just4log into the build system o testcases o documentation of the rewriting process o fix rewriting bugs/limitations: o fix unintialized objects for method/constructor calls o inner

Re: svn commit: r367531 [1/2] - in /jakarta/commons/sandbox/javaflow/trunk: ./ src/test/org/apache/commons/javaflow/ src/test/org/apache/commons/javaflow/bytecode/transformation/ src/test/org/apache/c

2006-01-14 Thread Kohsuke Kawaguchi
switch the build to commons-io-1.1. I started using javaflow for my workflow engine (http://dalma.dev.java.net/). Therefore, if possible, I'd prefer to have simpler dependencies --- so that my users can get all the necessary jars easily. -- Kohsuke Kawaguchi Sun Microsystems

Re: Javaflow and ASM

2006-01-04 Thread Kohsuke Kawaguchi
cases. It is in MUSTANG_SUPPORT branch in org.objectweb.asm.ClassWriterTest3 class. If you like I can try to put this code into SimpleVerifier subclass already used in javaflow. That would be great. -- Kohsuke Kawaguchi Sun Microsystems [EMAIL PROTECTED] smime.p7s

svn commit: r365847 - in /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm: ContinuationMethodAdapter.java ContinuationMethodAnalyzer.java

2006-01-03 Thread kohsuke
Author: kohsuke Date: Tue Jan 3 23:18:16 2006 New Revision: 365847 URL: http://svn.apache.org/viewcvs?rev=365847view=rev Log: applied a patch from Eugene Kuleshov Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm

Re: Javaflow and ASM

2006-01-03 Thread Kohsuke Kawaguchi
Eugene Kuleshov wrote: Kohsuke, I've tried to run unit tests for asm transformer on code from SVN and noticed that they all failing. I believe the reason is that you've changed SimpleVerifier to BasicVerifier in the method analyzer and not all of the checkcasts created with Object type

Re: javaflow: SimpleVerifier's getClass() method

2006-01-03 Thread Kohsuke Kawaguchi
()); } } Eric, I actually wonder if we can use getClass().getClassLoader().loadClass(...) (or Thread.currentThread().contextClassLoader().loadClass(...)) instead of Class.forName(...) method? Do you recall if there was some reasons to use Class.forName? -- Kohsuke Kawaguchi Sun Microsystems

svn commit: r365853 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAnalyzer.java

2006-01-03 Thread kohsuke
Author: kohsuke Date: Tue Jan 3 23:41:11 2006 New Revision: 365853 URL: http://svn.apache.org/viewcvs?rev=365853view=rev Log: applied another patch (but this time manually!) from Eugene. Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode

svn commit: r365854 - in /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm: AsmClassTransformer.java ContinuationMethodAdapter.java ContinuationM

2006-01-03 Thread kohsuke
Author: kohsuke Date: Tue Jan 3 23:42:14 2006 New Revision: 365854 URL: http://svn.apache.org/viewcvs?rev=365854view=rev Log: fixed indentation to conform to the Apache standard 4 SP indentation. Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode

svn commit: r360306 - in /jakarta/commons/sandbox/javaflow/trunk: ./ src/java/org/apache/commons/javaflow/utils/ src/test/ src/test/org/apache/commons/javaflow/ src/test/org/apache/commons/javaflow/fl

2005-12-31 Thread kohsuke
Author: kohsuke Date: Sat Dec 31 07:52:45 2005 New Revision: 360306 URL: http://svn.apache.org/viewcvs?rev=360306view=rev Log: removed commons-io dependency to make the footprint smaller Modified: jakarta/commons/sandbox/javaflow/trunk/project.properties jakarta/commons/sandbox/javaflow

svn commit: r360307 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/ant/AntRewriteTask.java

2005-12-31 Thread kohsuke
Author: kohsuke Date: Sat Dec 31 08:01:13 2005 New Revision: 360307 URL: http://svn.apache.org/viewcvs?rev=360307view=rev Log: added a new unpublished switch to decide which transformer to use. Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/ant

svn commit: r360309 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAnalyzer.java

2005-12-31 Thread kohsuke
Author: kohsuke Date: Sat Dec 31 08:08:18 2005 New Revision: 360309 URL: http://svn.apache.org/viewcvs?rev=360309view=rev Log: SimpleVerifier assumes that the types involved in the computation is loadable through Class.forName(), which isn't true when we are running inside Ant. The correct

svn commit: r360311 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAdapter.java

2005-12-31 Thread kohsuke
Author: kohsuke Date: Sat Dec 31 08:22:38 2005 New Revision: 360311 URL: http://svn.apache.org/viewcvs?rev=360311view=rev Log: I'm not totally sure about this change, but don't we need to pass through the values, basically? or is it really right to pass (0,0)? Modified: jakarta/commons

svn commit: r360312 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAnalyzer.java

2005-12-31 Thread kohsuke
Author: kohsuke Date: Sat Dec 31 08:24:24 2005 New Revision: 360312 URL: http://svn.apache.org/viewcvs?rev=360312view=rev Log: recorded my finding. Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm

svn commit: r360313 - /jakarta/commons/sandbox/javaflow/trunk/maven.xml

2005-12-31 Thread kohsuke
Author: kohsuke Date: Sat Dec 31 08:24:45 2005 New Revision: 360313 URL: http://svn.apache.org/viewcvs?rev=360313view=rev Log: added ${test.transformer} property to control which transformer to use for testing. Modified: jakarta/commons/sandbox/javaflow/trunk/maven.xml Modified: jakarta

svn commit: r360314 - /jakarta/commons/sandbox/javaflow/trunk/project.properties

2005-12-31 Thread kohsuke
Author: kohsuke Date: Sat Dec 31 08:25:12 2005 New Revision: 360314 URL: http://svn.apache.org/viewcvs?rev=360314view=rev Log: use BCEL for now. You can override this in your build.properties. Modified: jakarta/commons/sandbox/javaflow/trunk/project.properties Modified: jakarta/commons

Re: Javaflow and ASM

2005-12-31 Thread Kohsuke Kawaguchi
Kohsuke Kawaguchi wrote: So if you don't mind, I'm happy to make the necessary changes. Please go ahead. And if you don't mind please send me the test results you'll get. Will do. I added a new property to select the transformer, and tried to use ASM. I found a few issues

Re: svn commit: r360306 - in /jakarta/commons/sandbox/javaflow/trunk: ./ src/java/org/apache/commons/javaflow/utils/ src/test/ src/test/org/apache/commons/javaflow/ src/test/org/apache/commons/javaflo

2005-12-31 Thread Kohsuke Kawaguchi
;) I'm looking forward to seeing it. I guess it's time for me to learn Maven 2. -- Kohsuke Kawaguchi Sun Microsystems [EMAIL PROTECTED] smime.p7s Description: S/MIME Cryptographic Signature

svn commit: r360342 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/ContinuationMethodAdapter.java

2005-12-31 Thread kohsuke
Author: kohsuke Date: Sat Dec 31 09:00:16 2005 New Revision: 360342 URL: http://svn.apache.org/viewcvs?rev=360342view=rev Log: ClassWriter recalculates the values. No need to set them. Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode

Re: Javaflow and ASM

2005-12-31 Thread Kohsuke Kawaguchi
places, would it still be possible for a user to set a breakpoint and etc correctly? -- Kohsuke Kawaguchi Sun Microsystems [EMAIL PROTECTED] smime.p7s Description: S/MIME Cryptographic Signature

Re: Javaflow and ASM

2005-12-31 Thread Kohsuke Kawaguchi
By the way I thought you might find this amusing: Javaflow - the ultimate fresh-brewed coffee dispenser! http://www.javaflowllc.com/ -- Kohsuke Kawaguchi Sun Microsystems [EMAIL PROTECTED] smime.p7s Description: S/MIME Cryptographic Signature

Re: svn commit: r359600 - /jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/SerializationTestCase.java

2005-12-29 Thread Kohsuke Kawaguchi
for fixing the other stuff ...but this *should* be serializable. assertTrue(c3.isSerializable()); The Invoker is not getting instrumented and should not affect the suspend/resume nor serialization. That's what the test is about. OK. Rolled back the test case change. -- Kohsuke Kawaguchi

Re: [javaflow] a problem in ResourceTransformer abstraction

2005-12-29 Thread Kohsuke Kawaguchi
. -- Kohsuke Kawaguchi Sun Microsystems [EMAIL PROTECTED] smime.p7s Description: S/MIME Cryptographic Signature

svn commit: r359875 - /jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/SerializationTestCase.java

2005-12-29 Thread kohsuke
Author: kohsuke Date: Thu Dec 29 10:09:21 2005 New Revision: 359875 URL: http://svn.apache.org/viewcvs?rev=359875view=rev Log: rolled back this change. Modified: jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/SerializationTestCase.java Modified: jakarta

svn commit: r359570 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel/BcelClassTransformer.java

2005-12-28 Thread kohsuke
Author: kohsuke Date: Wed Dec 28 09:32:48 2005 New Revision: 359570 URL: http://svn.apache.org/viewcvs?rev=359570view=rev Log: implemented a minimum workaround to set BCEL Repository object for resolving references correctly. Still waiting for a response from Torsten about making more

svn commit: r359598 - /jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/flow/Invoker.java

2005-12-28 Thread kohsuke
Author: kohsuke Date: Wed Dec 28 11:05:48 2005 New Revision: 359598 URL: http://svn.apache.org/viewcvs?rev=359598view=rev Log: looks like the point of this class is to be not serializable, so added a comment. Modified: jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons

svn commit: r359600 - /jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/SerializationTestCase.java

2005-12-28 Thread kohsuke
Author: kohsuke Date: Wed Dec 28 11:06:06 2005 New Revision: 359600 URL: http://svn.apache.org/viewcvs?rev=359600view=rev Log: fixed this test case. Modified: jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/SerializationTestCase.java Modified: jakarta/commons

svn commit: r359604 - in /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel/analyser: ControlFlowGraph.java Frame.java InstructionContext.java Lo

2005-12-28 Thread kohsuke
Author: kohsuke Date: Wed Dec 28 11:14:03 2005 New Revision: 359604 URL: http://svn.apache.org/viewcvs?rev=359604view=rev Log: Found some redundant code, so merged them into one for better readability. (I'm actually trying to fix a JSR/RET instrumentation issue here...) Modified: jakarta

svn commit: r359605 - /jakarta/commons/sandbox/javaflow/trunk/TODO

2005-12-28 Thread kohsuke
Author: kohsuke Date: Wed Dec 28 11:14:54 2005 New Revision: 359605 URL: http://svn.apache.org/viewcvs?rev=359605view=rev Log: added a reference to a bug I filed. Modified: jakarta/commons/sandbox/javaflow/trunk/TODO Modified: jakarta/commons/sandbox/javaflow/trunk/TODO URL: http

svn commit: r359608 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel/analyser/Subroutines.java

2005-12-28 Thread kohsuke
Author: kohsuke Date: Wed Dec 28 11:23:34 2005 New Revision: 359608 URL: http://svn.apache.org/viewcvs?rev=359608view=rev Log: fixed a formatting error. Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel/analyser

svn commit: r359606 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel/analyser/LocalVariables.java

2005-12-28 Thread kohsuke
Author: kohsuke Date: Wed Dec 28 11:18:18 2005 New Revision: 359606 URL: http://svn.apache.org/viewcvs?rev=359606view=rev Log: modified to use utility methods in Arrays for better readability. Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode

svn commit: r359611 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel/analyser/Subroutines.java

2005-12-28 Thread kohsuke
Author: kohsuke Date: Wed Dec 28 11:54:05 2005 New Revision: 359611 URL: http://svn.apache.org/viewcvs?rev=359611view=rev Log: simplified the traversal code. still trying to fix the JSR/RET issue, but I think I'm getting to the core. Modified: jakarta/commons/sandbox/javaflow/trunk/src

svn commit: r359613 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel/analyser/Subroutines.java

2005-12-28 Thread kohsuke
Author: kohsuke Date: Wed Dec 28 11:55:43 2005 New Revision: 359613 URL: http://svn.apache.org/viewcvs?rev=359613view=rev Log: DFS can use ArrayList better than BFS. Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel/analyser

svn commit: r359615 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel/analyser/Subroutines.java

2005-12-28 Thread kohsuke
Author: kohsuke Date: Wed Dec 28 11:58:25 2005 New Revision: 359615 URL: http://svn.apache.org/viewcvs?rev=359615view=rev Log: removed pointless allocation of arrays. Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel/analyser

svn commit: r359623 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel/analyser/Subroutines.java

2005-12-28 Thread kohsuke
Author: kohsuke Date: Wed Dec 28 12:25:59 2005 New Revision: 359623 URL: http://svn.apache.org/viewcvs?rev=359623view=rev Log: fixed an instrumentation bug where an exception handler is used inside a finally block. Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache

svn commit: r359624 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel/BcelClassTransformer.java

2005-12-28 Thread kohsuke
Author: kohsuke Date: Wed Dec 28 12:26:28 2005 New Revision: 359624 URL: http://svn.apache.org/viewcvs?rev=359624view=rev Log: fixed a bug in handling the null value in local variables / operand stack. Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow

svn commit: r359625 - in /jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow: RewritingTestCase.java flow/FinallyFlow.java

2005-12-28 Thread kohsuke
Author: kohsuke Date: Wed Dec 28 12:26:50 2005 New Revision: 359625 URL: http://svn.apache.org/viewcvs?rev=359625view=rev Log: added a regression test case for try/catch inside a finally block. Added: jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/flow

svn commit: r359644 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel/BcelClassTransformer.java

2005-12-28 Thread kohsuke
Author: kohsuke Date: Wed Dec 28 13:41:03 2005 New Revision: 359644 URL: http://svn.apache.org/viewcvs?rev=359644view=rev Log: L-value of a method invocation may be an array. Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel

svn commit: r359645 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/utils/RewritingUtils.java

2005-12-28 Thread kohsuke
Author: kohsuke Date: Wed Dec 28 13:42:10 2005 New Revision: 359645 URL: http://svn.apache.org/viewcvs?rev=359645view=rev Log: removed a pointless message. Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/utils/RewritingUtils.java Modified: jakarta

svn commit: r359657 - in /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel: BcelClassTransformer.java analyser/ControlFlowGraph.java analyser/Ex

2005-12-28 Thread kohsuke
Author: kohsuke Date: Wed Dec 28 14:53:35 2005 New Revision: 359657 URL: http://svn.apache.org/viewcvs?rev=359657view=rev Log: improved the readability by introducing a class that represents an execution sequence. previously it was represented as an ArrayList, and therefore it was harder

svn commit: r359665 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel/BcelClassTransformer.java

2005-12-28 Thread kohsuke
Author: kohsuke Date: Wed Dec 28 15:46:03 2005 New Revision: 359665 URL: http://svn.apache.org/viewcvs?rev=359665view=rev Log: fixed a bug in instrumenting doubly-nested JSR/RET subroutines. Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode

svn commit: r359670 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel/BcelClassTransformer.java

2005-12-28 Thread kohsuke
Author: kohsuke Date: Wed Dec 28 17:03:25 2005 New Revision: 359670 URL: http://svn.apache.org/viewcvs?rev=359670view=rev Log: fixed another instrumentation issue in a rather ad-hoc way. A proper fix would require more sophisticated stack analysis. for now just do a simple pattern-match to find

[javaflow] a problem in ResourceTransformer abstraction

2005-12-27 Thread Kohsuke Kawaguchi
forward? -- Kohsuke Kawaguchi Sun Microsystems [EMAIL PROTECTED] smime.p7s Description: S/MIME Cryptographic Signature

Re: [javaflow] a problem in ResourceTransformer abstraction

2005-12-27 Thread Kohsuke Kawaguchi
Kohsuke Kawaguchi wrote: So I suggest we introduce a mechanism to resolve symbols to their class files: interface ClassImageLoader { byte[] load(String className); } .. and change ResourceTransformer as follows: interface ResourceTransformer { byte[] transform(String

Re: [javaflow] a problem in ResourceTransformer abstraction

2005-12-27 Thread Kohsuke Kawaguchi
Kohsuke Kawaguchi wrote: Kohsuke Kawaguchi wrote: So I suggest we introduce a mechanism to resolve symbols to their class files: interface ClassImageLoader { byte[] load(String className); } .. and change ResourceTransformer as follows: interface ResourceTransformer

svn commit: r359265 - in /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow: ant/AntRewriteTask.java utils/CompositeTransformer.java utils/RewritingUtils.java

2005-12-27 Thread kohsuke
Author: kohsuke Date: Tue Dec 27 11:37:58 2005 New Revision: 359265 URL: http://svn.apache.org/viewcvs?rev=359265view=rev Log: added CompositeTransformer for composing multiple transformataions into one, and simplified RewritingUtils Added: jakarta/commons/sandbox/javaflow/trunk/src/java

svn commit: r359395 - in /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode: StackRecorder.java transformation/asm/ContinuationMethodAdapter.java transformation/bcel

2005-12-27 Thread kohsuke
Author: kohsuke Date: Tue Dec 27 20:56:00 2005 New Revision: 359395 URL: http://svn.apache.org/viewcvs?rev=359395view=rev Log: eliminated isCapturing() and isRestoring() in favor of the direct field access. The problem with having methods was that it causes debugger to go into those methods

svn commit: r359175 - in /jakarta/commons/sandbox/javaflow/trunk/src/test: Justice.java RewriteTool.java

2005-12-26 Thread kohsuke
Author: kohsuke Date: Mon Dec 26 21:27:10 2005 New Revision: 359175 URL: http://svn.apache.org/viewcvs?rev=359175view=rev Log: added two small utility programs used during debuggin. I hope it's OK to put those little programs in here... Added: jakarta/commons/sandbox/javaflow/trunk/src/test

svn commit: r359177 - in /jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow: RewritingTestCase.java flow/NullVariableMethodFlow.java

2005-12-26 Thread kohsuke
Author: kohsuke Date: Mon Dec 26 21:31:04 2005 New Revision: 359177 URL: http://svn.apache.org/viewcvs?rev=359177view=rev Log: added a regression test case for the null variable handling Added: jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/flow

svn commit: r329717 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/Stack.java

2005-10-30 Thread kohsuke
Author: kohsuke Date: Sun Oct 30 19:43:11 2005 New Revision: 329717 URL: http://svn.apache.org/viewcvs?rev=329717view=rev Log: added the getRunnable() method. Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/Stack.java Modified: jakarta

svn commit: r329719 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/Stack.java

2005-10-30 Thread kohsuke
Author: kohsuke Date: Sun Oct 30 19:52:58 2005 New Revision: 329719 URL: http://svn.apache.org/viewcvs?rev=329719view=rev Log: rolling back my change. This was pointless. Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/Stack.java Modified

Re: [javaflow] Pushing new javaflow website

2005-10-21 Thread Kohsuke Kawaguchi
the entire build process in Ant? Maybe I should check what other projects are doing... -- Kohsuke Kawaguchi Sun Microsystems [EMAIL PROTECTED] smime.p7s Description: S/MIME Cryptographic Signature

Re: [javaflow] Pushing new javaflow website

2005-10-21 Thread Kohsuke Kawaguchi
- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Kohsuke Kawaguchi - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r326409 - in /jakarta/commons/sandbox/javaflow/trunk/src: java/org/apache/commons/javaflow/bytecode/ test/org/apache/commons/javaflow/

2005-10-19 Thread kohsuke
Author: kohsuke Date: Tue Oct 18 23:18:37 2005 New Revision: 326409 URL: http://svn.apache.org/viewcvs?rev=326409view=rev Log: modified the test harness and fixed some bugs so that all the unit tests will pass Added: jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons

Re: svn commit: r320947 - in /jakarta/commons/sandbox/javaflow/trunk: ./ src/java/org/apache/commons/javaflow/ src/java/org/apache/commons/javaflow/ant/ src/java/org/apache/commons/javaflow/bytecode/

2005-10-19 Thread Kohsuke Kawaguchi
the javaflow unit test? Or should I remove it? -- Kohsuke Kawaguchi Sun Microsystems [EMAIL PROTECTED] smime.p7s Description: S/MIME Cryptographic Signature

[javaflow] Pushing new javaflow website

2005-10-19 Thread Kohsuke Kawaguchi
good if we can do the same --- do you know how we can set one up? [1] http://jakarta.apache.org/commons/sandbox/javaflow/ [2] http://cvs.apache.org/builds/jakarta-commons/nightly/commons-id/ -- Kohsuke Kawaguchi Sun Microsystems [EMAIL PROTECTED] smime.p7s Description: S/MIME

svn commit: r307264 - /jakarta/commons/sandbox/javaflow/trunk/project.properties

2005-10-07 Thread kohsuke
Author: kohsuke Date: Fri Oct 7 22:41:08 2005 New Revision: 307264 URL: http://svn.apache.org/viewcvs?rev=307264view=rev Log: we need to run tests. Modified: jakarta/commons/sandbox/javaflow/trunk/project.properties Modified: jakarta/commons/sandbox/javaflow/trunk/project.properties URL

svn commit: r307265 - in /jakarta/commons/sandbox/javaflow/trunk/src: java/org/apache/commons/javaflow/bytecode/ test/org/apache/commons/javaflow/ test/org/apache/commons/javaflow/testcode/

2005-10-07 Thread kohsuke
Author: kohsuke Date: Fri Oct 7 22:47:58 2005 New Revision: 307265 URL: http://svn.apache.org/viewcvs?rev=307265view=rev Log: fixed a bug in the stack restoration. the way the reference stack works is that when a stack frame is saved, the callee pushs to the rstack, then when restored

svn commit: r297754 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/Stack.java

2005-10-05 Thread kohsuke
Author: kohsuke Date: Wed Oct 5 17:39:21 2005 New Revision: 297754 URL: http://svn.apache.org/viewcvs?rev=297754view=rev Log: added the serialization code for the runnable. since this is an incompatible change, changed serialVersionUID. Modified: jakarta/commons/sandbox/javaflow/trunk/src

svn commit: r293254 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel/BcelClassTransformer.java

2005-10-02 Thread kohsuke
Author: kohsuke Date: Sun Oct 2 22:26:35 2005 New Revision: 293254 URL: http://svn.apache.org/viewcvs?rev=293254view=rev Log: fixed a bug where the instrumentation failed to expand the stack size to the necessary size. This problem happens when instrumenting a code like: Object foo(Object

svn commit: r293257 - in /jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow: ContinuationTestCase.java ContinuationTests.java testcode/StackBug.java

2005-10-02 Thread kohsuke
Author: kohsuke Date: Sun Oct 2 22:34:51 2005 New Revision: 293257 URL: http://svn.apache.org/viewcvs?rev=293257view=rev Log: added a regression test. I guess ideally I should have filed an issue and put the issue number in this test Added: jakarta/commons/sandbox/javaflow/trunk/src/test

svn commit: r291068 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel/BcelClassTransformer.java

2005-09-22 Thread kohsuke
Author: kohsuke Date: Thu Sep 22 20:57:29 2005 New Revision: 291068 URL: http://svn.apache.org/viewcvs?rev=291068view=rev Log: added a code to work around a LinkError in JDK 5.0 Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation

svn commit: r291069 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm/AsmClassTransformer.java

2005-09-22 Thread kohsuke
Author: kohsuke Date: Thu Sep 22 20:58:13 2005 New Revision: 291069 URL: http://svn.apache.org/viewcvs?rev=291069view=rev Log: added 'this.' to make the compiler happy Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/asm

svn commit: r291070 - in /jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow: ContinuationTests.java testcode/NewObject.java

2005-09-22 Thread kohsuke
Author: kohsuke Date: Thu Sep 22 21:00:08 2005 New Revision: 291070 URL: http://svn.apache.org/viewcvs?rev=291070view=rev Log: added a file that was missing, and resurrected the test case Added: jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/testcode

svn commit: r290017 - /jakarta/commons/sandbox/javaflow/trunk/project.xml

2005-09-18 Thread kohsuke
Author: kohsuke Date: Sun Sep 18 16:54:48 2005 New Revision: 290017 URL: http://svn.apache.org/viewcvs?rev=290017view=rev Log: property files also need to be packaged into a jar file Modified: jakarta/commons/sandbox/javaflow/trunk/project.xml Modified: jakarta/commons/sandbox/javaflow

svn commit: r290018 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/ant/tasks.properties

2005-09-18 Thread kohsuke
Author: kohsuke Date: Sun Sep 18 16:55:32 2005 New Revision: 290018 URL: http://svn.apache.org/viewcvs?rev=290018view=rev Log: added a task list file for Ant Added: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/ant/tasks.properties Added: jakarta/commons

svn commit: r290019 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel/BcelClassTransformer.java

2005-09-18 Thread kohsuke
Author: kohsuke Date: Sun Sep 18 16:56:33 2005 New Revision: 290019 URL: http://svn.apache.org/viewcvs?rev=290019view=rev Log: modified to avoid instrumenting a class that was already instrumented Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode

svn commit: r290021 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/ant/AntRewriteTask.java

2005-09-18 Thread kohsuke
Author: kohsuke Date: Sun Sep 18 16:59:01 2005 New Revision: 290021 URL: http://svn.apache.org/viewcvs?rev=290021view=rev Log: - changed progress message to show the new-code-size/old-code-size (i.e., 192% means 92% code size increase due to the instrumentation.) - added a setter for srcDir. I

svn commit: r279714 - in /jakarta/commons/sandbox/javaflow/trunk/src: java/org/apache/commons/javaflow/bytecode/transformation/bcel/ test/org/apache/commons/javaflow/

2005-09-09 Thread kohsuke
Author: kohsuke Date: Thu Sep 8 23:23:52 2005 New Revision: 279714 URL: http://svn.apache.org/viewcvs?rev=279714view=rev Log: changed the way object allocations are instrumented. we now use local variables to store arguments temporarily, to improve the performance and so that we won't require

svn commit: r279715 - /jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/ContinuationTests.java

2005-09-09 Thread kohsuke
Author: kohsuke Date: Thu Sep 8 23:25:49 2005 New Revision: 279715 URL: http://svn.apache.org/viewcvs?rev=279715view=rev Log: extending Assert is a common practice to invoke JUnit assertion methods quickly. Modified: jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons

[javaflow] changed the way constructor invocations are instrumented

2005-09-09 Thread Kohsuke Kawaguchi
case for this. I'm hoping that you are OK with this changes. I haven't seen an e-mail from you for a while, so I'm assuming that you are busy with other things. That's why I decided to go ahead. -- Kohsuke Kawaguchi

Re: [javaflow] changed the way constructor invocations are instrumented

2005-09-09 Thread Kohsuke Kawaguchi
Mario Ivankovits wrote: Kohsuke Kawaguchi wrote: I haven't seen an e-mail from you for a while, so I'm assuming that you are busy with other things. He is in costa rica. Aaa, isn't that nice! His mail from party@: Any apache people somewhere in costa rica? I'll be spending the next 3

svn commit: r279258 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel/BcelClassTransformer.java

2005-09-07 Thread kohsuke
Author: kohsuke Date: Tue Sep 6 23:28:54 2005 New Revision: 279258 URL: http://svn.apache.org/viewcvs?rev=279258view=rev Log: fixed a bug in capturing long/double in the operand stack Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode

svn commit: r240002 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/Stack.java

2005-08-25 Thread kohsuke
Author: kohsuke Date: Wed Aug 24 23:00:14 2005 New Revision: 240002 URL: http://svn.apache.org/viewcvs?rev=240002view=rev Log: used isDebugEnabled to avoid unnecessary computation Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/Stack.java

svn commit: r240003 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode/transformation/bcel/BcelClassTransformer.java

2005-08-25 Thread kohsuke
Author: kohsuke Date: Wed Aug 24 23:02:07 2005 New Revision: 240003 URL: http://svn.apache.org/viewcvs?rev=240003view=rev Log: isolated debug code so that it runs only when the debug mode is on Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/bytecode

svn commit: r240004 - /jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/AbstractClassLoaderTestCase.java

2005-08-25 Thread kohsuke
Author: kohsuke Date: Wed Aug 24 23:02:51 2005 New Revision: 240004 URL: http://svn.apache.org/viewcvs?rev=240004view=rev Log: enable the debug mode for unit tests Modified: jakarta/commons/sandbox/javaflow/trunk/src/test/org/apache/commons/javaflow/AbstractClassLoaderTestCase.java

[javaflow] debug code

2005-08-25 Thread Kohsuke Kawaguchi
, I want to provide a meaningful errors right away. Telling them to manually turn on the logging won't be a very good user experience. -- Kohsuke Kawaguchi - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e

Re: [javaflow] instrumenting 'NEW' op

2005-08-16 Thread Kohsuke Kawaguchi
Kohsuke Kawaguchi wrote: Torsten Curdt wrote: I don't think I understand the instrumentation logic completely, but from a cursory look, the idea is to evaluate constructor parameters before the 'new' op (and StackRecorder is used as a temporary place to store evaluated objects.) That's

Re: [javaflow] class loader

2005-08-15 Thread Kohsuke Kawaguchi
, not URLClassLoader, but now that you mentioned it, I'm no longer too sure. Did you spot any code that look like from URLClassLoader? Should I just throw it away and reimplement it from scratch, just to be safe? -- Kohsuke Kawaguchi

svn commit: r232929 - /jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/Continuation.java

2005-08-15 Thread kohsuke
Author: kohsuke Date: Mon Aug 15 20:53:33 2005 New Revision: 232929 URL: http://svn.apache.org/viewcvs?rev=232929view=rev Log: implemented the startSuspendedWIth method Modified: jakarta/commons/sandbox/javaflow/trunk/src/java/org/apache/commons/javaflow/Continuation.java Modified

Re: [javaflow] class loader

2005-08-15 Thread Kohsuke Kawaguchi
by me. I'm confident that none of them came from URLClassLoader. So I believe there's no tainting. -- Kohsuke Kawaguchi - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r232938 - /jakarta/commons/sandbox/javaflow/trunk/xdocs/tutorial.xml

2005-08-15 Thread kohsuke
Author: kohsuke Date: Mon Aug 15 22:07:15 2005 New Revision: 232938 URL: http://svn.apache.org/viewcvs?rev=232938view=rev Log: expanded the classloader section Modified: jakarta/commons/sandbox/javaflow/trunk/xdocs/tutorial.xml Modified: jakarta/commons/sandbox/javaflow/trunk/xdocs

svn commit: r232939 - in /jakarta/commons/sandbox/javaflow/trunk: lib/jakarta-bcel-20040329.jar lib/jakarta-bcel-20050813.jar project.properties project.xml

2005-08-15 Thread kohsuke
Author: kohsuke Date: Mon Aug 15 22:08:38 2005 New Revision: 232939 URL: http://svn.apache.org/viewcvs?rev=232939view=rev Log: integrated BCEL 2005/08/13 version Added: jakarta/commons/sandbox/javaflow/trunk/lib/jakarta-bcel-20050813.jar (with props) Removed: jakarta/commons/sandbox

Re: [javaflow] instrumenting 'NEW' op

2005-08-15 Thread Kohsuke Kawaguchi
constructor into an ordinary method? -- Kohsuke Kawaguchi Sun Microsystems [EMAIL PROTECTED] smime.p7s Description: S/MIME Cryptographic Signature

Re: [javaflow] class loader

2005-08-13 Thread Kohsuke Kawaguchi
java.lang.Package correctly, but that applies to the current AntClassLoader-based one, so it's no worse. -- Kohsuke Kawaguchi - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

  1   2   >