Re: [DBCP] Remove SQLNestedException

2007-07-24 Thread Phil Steitz
quot; casts in client code, since we never advertise this > > exception. > > Sounds good. I marked the class as deprecated, moved DBCP-143 to > 1.4, and added a note to the change log. > He means v2.0 AFAICT. Details [1]. -Rahul [1] http://jakarta.apache.org/commons/release

Re: [nightly build] dbcp failed.

2007-07-24 Thread Phil Steitz
Should be fixed now. The nightlies run the m1 build and that needs the transitive dependencies to be specified. We could change the nightly to m2, but I think it is a good idea to keep the m1 build working for now and the nightly can alter us if we break it. Phil -

svn commit: r559315 - /jakarta/commons/proper/dbcp/trunk/project.xml

2007-07-24 Thread psteitz
Author: psteitz Date: Tue Jul 24 21:45:13 2007 New Revision: 559315 URL: http://svn.apache.org/viewvc?view=rev&rev=559315 Log: Added transitive dependencies needed by m1 build. Modified: jakarta/commons/proper/dbcp/trunk/project.xml Modified: jakarta/commons/proper/dbcp/trunk/project

Re: [nightly build] dbcp failed.

2007-07-24 Thread Henri Yandell
Yeah, our work CI also found it. Linux box. On 7/24/07, Rahul Akolkar <[EMAIL PROTECTED]> wrote: On 7/24/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: > Can anyone else reproduce this failure? > Yes (XP, Tiger, m102). -Rahul > -dain > > On Jul 24, 2007, at 3:03 AM, Phil Steitz wrote: > > >

Re: [nightly build] dbcp failed.

2007-07-24 Thread Rahul Akolkar
On 7/24/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: Can anyone else reproduce this failure? Yes (XP, Tiger, m102). -Rahul -dain On Jul 24, 2007, at 3:03 AM, Phil Steitz wrote: > Failed build logs: > http://vmbuild.apache.org/~commons/nightly/logs//20070724/dbcp.log > ---

Re: [DBCP] Remove SQLNestedException

2007-07-24 Thread Rahul Akolkar
tibility, so we should > probably deprecate in 1.3 and remove in the next major release. I > guess the deprecation warning / release notes should just tell people > to remove "legacy" casts in client code, since we never advertise this > exception. Sounds good. I marked the class

[dbcp] svn props (was: svn commit: r558884)

2007-07-24 Thread Rahul Akolkar
On 7/23/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Author: dain Date: Mon Jul 23 15:28:37 2007 New Revision: 558884 URL: http://svn.apache.org/viewvc?view=rev&rev=558884 Log: DBCP-221 Changed BasicDataSource.close() to permanently mark the data source as closed. At clos

svn commit: r559136 - /jakarta/commons/proper/dbcp/trunk/xdocs/changes.xml

2007-07-24 Thread dain
Author: dain Date: Tue Jul 24 10:48:05 2007 New Revision: 559136 URL: http://svn.apache.org/viewvc?view=rev&rev=559136 Log: Added note about fix to BasicDataSource.close() Modified: jakarta/commons/proper/dbcp/trunk/xdocs/changes.xml Modified: jakarta/commons/proper/dbcp/trunk/x

Re: [DBCP] Remove SQLNestedException

2007-07-24 Thread Dain Sundstrom
On Jul 24, 2007, at 7:56 AM, Phil Steitz wrote: On 7/23/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: DBCP-143 talks about problem with propagation of SQLNestedException to clients and the comment suggests a conversion to normal Java nested exception when we switch to Java 1.4. Since w

svn commit: r559128 - /jakarta/commons/proper/dbcp/trunk/xdocs/changes.xml

2007-07-24 Thread dain
Author: dain Date: Tue Jul 24 10:35:02 2007 New Revision: 559128 URL: http://svn.apache.org/viewvc?view=rev&rev=559128 Log: Added change log note on the deprecation of SQLNestedException Modified: jakarta/commons/proper/dbcp/trunk/xdocs/changes.xml Modified: jakarta/commons/proper/

[jira] Updated: (DBCP-143) [dbcp] SQLNestedException thrown by server causes client ClassNotFoundException.

2007-07-24 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dain Sundstrom updated DBCP-143: Fix Version/s: (was: 1.3) 1.4 SQLNestedException has been deprecated in 1.3

svn commit: r559119 - /jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/SQLNestedException.java

2007-07-24 Thread dain
Author: dain Date: Tue Jul 24 10:24:03 2007 New Revision: 559119 URL: http://svn.apache.org/viewvc?view=rev&rev=559119 Log: Deprecated SQLNestedException Modified: jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/SQLNestedException.java Modified: jakarta/commons/pr

Re: [nightly build] dbcp failed.

2007-07-24 Thread Dain Sundstrom
Can anyone else reproduce this failure? -dain On Jul 24, 2007, at 3:03 AM, Phil Steitz wrote: Failed build logs: http://vmbuild.apache.org/~commons/nightly/logs//20070724/dbcp.log - To unsubscribe, e-mail: [EMAIL PROTECTED] F

Re: [DBCP] Remove SQLNestedException

2007-07-24 Thread Phil Steitz
On 7/23/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: DBCP-143 talks about problem with propagation of SQLNestedException to clients and the comment suggests a conversion to normal Java nested exception when we switch to Java 1.4. Since we made the leap, I did a bit of refactoring to

[nightly build] dbcp failed.

2007-07-24 Thread Phil Steitz
Failed build logs: http://vmbuild.apache.org/~commons/nightly/logs//20070724/dbcp.log - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r558845 - in /jakarta/commons/proper/dbcp/trunk/src: java/org/apache/commons/dbcp/BasicDataSource.java test/org/apache/commons/dbcp/TestBasicDataSource.java

2007-07-23 Thread dain
Author: dain Date: Mon Jul 23 12:48:39 2007 New Revision: 558845 URL: http://svn.apache.org/viewvc?view=rev&rev=558845 Log: DBCP-150 added setter for connectionProperties in BasicDataSource Modified: jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/BasicDataSource.

svn commit: r558846 - in /jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp: PoolableConnectionFactory.java datasources/CPDSConnectionFactory.java datasources/KeyedCPDSConnectionFacto

2007-07-23 Thread dain
Author: dain Date: Mon Jul 23 12:53:27 2007 New Revision: 558846 URL: http://svn.apache.org/viewvc?view=rev&rev=558846 Log: DBCP-225 throw an IllegalStateException if connection factory returns a null connection. This avoids creating DelegatingConnections with a null delegate. Modi

svn commit: r558850 - in /jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/datasources: PerUserPoolDataSource.java SharedPoolDataSource.java

2007-07-23 Thread dain
Author: dain Date: Mon Jul 23 13:02:19 2007 New Revision: 558850 URL: http://svn.apache.org/viewvc?view=rev&rev=558850 Log: DBCP-207 only set auto-commit and read-only if the new value would be different from the current value Modified: jakarta/commons/proper/dbcp/trunk/src/java/org/ap

svn commit: r558884 - in /jakarta/commons/proper/dbcp/trunk: ./ src/java/org/apache/commons/dbcp/ src/java/org/apache/commons/dbcp/managed/ src/test/org/apache/commons/dbcp/ src/test/org/apache/common

2007-07-23 Thread dain
Author: dain Date: Mon Jul 23 15:28:37 2007 New Revision: 558884 URL: http://svn.apache.org/viewvc?view=rev&rev=558884 Log: DBCP-221 Changed BasicDataSource.close() to permanently mark the data source as closed. At close all idle connections are destroyed and the method returns. As exis

[jira] Updated: (DBCP-191) [dbcp] does not compile under the latest unreleased jdk 1.6 / JDBC 4.0

2007-07-23 Thread Michael Heuer (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Heuer updated DBCP-191: --- Attachment: patch.txt patch against nightly for 23 July 2007, or in other words $ svn co --revision

[jira] Commented: (DBCP-191) [dbcp] does not compile under the latest unreleased jdk 1.6 / JDBC 4.0

2007-07-23 Thread Michael Heuer (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514825 ] Michael Heuer commented on DBCP-191: Attached is a patch that allows commons-dbcp and its tests to compile under

[DBCP] Remove SQLNestedException

2007-07-23 Thread Dain Sundstrom
DBCP-143 talks about problem with propagation of SQLNestedException to clients and the comment suggests a conversion to normal Java nested exception when we switch to Java 1.4. Since we made the leap, I did a bit of refactoring to remove this exception class. Basically I replace: new

[jira] Updated: (DBCP-143) [dbcp] SQLNestedException thrown by server causes client ClassNotFoundException.

2007-07-23 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dain Sundstrom updated DBCP-143: Attachment: DBCP-143.patch This patch replaces: new SQLNestedException(msg, e); with

[jira] Created: (DBCP-235) accessToUnderlyingConnectionAllowed flag in ManagedConnection breaks equals, hashCode and toString

2007-07-23 Thread Dain Sundstrom (JIRA)
accessToUnderlyingConnectionAllowed flag in ManagedConnection breaks equals, hashCode and toString --- Key: DBCP-235 URL: https://issues.apache.org/jira/browse/DBCP

Re: [DBCP] close issues

2007-07-23 Thread Dain Sundstrom
certainly for dbcp, the underlying physical connections do not get closed right away in this case. I implemented the IllegalStateException idea. Now when close is called on BasicDataSource, it is marked as close and no new connections will be created (you get a SQLException). As before the

[jira] Resolved: (DBCP-221) How to close the connection pool without shutting down the JVM while there are connections being used?

2007-07-23 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dain Sundstrom resolved DBCP-221. - Resolution: Fixed Assignee: Dain Sundstrom BasicDataSource.close() now permanently marks the

Re: [DBCP] DBCP-44 Deadlock

2007-07-23 Thread Phil Steitz
teitz wrote: >> > >> >> I would love to have a fix for DBCP-44; but that could wait on >> pool >> >> 1.4 if necessary (and Ipersonally see no way to fix it just within >> >> dbcp. It would be great if I was wrong on that). >> > >

[jira] Reopened: (DBCP-212) PoolingDataSource closes physical connections

2007-07-23 Thread Marcos Sanz (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcos Sanz reopened DBCP-212: -- Not really fixed. As Phil wrote: "until pool is improved somehow to be more intelligent about destr

Re: [DBCP] JIRA workflow?

2007-07-23 Thread Henri Yandell
On 7/23/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: When issues are complete, do you close or resolve them? I have been closing them, but just noticed that may are resolved. I close em. Also, should I create a DBCP 1.4 and move the issues (like max time limit for pooled objects) we

Re: [DBCP] DBCP-44 Deadlock

2007-07-23 Thread Dain Sundstrom
On Jul 20, 2007, at 5:26 PM, Phil Steitz wrote: On 7/20/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: On Jul 20, 2007, at 11:26 AM, Dain Sundstrom wrote: > On Jul 19, 2007, at 11:19 PM, Phil Steitz wrote: > >> I would love to have a fix for DBCP-44; but that could wait on

[jira] Resolved: (DBCP-207) DBCP 1.2.1 incompatible with Informix (driver doesn't support setReadOnly(...))

2007-07-23 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dain Sundstrom resolved DBCP-207. - Resolution: Fixed Committed a fix for this specific problem, and created a JIRA for converting

[jira] Created: (DBCP-234) Only set *configured* default values for Connection

2007-07-23 Thread Dain Sundstrom (JIRA)
Only set *configured* default values for Connection --- Key: DBCP-234 URL: https://issues.apache.org/jira/browse/DBCP-234 Project: Commons Dbcp Issue Type: Improvement Reporter

[jira] Resolved: (DBCP-225) getConnection / borrowObject fails with NullPointerException

2007-07-23 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dain Sundstrom resolved DBCP-225. - Resolution: Fixed Sendingsrc/java/org/apache/commons/dbcp/PoolableConnectionFactory.java

[jira] Resolved: (DBCP-150) [dbcp] BasicDataSource : setter for connectionProperties

2007-07-23 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dain Sundstrom resolved DBCP-150. - Resolution: Fixed Sendingsrc/java/org/apache/commons/dbcp/BasicDataSource.java Sending

Re: [DBCP] JIRA workflow?

2007-07-23 Thread Antonio Petrelli
2007/7/23, Dain Sundstrom <[EMAIL PROTECTED]>: When issues are complete, do you close or resolve them? I have been closing them, but just noticed that may are resolved. In Tiles, we resolve the issues when the fix is done. We close them when a release gained a positive vote. Antonio

[jira] Resolved: (DBCP-217) Closing of underlaying connection instead of the PoolGuardConnectionWrapper

2007-07-23 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dain Sundstrom resolved DBCP-217. - Resolution: Fixed Fixed as part of DBCP-11. > Closing of underlaying connection instead of

[DBCP] JIRA workflow?

2007-07-23 Thread Dain Sundstrom
When issues are complete, do you close or resolve them? I have been closing them, but just noticed that may are resolved. Also, should I create a DBCP 1.4 and move the issues (like max time limit for pooled objects) we aren't going to get to for 1.3 over.

[jira] Closed: (DBCP-155) [dbcp] allow to set >= 6 parameters to do non-global SSL

2007-07-23 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dain Sundstrom closed DBCP-155. --- Resolution: Won't Fix > [dbcp] allow to set >= 6 parameters to do non

[jira] Closed: (DBCP-152) [DBCP] add a socketFactory attribute to BasicDataSource (to allow SSL "thread"-safe)

2007-07-23 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dain Sundstrom closed DBCP-152. --- Resolution: Won't Fix > [DBCP] add a socketFactory attribute to BasicDataSource (to a

[jira] Closed: (DBCP-97) setAutoCommit(true) when returning connection to the pool

2007-07-23 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-97?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dain Sundstrom closed DBCP-97. -- Resolution: Fixed Fixed some time ago. > setAutoCommit(true) when returning connection to the p

[jira] Closed: (DBCP-212) PoolingDataSource closes physical connections

2007-07-23 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dain Sundstrom closed DBCP-212. --- Resolution: Fixed Fixed some time ago. > PoolingDataSource closes physical connecti

[jira] Closed: (DBCP-102) [dbcp] setReadOnly & setAutoCommit called too many times

2007-07-23 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dain Sundstrom closed DBCP-102. --- Resolution: Fixed Fixed some time ago. > [dbcp] setReadOnly & setAutoCommit called too man

[jira] Closed: (DBCP-194) BasicDataSource.setLogWriter should not do createDataSource

2007-07-23 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dain Sundstrom closed DBCP-194. --- Resolution: Fixed Fixed some time ago. > BasicDataSource.setLogWriter should not do createDataSou

svn commit: r558551 - in /jakarta/commons/sandbox/performance/trunk: ./ src/java/org/apache/commons/performance/ src/java/org/apache/commons/performance/dbcp/

2007-07-22 Thread psteitz
Author: psteitz Date: Sun Jul 22 14:19:48 2007 New Revision: 558551 URL: http://svn.apache.org/viewvc?view=rev&rev=558551 Log: Moved ConfigurationException to performance package Renamed build.xml, config.xml to *-dbcp Made peak and min mean load both configurable Fixed some error

[jira] Commented: (DBCP-152) [DBCP] add a socketFactory attribute to BasicDataSource (to allow SSL "thread"-safe)

2007-07-22 Thread Ralf Hauser (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514474 ] Ralf Hauser commented on DBCP-152: -- Dain, thx for your explanations. Unfortunately, it appears that "JS

svn commit: r558398 - /jakarta/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestPerUserPoolDataSource.java

2007-07-21 Thread psteitz
Author: psteitz Date: Sat Jul 21 16:53:32 2007 New Revision: 558398 URL: http://svn.apache.org/viewvc?view=rev&rev=558398 Log: Added missing close. Modified: jakarta/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestPerUserPoolDataSource.java Modified: jak

[jira] Resolved: (DBCP-232) maxWait = 0 waits indefinitely too, not only maxWait = -1

2007-07-21 Thread Phil Steitz (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz resolved DBCP-232. -- Resolution: Fixed Javadoc fix committed in r558394. Thanks for reporting thi > maxWait = 0 wa

svn commit: r558394 - /jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/BasicDataSource.java

2007-07-21 Thread psteitz
Author: psteitz Date: Sat Jul 21 16:46:27 2007 New Revision: 558394 URL: http://svn.apache.org/viewvc?view=rev&rev=558394 Log: Fixed javadoc to match behavior when BasicDataSource maxWait is 0 (blocks indefinitely). JIRA: POOL-232 Modified: jakarta/commons/proper/dbcp/trunk/src/java

svn commit: r558393 - /jakarta/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestPerUserPoolDataSource.java

2007-07-21 Thread psteitz
mons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestPerUserPoolDataSource.java Modified: jakarta/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/datasources/TestPerUserPoolDataSource.java URL: http://svn.apache.org/viewvc/jakarta/commons/proper/dbcp/trunk/src/test

Re: [DBCP] close issues

2007-07-21 Thread Phil Steitz
On 7/21/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: On Jul 20, 2007, at 10:15 PM, Phil Steitz wrote: > On 7/20/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: >> On Jul 20, 2007, at 11:26 AM, Dain Sundstrom wrote: >> >> I think this will require a patch to p

Re: [DBCP] DBCP-44 Deadlock

2007-07-21 Thread Dain Sundstrom
On Jul 20, 2007, at 5:26 PM, Phil Steitz wrote: On 7/20/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: On Jul 20, 2007, at 11:26 AM, Dain Sundstrom wrote: > On Jul 19, 2007, at 11:19 PM, Phil Steitz wrote: > >> I would love to have a fix for DBCP-44; but that could wait on

Re: [DBCP] close issues

2007-07-21 Thread Dain Sundstrom
On Jul 20, 2007, at 10:15 PM, Phil Steitz wrote: On 7/20/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: On Jul 20, 2007, at 11:26 AM, Dain Sundstrom wrote: I think this will require a patch to pooling (documented in DBCP-221). What are the plans for pooling? This is a tiny change so we

Re: svn commit: r557176 - in /jakarta/commons/proper/dbcp/trunk: src/java/org/apache/commons/dbcp/ src/java/org/apache/commons/dbcp/cpdsadapter/ src/test/org/apache/commons/dbcp/ src/test/org/apache/c

2007-07-21 Thread Phil Steitz
z wrote: > > > Sorry I missed this in initial review. I am not sure we want to > > remove the passivate() below, since that closes statements traced by > > this connection. Am I missing something here? > > > > Phil > > > > jakarta/commons/proper/db

svn commit: r558334 - /jakarta/commons/proper/dbcp/trunk/xdocs/changes.xml

2007-07-21 Thread psteitz
Author: psteitz Date: Sat Jul 21 08:52:02 2007 New Revision: 558334 URL: http://svn.apache.org/viewvc?view=rev&rev=558334 Log: Document change in r558332. Modified: jakarta/commons/proper/dbcp/trunk/xdocs/changes.xml Modified: jakarta/commons/proper/dbcp/trunk/xdocs/changes.xml URL:

[jira] Resolved: (DBCP-11) [dbcp] stmt.getConnection() != Connection used to create the statement

2007-07-21 Thread Phil Steitz (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-11?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz resolved DBCP-11. - Resolution: Fixed Patch applied. Thanks. > [dbcp] stmt.getConnection() != Connection used to create

svn commit: r558332 - in /jakarta/commons/proper/dbcp/trunk/src: java/org/apache/commons/dbcp/ test/org/apache/commons/dbcp/ test/org/apache/commons/dbcp/datasources/ test/org/apache/commons/dbcp/mana

2007-07-21 Thread psteitz
are wrapped with a delegating object, which already properly handle the back pointers for Connection and Statement. Also added tests to to assure that the *same* object used to create the statement or result set is returned from either getConnection() or getStatement(). JIRA: DBCP-11 Patch provide

svn commit: r558331 - /jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/DelegatingConnection.java

2007-07-21 Thread psteitz
Author: psteitz Date: Sat Jul 21 08:44:03 2007 New Revision: 558331 URL: http://svn.apache.org/viewvc?view=rev&rev=558331 Log: Fixed typo in comment. Modified: jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/DelegatingConnection.java Modified: jakarta/commons/pr

Re: [DBCP] close issues

2007-07-20 Thread Phil Steitz
On 7/20/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: On Jul 20, 2007, at 11:26 AM, Dain Sundstrom wrote: > On Jul 19, 2007, at 11:19 PM, Phil Steitz wrote: > >> On 7/19/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: >>> Are there any DBCP-1.3 release plans? Base

[DBCP] close issues

2007-07-20 Thread Dain Sundstrom
On Jul 20, 2007, at 11:26 AM, Dain Sundstrom wrote: On Jul 19, 2007, at 11:19 PM, Phil Steitz wrote: On 7/19/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: Are there any DBCP-1.3 release plans? Based on the JIRAs I think we are close to being ready to release. Are there any items th

Re: [DBCP] DBCP-44 Deadlock

2007-07-20 Thread Phil Steitz
On 7/20/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: On Jul 20, 2007, at 11:26 AM, Dain Sundstrom wrote: > On Jul 19, 2007, at 11:19 PM, Phil Steitz wrote: > >> I would love to have a fix for DBCP-44; but that could wait on pool >> 1.4 if necessary (and Ipersonally s

[jira] Commented: (DBCP-44) [dbcp] Evictor thread in GenericObjectPool has potential for deadlock

2007-07-20 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514366 ] Dain Sundstrom commented on DBCP-44: Ok one more comment before I get lunch My sample code above is bad. It

[jira] Commented: (DBCP-44) [dbcp] Evictor thread in GenericObjectPool has potential for deadlock

2007-07-20 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514364 ] Dain Sundstrom commented on DBCP-44: BTW it isn't the evictor thread that is problematic per say (it could

[jira] Commented: (DBCP-44) [dbcp] Evictor thread in GenericObjectPool has potential for deadlock

2007-07-20 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514362 ] Dain Sundstrom commented on DBCP-44: This will take experimentation, but off the top of my head, I'd do som

[jira] Commented: (DBCP-44) [dbcp] Evictor thread in GenericObjectPool has potential for deadlock

2007-07-20 Thread JIRA
[ https://issues.apache.org/jira/browse/DBCP-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514358 ] Holger Hoffstätte commented on DBCP-44: --- Hi Dain, I agree that the evictor thread is problematic (it should go

Re: [DBCP] DBCP-44 Deadlock

2007-07-20 Thread Dain Sundstrom
On Jul 20, 2007, at 11:26 AM, Dain Sundstrom wrote: On Jul 19, 2007, at 11:19 PM, Phil Steitz wrote: I would love to have a fix for DBCP-44; but that could wait on pool 1.4 if necessary (and Ipersonally see no way to fix it just within dbcp. It would be great if I was wrong on that). I

[jira] Updated: (DBCP-44) [dbcp] Evictor thread in GenericObjectPool has potential for deadlock

2007-07-20 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dain Sundstrom updated DBCP-44: --- Attachment: DBCP-44.patch This is an architectural problem in commons-pool

Re: [DBCP] Release 1.3 soon?

2007-07-20 Thread Dain Sundstrom
On Jul 19, 2007, at 11:19 PM, Phil Steitz wrote: On 7/19/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: Are there any DBCP-1.3 release plans? Based on the JIRAs I think we are close to being ready to release. Are there any items that are planned but don't have JIRAs? There are

[DBCP] JIRAs [was: Release 1.3 soon?]

2007-07-20 Thread Dain Sundstrom
On Jul 19, 2007, at 11:19 PM, Phil Steitz wrote: Here are some open JIRAs I think we can close: Fixed: DBCP-194 BasicDataSource.setLogWriter should not do createDataSource DBCP-102 setReadOnly & setAutoCommit called too many times DBCP-97 setAutoCommit(true) when returning connection to

[jira] Commented: (DBCP-152) [DBCP] add a socketFactory attribute to BasicDataSource (to allow SSL "thread"-safe)

2007-07-20 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514273 ] Dain Sundstrom commented on DBCP-152: - Ralf, Security is a very important issue for me, so I'm not saying t

Re: [jira] Updated: (DBCP-53) 'not supported' error given against Firebird DB

2007-07-20 Thread Henri Yandell
I've moved this issue over to the Torque JIRA project, rather than closing and asking the user to open one there. Hen On 7/20/07, Henri Yandell (JIRA) <[EMAIL PROTECTED]> wrote: [ https://issues.apache.org/jira/browse/DBCP-53?page=com.atlassian.jira.plugin.system.issueta

[jira] Updated: (DBCP-53) 'not supported' error given against Firebird DB

2007-07-20 Thread Henri Yandell (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Yandell updated DBCP-53: -- Summary: 'not supported' error given against Firebird DB (was: [dbcp] commons dbcp does no

[jira] Commented: (DBCP-152) [DBCP] add a socketFactory attribute to BasicDataSource (to allow SSL "thread"-safe)

2007-07-20 Thread Ralf Hauser (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514130 ] Ralf Hauser commented on DBCP-152: -- Allowing for a non-global SSL socket factory has nothing to do with mysql. Even

[jira] Commented: (DBCP-155) [dbcp] allow to set >= 6 parameters to do non-global SSL

2007-07-20 Thread Ralf Hauser (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514125 ] Ralf Hauser commented on DBCP-155: -- I certainly agree that you should not break the standards. However, if you can

Re: svn commit: r557176 - in /jakarta/commons/proper/dbcp/trunk: src/java/org/apache/commons/dbcp/ src/java/org/apache/commons/dbcp/cpdsadapter/ src/test/org/apache/commons/dbcp/ src/test/org/apache/c

2007-07-19 Thread Phil Steitz
tion on the second close. -dain On Jul 19, 2007, at 10:33 PM, Phil Steitz wrote: > Sorry I missed this in initial review. I am not sure we want to > remove the passivate() below, since that closes statements traced by > this connection. Am I missing something here? > > Phil >

Re: svn commit: r557176 - in /jakarta/commons/proper/dbcp/trunk: src/java/org/apache/commons/dbcp/ src/java/org/apache/commons/dbcp/cpdsadapter/ src/test/org/apache/commons/dbcp/ src/test/org/apache/c

2007-07-19 Thread Dain Sundstrom
ments traced by this connection. Am I missing something here? Phil jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/ DelegatingConnection.java Tue Jul 17 23:46:16 2007 @@ -208,10 +208,17 @@ * Closes the underlying connection, and close * any Statements that wer

Re: [DBCP] Release 1.3 soon?

2007-07-19 Thread Phil Steitz
On 7/19/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: Are there any DBCP-1.3 release plans? Based on the JIRAs I think we are close to being ready to release. Are there any items that are planned but don't have JIRAs? There are two things that I would like to at least talk about

Re: [DBCP] Remove primitive default values?

2007-07-19 Thread Phil Steitz
On 7/19/07, Dain Sundstrom <[EMAIL PROTECTED]> wrote: The PerUserDataSource and SharedPoolDataSource use primitives for the read only, transaction isolation and auto commit default values so there is not way to see if the value was set in the configuration. This means there is no way to allow th

Re: svn commit: r557176 - in /jakarta/commons/proper/dbcp/trunk: src/java/org/apache/commons/dbcp/ src/java/org/apache/commons/dbcp/cpdsadapter/ src/test/org/apache/commons/dbcp/ src/test/org/apache/c

2007-07-19 Thread Phil Steitz
Sorry I missed this in initial review. I am not sure we want to remove the passivate() below, since that closes statements traced by this connection. Am I missing something here? Phil jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/DelegatingConnection.java Tue Jul 17 23:46

[jira] Updated: (DBCP-225) getConnection / borrowObject fails with NullPointerException

2007-07-19 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dain Sundstrom updated DBCP-225: Attachment: DBCP-225.patch This patch checks for null returned from connection factory and throws an

[jira] Updated: (DBCP-150) [dbcp] BasicDataSource : setter for connectionProperties

2007-07-19 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dain Sundstrom updated DBCP-150: Attachment: DBCP-150.patch Implementation, java doc and test case > [dbcp] BasicDataSource : set

[DBCP] Release 1.3 soon?

2007-07-19 Thread Dain Sundstrom
Are there any DBCP-1.3 release plans? Based on the JIRAs I think we are close to being ready to release. Are there any items that are planned but don't have JIRAs? -dain Here are some open JIRAs I think we can close: Fixed: DBCP-194 BasicDataSource.setLogWriter should n

[DBCP] Remove primitive default values?

2007-07-19 Thread Dain Sundstrom
The PerUserDataSource and SharedPoolDataSource use primitives for the read only, transaction isolation and auto commit default values so there is not way to see if the value was set in the configuration. This means there is no way to allow the driver defaults to pass through like in the P

[jira] Updated: (DBCP-207) DBCP 1.2.1 incompatible with Informix (driver doesn't support setReadOnly(...))

2007-07-19 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dain Sundstrom updated DBCP-207: Attachment: DBCP-207.patch Already fixed for PoolingDataSource, but PerUserDataSource and

[jira] Updated: (DBCP-110) [dbcp] DBCP removeAbandoned not working

2007-07-19 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dain Sundstrom updated DBCP-110: Summary: [dbcp] DBCP removeAbandoned not working (was: [dbcp] Problem reported at

[jira] Commented: (DBCP-152) [DBCP] add a socketFactory attribute to BasicDataSource (to allow SSL "thread"-safe)

2007-07-19 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514054 ] Dain Sundstrom commented on DBCP-152: - DBCP supports JDBC standard properties, so if mysql ssl can be configured

[jira] Commented: (DBCP-155) [dbcp] allow to set >= 6 parameters to do non-global SSL

2007-07-19 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514053 ] Dain Sundstrom commented on DBCP-155: - DBCP has support for JDBC connection properties. The JSSE properties you

[jira] Commented: (DBCP-97) setAutoCommit(true) when returning connection to the pool

2007-07-19 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514044 ] Dain Sundstrom commented on DBCP-97: Yes, this is correct. When auto commit is off, you have an open transaction

[jira] Resolved: (DBCP-209) Is DataSource.getConnection(user, pass) working the way it is suppose to?

2007-07-19 Thread Phil Steitz (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz resolved DBCP-209. -- Resolution: Invalid I agree with Dain. For BasicDataSource, the username and password are pool

[jira] Commented: (DBCP-53) [dbcp] commons dbcp does not supports Firebird DB.

2007-07-19 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514039 ] Dain Sundstrom commented on DBCP-53: I don't think this is a DBCP issue. My guess is your torque configurati

[jira] Commented: (DBCP-209) Is DataSource.getConnection(user, pass) working the way it is suppose to?

2007-07-19 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514033 ] Dain Sundstrom commented on DBCP-209: - I believe that Michael should be using either the SharedPoolDataSource or

svn commit: r557488 - /jakarta/commons/proper/dbcp/trunk/xdocs/changes.xml

2007-07-18 Thread psteitz
Author: psteitz Date: Wed Jul 18 21:22:23 2007 New Revision: 557488 URL: http://svn.apache.org/viewvc?view=rev&rev=557488 Log: Added other boogs slain in r557176. Modified: jakarta/commons/proper/dbcp/trunk/xdocs/changes.xml Modified: jakarta/commons/proper/dbcp/trunk/xdocs/changes.xml

[jira] Resolved: (DBCP-23) [dbcp] SQLException When PoolablePreparedStatement Already Closed

2007-07-18 Thread Phil Steitz (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz resolved DBCP-23. - Resolution: Fixed Fixed in r 557176. > [dbcp] SQLException When PoolablePreparedStatement Already Clo

[jira] Resolved: (DBCP-5) [dbcp] PoolGuardConnectionWrapper violates close() contract

2007-07-18 Thread Phil Steitz (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz resolved DBCP-5. Resolution: Fixed Fixed in r 557176. > [dbcp] PoolGuardConnectionWrapper violates close() contr

Re: [DBCP] Back pointers

2007-07-18 Thread Dain Sundstrom
Sounds good to me. I attached my fix to DBCP-11. This patch assures that all all returned Statements, PreparedStatements, CallableStatements and ResultSets are wrapped with a delegating object, which already properly handle the back pointers for Connection and Statement. This patch

[jira] Updated: (DBCP-11) [dbcp] stmt.getConnection() != Connection used to create the statement

2007-07-18 Thread Dain Sundstrom (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-11?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dain Sundstrom updated DBCP-11: --- Attachment: back-pointers.patch This patch assures that all all returned Statements, PreparedStatements

[DBCP] More duplicate close JIRAs to close

2007-07-18 Thread Dain Sundstrom
I believe the duplicate close fix also addresses these JIRAs: DBCP-5 PoolGuardConnectionWrapper violates close() contract DBCP-23 SQLException When PoolablePreparedStatement Already Closed -dain - To unsubscribe, e-mail

[jira] Resolved: (DBCP-3) [dbcp] PoolableConnection.close() won't allow multiple close

2007-07-17 Thread Phil Steitz (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz resolved DBCP-3. Resolution: Fixed Fixed in r 557176. > [dbcp] PoolableConnection.close() won't allow multip

[jira] Resolved: (DBCP-134) [dbcp] DelegatingConnection.close() throws exception

2007-07-17 Thread Phil Steitz (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz resolved DBCP-134. -- Resolution: Fixed Fixed in r 557176. > [dbcp] DelegatingConnection.close() throws except

[jira] Resolved: (DBCP-233) Allow connection, statement, and result set to be closed multiple times

2007-07-17 Thread Phil Steitz (JIRA)
[ https://issues.apache.org/jira/browse/DBCP-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz resolved DBCP-233. -- Resolution: Fixed Patch applied. Many thanks. > Allow connection, statement, and result set to

svn commit: r557176 - in /jakarta/commons/proper/dbcp/trunk: src/java/org/apache/commons/dbcp/ src/java/org/apache/commons/dbcp/cpdsadapter/ src/test/org/apache/commons/dbcp/ src/test/org/apache/commo

2007-07-17 Thread psteitz
the resource is closed and any subsequent calls have no effect. This behavior is required as per the JavaDocs for these classes. Also added tests for closing all types multiple times and updated any tests that incorrectly assert that a resource can not be closed more then once. JIRA: DBCP-233 Patch prov

  1   2   3   4   5   6   7   8   9   10   >