Re: [digester2] Additions

2005-02-14 Thread Simon Kitching
Hi Oliver, On Mon, 2005-02-14 at 08:16 +0100, Oliver Zeigermann wrote: [update] - now all member variables of DefaultRuleManager are private - introduced copy ctor for copying members from subclasses thanks - that looks good to me. - DefaultRuleManager now returns an unmodifiable list

Re: [digester2] Additions

2005-02-14 Thread Oliver Zeigermann
On Tue, 15 Feb 2005 01:08:53 +1300, Simon Kitching [EMAIL PROTECTED] wrote: - DefaultRuleManager now returns an unmodifiable list upon getMatchingActions I'm not so sure about this one. This change means a new object is created each time getMatchingActions is called, and that is once

Re: [digester2] Additions

2005-02-14 Thread Simon Kitching
On Mon, 2005-02-14 at 17:24 +0100, Oliver Zeigermann wrote: On Tue, 15 Feb 2005 01:08:53 +1300, Simon Kitching [EMAIL PROTECTED] wrote: - DefaultRuleManager now returns an unmodifiable list upon getMatchingActions I'm not so sure about this one. This change means a new object is

Re: [digester2] Additions

2005-02-14 Thread Oliver Zeigermann
On Tue, 15 Feb 2005 11:27:29 +1300, Simon Kitching [EMAIL PROTECTED] wrote: On Mon, 2005-02-14 at 17:24 +0100, Oliver Zeigermann wrote: On Tue, 15 Feb 2005 01:08:53 +1300, Simon Kitching [EMAIL PROTECTED] wrote: - DefaultRuleManager now returns an unmodifiable list upon

Re: [digester2] Additions

2005-02-14 Thread Simon Kitching
On Tue, 2005-02-15 at 01:35 +0100, Oliver Zeigermann wrote: After I have thought about it, I am +1 to do it the way you proposed initially: have it all in one class. That's not because I am frustrated or am no longer interested, but I think that's a good solution and causes the least

Re: [digester2] Additions

2005-02-13 Thread Oliver Zeigermann
One design goal was to avoid using protected members. The problem here is that using protected for a *member variable* locks us into an implementation forever (a protected member is part of the external api that users can access). I think it preferable to add a public or protected method that

Re: [digester2] Additions

2005-02-13 Thread Oliver Zeigermann
[update] - now all member variables of DefaultRuleManager are private - introduced copy ctor for copying members from subclasses - DefaultRuleManager now returns an unmodifiable list upon getMatchingActions - created a new FallbackRuleManager class that only takes care about fallback actions -

Re: [digester2] Additions

2005-02-12 Thread Simon Kitching
On Sat, 2005-02-12 at 08:28 +0100, Oliver Zeigermann wrote: Hi Simon, I have now committed the first proposal for the XMLIO like rule manager called SupplementaryRuleManager. I also added a very basic test for it. I had to make a minor visibility change in DefaultRuleManager that it

Re: [digester2] Additions

2005-02-11 Thread Oliver Zeigermann
Hi Simon, I have now committed the first proposal for the XMLIO like rule manager called SupplementaryRuleManager. I also added a very basic test for it. I had to make a minor visibility change in DefaultRuleManager that it extends. Path now has match methods. All this isn't perfect, especially

[digester2] Additions

2005-02-10 Thread Oliver Zeigermann
Folks, as I noticed Simon has done so much work on Digester2, I just wanted to be sure that my scheduled additions still are appropriate and aligned to the overall design. Here they are: (1) XMLIORuleManager: A rule manager that takes an action and unconditionally calls it on any event. It's

Re: [digester2] Additions

2005-02-10 Thread Simon Kitching
Hi Oliver, On Thu, 2005-02-10 at 19:08 +0100, Oliver Zeigermann wrote: Folks, as I noticed Simon has done so much work on Digester2, I just wanted to be sure that my scheduled additions still are appropriate and aligned to the overall design. Here they are: (1) XMLIORuleManager: A rule