Okay Boss.
Apache license and test class submitted.
Mark
On 30 Sep 2004, at 15:09, David Graham wrote:
Validator uses the standard Java coding conventions. Considering I
don't
know anything about ISBN numbers I would need a JUnit test case
proving it
works and some javadoc describing the ISBN
Validator uses the standard Java coding conventions. Considering I don't
know anything about ISBN numbers I would need a JUnit test case proving it
works and some javadoc describing the ISBN rules before I would commit
anything. Add the Apache 2.0 license to the top of your .java files
before att
http://www.generationjava.com/research/ISBN.java for one to compare against.
Hen
On Thu, 30 Sep 2004 08:56:13 -0400, Henri Yandell <[EMAIL PROTECTED]> wrote:
> Having a quick peek, I don't see any code in there to handle X being
> 10. Have you tested it for an ISBN with an X of 10 yet. Currently
Having a quick peek, I don't see any code in there to handle X being
10. Have you tested it for an ISBN with an X of 10 yet. Currently it
looks as though it strips out X's.
Submitting a unit-test class as well is always very useful, especially
with new classes.
Hen
On Thu, 30 Sep 2004 12:53:43
Hello
I've just written an ISBN validator I don't think i can diff a file
that doesn't exist. But i'd like to see if its of use to anyone other
than myself.
I've attached it and i'll just check the commons stuff out of cvs and
see if there's a jalopy template that could iron out anything that
