Re: Javaflow and ASM

2006-01-04 Thread Eugene Kuleshov
Kohsuke Kawaguchi wrote: Another possible approach could be to use results of DataflowInterpeter to find an instructions that are consuming given stack value and then cast to the type required by this instruction, but I am not sure if there are some gaps in this approach, e.g. if locals

Re: Javaflow and ASM

2006-01-04 Thread Kohsuke Kawaguchi
Eugene Kuleshov wrote: Actually your above example should be quite simple, especially if we can assume that we know local variable types (e.g. debug information is available): Well, sure, if you can use debug information, but I don't think we can assume that in javaflow, can we.

Re: Javaflow and ASM

2006-01-04 Thread Eugene Kuleshov
Kohsuke Kawaguchi wrote: Actually your above example should be quite simple, especially if we can assume that we know local variable types (e.g. debug information is available): Well, sure, if you can use debug information, but I don't think we can assume that in javaflow, can we. It

Re: Javaflow and ASM

2006-01-03 Thread Eugene Kuleshov
Kohsuke, I've tried to run unit tests for asm transformer on code from SVN and noticed that they all failing. I believe the reason is that you've changed SimpleVerifier to BasicVerifier in the method analyzer and not all of the checkcasts created with Object type. So, I am afraid that

Re: Javaflow and ASM

2006-01-03 Thread Kohsuke Kawaguchi
Eugene Kuleshov wrote: Kohsuke, I've tried to run unit tests for asm transformer on code from SVN and noticed that they all failing. I believe the reason is that you've changed SimpleVerifier to BasicVerifier in the method analyzer and not all of the checkcasts created with Object type.

Re: Javaflow and ASM

2005-12-31 Thread Kohsuke Kawaguchi
Kohsuke Kawaguchi wrote: So if you don't mind, I'm happy to make the necessary changes. Please go ahead. And if you don't mind please send me the test results you'll get. Will do. I added a new property to select the transformer, and tried to use ASM. I found a few issues. -

Re: Javaflow and ASM

2005-12-31 Thread Kohsuke Kawaguchi
Eugene Kuleshov wrote: - ContinuationMethodAdapter.visitMaxs was passing (0,0) to the next visitor. I'm not too familiar with this, but don't we need to basically pass through values? It is actually ok. ClassWriter is used with computeMaxs flag, so visitMaxs() method is basically an

Re: Javaflow and ASM

2005-12-31 Thread Kohsuke Kawaguchi
By the way I thought you might find this amusing: Javaflow - the ultimate fresh-brewed coffee dispenser! http://www.javaflowllc.com/ -- Kohsuke Kawaguchi Sun Microsystems [EMAIL PROTECTED] smime.p7s Description: S/MIME Cryptographic Signature

Re: Javaflow and ASM

2005-12-31 Thread Eugene Kuleshov
Kohsuke Kawaguchi wrote: So if you don't mind, I'm happy to make the necessary changes. Please go ahead. And if you don't mind please send me the test results you'll get. Will do. I added a new property to select the transformer, and tried to use ASM. I found a few issues. -

Re: Javaflow and ASM

2005-12-31 Thread Eugene Kuleshov
Kohsuke Kawaguchi wrote: - When moving 'new' instructions, local variables are allocated excessively. I think it would be better for it to be used little more conservatively. Namely, the number of additional local variables for save/restore should be max of all constructor parameter counts,

svn commit: r209036 - in /jakarta/commons/sandbox/javaflow/trunk: ./ lib/ src/java/org/apache/commons/javaflow/ src/java/org/apache/commons/javaflow/bytecode/ src/java/org/apache/commons/javaflow/bytecode/asm/ src/test/org/apache/commons/javaflow/testc...

2005-07-04 Thread tcurdt
Author: tcurdt Date: Mon Jul 4 02:01:47 2005 New Revision: 209036 URL: http://svn.apache.org/viewcvs?rev=209036view=rev Log: first steps of an ASM based implementation Added: jakarta/commons/sandbox/javaflow/trunk/lib/asm-20050703.234510.jar (with props) jakarta/commons/sandbox

svn commit: r191665 - in /jakarta/commons/sandbox/javaflow/trunk: ./ lib/ src/java/org/apache/commons/javaflow/ src/java/org/apache/commons/javaflow/bytecode/ src/java/org/apache/commons/javaflow/bytecode/asm/ src/java/org/apache/commons/javaflow/bytec...

2005-06-21 Thread tcurdt
array as input Added: jakarta/commons/sandbox/javaflow/trunk/lib/asm-2.0.jar (with props) jakarta/commons/sandbox/javaflow/trunk/lib/asm-tree-2.0.jar (with props) jakarta/commons/sandbox/javaflow/trunk/lib/commons-io-20050621.133116.jar (with props) jakarta/commons/sandbox