Re: More abuse of coding styles...

2002-01-04 Thread robert burrell donkin
i'd just like to point out that i didn't write that bit of code (but neither did i correct it). personally speaking, i'm not going to risk having patches vetoed because i try to correct the original author's coding style. any committer who has the time and energy to fight is very welcome to c

Re: More abuse of coding styles...

2002-01-04 Thread Endre Stølsvik
On Thu, 3 Jan 2002, Jon Scott Stevens wrote: | It is amazing to me...with all the discussion about coding styles and | following them, we still have people committing code that doesn't follow | what rules we do have... | | on 1/3/02 11:00 AM, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote: | | Re:

Re: More abuse of coding styles...

2002-01-04 Thread bayard
Yeah, it's sitting right in front of me :) On Fri, 4 Jan 2002, Ted Husted wrote: > A nice alternative to Sun's (a superset really) is the Elements of Java > Style. Highly recommended. > > http://www.amazon.com/exec/obidos/ASIN/0521777682 > > > [EMAIL PROTECTED] wrote: > > > > > Sigh. That isn't

Re: More abuse of coding styles...

2002-01-04 Thread Ted Husted
A nice alternative to Sun's (a superset really) is the Elements of Java Style. Highly recommended. http://www.amazon.com/exec/obidos/ASIN/0521777682 [EMAIL PROTECTED] wrote: > > > Sigh. That isn't the argument. The argument is about following what > > conventions we do have. It could be about

Re: More abuse of coding styles...

2002-01-04 Thread bayard
> Sigh. That isn't the argument. The argument is about following what > conventions we do have. It could be about coding, voting policies, > whatever...if people ignore the rules, then we shouldn't bother having rules > at all. I'm going through exactly this situation in my new employment. One gr

Re: More abuse of coding styles...

2002-01-04 Thread bayard
> Anyone ever thought of running the code through a code fomatter when the > nightly build is done?... that'd save all issues and arguments (except > those of naming conventions). Have you got good success of using this on a project? My experience has been that it causes pain in CVS. Instead yo

Re: More abuse of coding styles...

2002-01-03 Thread Jon Scott Stevens
on 1/3/02 9:26 PM, "Arron Bates" <[EMAIL PROTECTED]> wrote: > Couldn't we all just agree that arguing about coding convention is like > bringing up politics and religion at a dinner party?... Sigh. That isn't the argument. The argument is about following what conventions we do have. It could be

Re: More abuse of coding styles...

2002-01-03 Thread Jon Scott Stevens
on 1/3/02 9:04 PM, "Donnie Hale" <[EMAIL PROTECTED]> wrote: > Not to be nitpicky, but doesn't Turbine have a coding standard document that > differs from the "official" Java conventions to which you refer? Not a big > deal - IIRC, I much prefer Turbine's brace placement vs. the "standard". I > ju

Re: More abuse of coding styles...

2002-01-03 Thread Arron Bates
Couldn't we all just agree that arguing about coding convention is like bringing up politics and religion at a dinner party?... When you work with a team of developers, you'll end up working amongst many styles and preferences, like it or not. Just as long as the big ones aren't broken (eg. if

RE: More abuse of coding styles...

2002-01-03 Thread Donnie Hale
o Sun's conventions but are on a project with some differences. Donnie > -Original Message- > From: Jon Scott Stevens [mailto:[EMAIL PROTECTED]] > Sent: Thursday, January 03, 2002 8:54 PM > To: Jakarta Commons Developers List > Cc: [EMAIL PROTECTED] > Subject: Mor

Re: More abuse of coding styles...

2002-01-03 Thread Jeff Turner
On Thu, Jan 03, 2002 at 05:54:20PM -0800, Jon Scott Stevens wrote: > It is amazing to me...with all the discussion about coding styles and > following them, we still have people committing code that doesn't follow > what rules we do have... > > on 1/3/02 11:00 AM, "[EMAIL PROTECTED]" <[EMAIL PROT

More abuse of coding styles...

2002-01-03 Thread Jon Scott Stevens
It is amazing to me...with all the discussion about coding styles and following them, we still have people committing code that doesn't follow what rules we do have... on 1/3/02 11:00 AM, "[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote: Re: cvs commit: jakarta-commons/logging/src/java/org/apache/c