RE: [lang] customizing the PMD report [WAS Re: added empty statement to empty catch blocks [WAS: svn commit: r202043 - in /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang: NumberUtils.java SerializationUtils.java enum/Enum.java enu

2005-06-29 Thread Gary Gregory
Steven Caswell wrote: " > Actually, I was proposing to leave the ; in to mark the empty > statement (sorry I wasn't clear). I'd prefer not to have the ; if possible. It just looks and feels very odd, esp. when a comment would do logically. Stephen " +1 from me. Gary

Re: [lang] customizing the PMD report [WAS Re: added empty statement to empty catch blocks [WAS: svn commit: r202043 - in /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang: NumberUtils.java SerializationUtils.java enum/Enum.java enu

2005-06-29 Thread Steven Caswell
My reasoning behind using a semicolon is that this is the defined statement in the Language Specification for denoting an empty statement, and something that code checkers/syntax parsers/etc can easily be told to look for. One syntax, no ambiguity. As opposed to comments which are not the language-

Re: [lang] customizing the PMD report [WAS Re: added empty statement to empty catch blocks [WAS: svn commit: r202043 - in /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang: NumberUtils.java SerializationUtils.java enum/Enum.java enu

2005-06-29 Thread Stephen Colebourne
Steven Caswell wrote: Actually, I was proposing to leave the ; in to mark the empty statement (sorry I wasn't clear). I'd prefer not to have the ; if possible. It just looks and feels very odd, esp. when a comment would do logically. Stephen -

RE: [lang] customizing the PMD report [WAS Re: added empty statement to empty catch blocks [WAS: svn commit: r202043 - in /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang: NumberUtils.java SerializationUtils.java enum/Enum.java enu

2005-06-29 Thread Gary Gregory
Developers List Subject: Re: [lang] customizing the PMD report [WAS Re: added empty statement to empty catch blocks [WAS: svn commit: r202043 - in /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang: NumberUtils.java SerializationUtils.java enum/Enum.java enu Actually, I was proposing

Re: [lang] customizing the PMD report [WAS Re: added empty statement to empty catch blocks [WAS: svn commit: r202043 - in /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang: NumberUtils.java SerializationUtils.java enum/Enum.java enu

2005-06-29 Thread Steven Caswell
Actually, I was proposing to leave the ; in to mark the empty statement (sorry I wasn't clear).This is the simplest way to make PMD know about the empty statement. On 6/29/05, Gary Gregory <[EMAIL PROTECTED]> wrote: > I am +1 on removing the ";" and making the style checker behave with > reason. >