Re: connection leak in HttpMethodBase when HttpRecoverableException is re-thrown

2003-09-25 Thread danch
Thanks Michael. If you determine that HttpClient shouldn't be automatically releasing in this case, I'll take the issue up on the Axis side. thanks again, danch Michael Becke wrote: I will investigate automatic release for this case and will let you know what I come up with. If anyone else has

connection leak in HttpMethodBase when HttpRecoverableException is re-thrown

2003-09-24 Thread danch
() + returned false, rethrowing exception ); +doneWithConnection = true; throw httpre; } } thanks, danch - To unsubscribe, e

Re: connection leak in HttpMethodBase when HttpRecoverableException is re-thrown

2003-09-24 Thread danch
- the patch for that seems to be for HEAD, not the release 2 branch. Actually, I'd also seen bug 22841 - that fixes releases where an exception pops out of the close call in releaseConnection. In my case, the problem was that releaseConnection was never called. thanks again, danch Eric Johnson wrote

Re: connection leak in HttpMethodBase when HttpRecoverableException is re-thrown

2003-09-24 Thread danch
because some exception cases _are_ handled internally to HttpClient (IOException from connection.open is handled in HttpClient.executeMethod, for example). What is the rule for who should call the releaseConnection method when? thanks, danch Michael Becke wrote: Danch, Are you calling

Re: connection leak in HttpMethodBase when HttpRecoverableException is re-thrown

2003-09-24 Thread danch
Right, but my question is where should it be called? Or really, why is the HttpClient code calling it in some exception cases but not others? Michael Becke wrote: danch, Method.releaseConnection() should be called for all methods executed, including those that end in an exception