Re: [HttpClient] Proposed style change

frey Dever [mailto:[EMAIL PROTECTED]] Sent: Dienstag, 28. Januar 2003 02:04 To: Commons HttpClient Project Subject: Re: [HttpClient] Proposed style change I propose that we change the pattern for instance variables to ^_?[a-z][a-zA-Z0-9]*$ so that we will allow leading underscores

RE: [HttpClient] Proposed style change

g if it is going to be considered a violation new coding guidelines? Oleg -Original Message- From: Jeffrey Dever [mailto:[EMAIL PROTECTED]] Sent: Dienstag, 28. Januar 2003 02:04 To: Commons HttpClient Project Subject: Re: [HttpClient] Proposed style change > > >>I propose that

Re: [HttpClient] Proposed style change

Personally, > 1) Line length of 80 +1 > 2) Instance variable names > ^_?[a-z][a-zA-Z0-9] +0 Sung-Gu -- To unsubscribe, e-mail: For additional commands, e-mail:

Re: [HttpClient] Proposed style change

I propose that we change the pattern for instance variables to ^_?[a-z][a-zA-Z0-9]*$ so that we will allow leading underscores but will not insist on it. Uuuugh, please no! Besides being ugly, it's worth sticking to the Sun coding style (as is the default with checkstyle). That way, anyon

Re: [HttpClient] Proposed style change

My proposals for changes to the default sun style rules: checkstyle.maxlinelen=100 I agree with Mike and Simon that the line length should be longer. 100 is fairly standard in other projects. (comment blocks should still be 80 however it is not enforceable with checkstyle). Martin brought up

Re: [HttpClient] Proposed style change

> 1) Line length of 80 > In most of the places that we are exceeding the limit, we are just over > by a bit (between 80 and 90). I propose that we change the max length > to 100. This is still short enough that nobody should have to scroll to > see the source but long enough that we aren't artifi

Re: [HttpClient] Proposed style change

Ah ha! I knew that this was going to come up, and I'm somewhat prepared. Both of your suggestions do have precedent in other Jakarta projects. I am open to the idea of having a coding standard specific to HttpClient. It is our right to have our own coding standard, if we so choose. Perhaps a

RE: [HttpClient] Proposed style change

r [mailto:[EMAIL PROTECTED]] > Sent: Monday, January 27, 2003 8:39 AM > To: [EMAIL PROTECTED] > Subject: [HttpClient] Proposed style change > > > I am going through the code and changing it to conform to the > style as > per checkstyle. There are two places that I think

[HttpClient] Proposed style change

I am going through the code and changing it to conform to the style as per checkstyle. There are two places that I think we may want to be a little more lenient than the defaults and so I'm putting them here for discussion. 1) Line length of 80 The number 80 originally came from the days when