Re: [PATCH] relative URIs - take 2

2003-01-29 Thread Sung-Gu
- Original Message - From: "Eric Johnson" <[EMAIL PROTECTED]> > Problem #2, I think, deserves an exception, rather than a silent > adjustment. If you sent "http://a/../g"; to either Tomcat or Apache, I I think so, except for IIS. ;) > believe both will actually ignore the request a

Re: [PATCH] relative URIs - take 2

2003-01-29 Thread Sung-Gu
> - Original Message - > From: "Armando Anton" <[EMAIL PROTECTED]> > > yes i suppose the base URL can be returned :) Nodding... > i supposed that changing the URI constructor to can create an empty URI was necessary because when resolving relative uris, the base and the relative URI obje

RE: [PATCH] relative URIs - take 2

2003-01-28 Thread Armando Anton
../../../g then the new uri is http://a and this is an error (perhaps the lowest problem in httpclient :) ) Armando -Original Message- From: Eric Johnson [mailto:[EMAIL PROTECTED]] Sent: martes, 28 de enero de 2003 15:01 To: Commons HttpClient Project Subject: Re: [PATCH] relative URIs - tak

Re: [PATCH] relative URIs - take 2

2003-01-28 Thread Eric Johnson
I'll go with whatever others suggest with problem #1. Problem #2, I think, deserves an exception, rather than a silent adjustment. If you sent "http://a/../g"; to either Tomcat or Apache, I believe both will actually ignore the request and log it as an attempted hack, so we definitely shouldn'

Re: [PATCH] relative URIs - take 2

2003-01-28 Thread Michael Becke
1. when the relative uri is empty > an exception is thrown (i think it is a good idea to avoid empty uris) We should probably handle this one. Looks like parseUriReference() will need to be changed to handle an empty URI. 2. when there are more relative path ".." segments than hierarchical le

RE: [PATCH] relative URIs - take 2

2003-01-28 Thread Armando Anton
Armando -Original Message- From: Mike Moran [mailto:[EMAIL PROTECTED]] Sent: martes, 28 de enero de 2003 11:36 To: Commons HttpClient Project Subject: Re: [PATCH] relative URIs - take 2 Armando Anton wrote: >Hi! > >I was working in uri test cases too so i send some more case

Re: [PATCH] relative URIs - take 2

2003-01-28 Thread Mike Moran
Armando Anton wrote: Hi! I was working in uri test cases too so i send some more cases testing abnormal examples (you can find them in the RFC) :) Most of the abnormal examples works well except two of them: 1. when the relative uri is empty > an exception is thrown (i think it is a good idea t

RE: [PATCH] relative URIs - take 2

2003-01-28 Thread Armando Anton
Hi! I was working in uri test cases too so i send some more cases testing abnormal examples (you can find them in the RFC) :) Most of the abnormal examples works well except two of them: 1. when the relative uri is empty > an exception is thrown (i think it is a good idea to avoid empty uris)

Re: [PATCH] relative URIs - take 2

2003-01-27 Thread Jeffrey Dever
Committed. Thanks! Jandalf Michael Becke wrote: Here's the patch for part 1 (the URI constructor). Sung-Gu is correct about the second part. This functionality is already covered by getUIReference(). If anything, I think the comments could use a little more work to clear up the second i