Re: [compiz] [PATCH] Water fixes

2007-05-14 Thread Erkin Bahceci
On 5/14/07, David Reveman <[EMAIL PROTECTED]> wrote: > It can give slightly different results depending on if the software or > hardware water simulation is used but it should be close enough to not > really matter. Here the FBO version was actually fine even with 40, but software rendering needed

Re: [compiz] [PATCH] Water fixes

2007-05-14 Thread David Reveman
On Mon, 2007-05-14 at 15:07 -0500, Erkin Bahceci wrote: > On 5/14/07, David Reveman <[EMAIL PROTECTED]> wrote: > > Great, I've committed all patches except > > Stop-Water-drawing-right-after-waves-disappear as I'm not sure how you > > came to the conclusion that the count variable could be decremen

Re: [compiz] [PATCH] Water fixes

2007-05-14 Thread Erkin Bahceci
On 5/14/07, David Reveman <[EMAIL PROTECTED]> wrote: > Great, I've committed all patches except > Stop-Water-drawing-right-after-waves-disappear as I'm not sure how you > came to the conclusion that the count variable could be decremented at > that rate. Did you make any calculations to come up wit

Re: [compiz] [PATCH] Water fixes

2007-05-14 Thread David Reveman
On Sun, 2007-05-13 at 18:03 -0500, Erkin Bahceci wrote: > Hi, > > I had a look at some problems I saw in the Water plugin. Here are the > patches fixing those. > > The file names should be self-descriptive. Great, I've committed all patches except Stop-Water-drawing-right-after-waves-disappear a

[compiz] [PATCH] Water fixes

2007-05-13 Thread Erkin Bahceci
Hi, I had a look at some problems I saw in the Water plugin. Here are the patches fixing those. The file names should be self-descriptive. Regards, Erkin From 450379b6f5bb60f18222cca0cceacab189b1f5e6 Mon Sep 17 00:00:00 2001 From: Erkin Bahceci <[EMAIL PROTECTED]> Date: Sat, 12 May 2007 18:36:2