Re: [concordance-devel] Patch: Add "size" parameter to all non-firmware APIs

2008-03-27 Thread Phil Dibowitz
Stephen Warren wrote: > On Wed, March 26, 2008 11:55 pm, Phil Dibowitz wrote: >> Stephen Warren wrote: >>> That was easy - I'd just accidentally included the hunk that fixed the >>> C++ v.s. C comment at the end of libharmony.h, which you already >>> committed separately, which caused the conflict.

Re: [concordance-devel] Patch: Add "size" parameter to all non-firmware APIs

2008-03-27 Thread Stephen Warren
On Wed, March 26, 2008 11:55 pm, Phil Dibowitz wrote: > As I mentioned, I'd like the for(;;)s to be while(1)s. Here you go; attached. Index: concordance/concordance.c === RCS file: /cvsroot/concordance/concordance/concordance/concorda

Re: [concordance-devel] For comments: Draft for revision of Learn_IR API

2008-03-27 Thread Phil Dibowitz
Andreas Schulz wrote: > To allow insertion of IR codes from other sources (e.g. from the > Philips Pronto hex code archives), I have made up a draft of an > extended Learn_IR API for libconcorde.h. This all seems reasonable in theory, but let me go and actually weed through that code and clean/ref

Re: [concordance-devel] Patch: Add "size" parameter to all non-firmware APIs

2008-03-27 Thread Stephen Warren
On Wed, March 26, 2008 11:55 pm, Phil Dibowitz wrote: > Stephen Warren wrote: >> That was easy - I'd just accidentally included the hunk that fixed the >> C++ v.s. C comment at the end of libharmony.h, which you already >> committed separately, which caused the conflict. >> >> So, here's the update

[concordance-devel] For comments: Draft for revision of Learn_IR API

2008-03-27 Thread Andreas Schulz
To allow insertion of IR codes from other sources (e.g. from the Philips Pronto hex code archives), I have made up a draft of an extended Learn_IR API for libconcorde.h. It separates the learning and POSTing operations, to allow the API client to modify the IR code before POSTing, as well as acces