[concordance-devel] Patch: Add size parameters to *all* APIs

2008-03-28 Thread Stephen Warren
This patch adds a size parameter to any/all public APIs where it makes sense. I believe it's complete. See previous explanations for most changes. Additions are: Fixed a few comments in libharmony.h "delete[]" -> delete_blob. _write_fw_to_remote: Added size parameter, and use it. _read_fw_from_

Re: [concordance-devel] Patch: Add "size" parameter to all non-firmware APIs

2008-03-28 Thread Stephen Warren
Stephen Warren wrote: > I'll commit to adding a size parameter to the firmware APIs too, within > a day (probably less) of this being in CVS to diff against. Never mind; I have it done already. I'll follow up with the patch and comments/explanations in a few moment.s -

Re: [concordance-devel] Patch: Add "size" parameter to all non-firmware APIs

2008-03-28 Thread Stephen Warren
Phil Dibowitz wrote: > Stephen Warren wrote: >> So, I worked on the patch for issue 1 separately, because I started it >> first, and because it initially looked like we weren't going to address >> issue 2. My plan was to fix (1), then quickly work up the fix to (2) >> following that, to keep the am

Re: [concordance-devel] Patch: Add "size" parameter to all non-firmware APIs

2008-03-28 Thread Phil Dibowitz
Stephen Warren wrote: > So, I worked on the patch for issue 1 separately, because I started it > first, and because it initially looked like we weren't going to address > issue 2. My plan was to fix (1), then quickly work up the fix to (2) > following that, to keep the amount of merge issues lower

Re: [concordance-devel] Patch: Add "size" parameter to all non-firmware APIs

2008-03-28 Thread Stephen Warren
On Thu, March 27, 2008 11:03 pm, Phil Dibowitz wrote: > Stephen Warren wrote: >> On Wed, March 26, 2008 11:55 pm, Phil Dibowitz wrote: >>> Stephen Warren wrote: That was easy - I'd just accidentally included the hunk that fixed the C++ v.s. C comment at the end of libharmony.h, which you