Re: [PATCH 4/4] Add ssids and frequencies to wpa_supplicant scan for fast scan.

Hi Mohamed, > For fast scan append ssids and frequencies to scan request so > wpa_supplicant will only issue active scans for these passed > in frequencies. > --- > gsupplicant/gsupplicant.h | 16 > gsupplicant/supplicant.c | 144 +-- > plugins/wifi.c

Re: [PATCH 2/4] Add support to multi scan type.

Hi Mohamed, > include/device.h |9 - > plugins/iwmx.c |3 ++- > plugins/wifi.c |5 +++-- > src/device.c |6 +++--- > 4 files changed, 16 insertions(+), 7 deletions(-) > > diff --git a/include/device.h b/include/device.h > index a82d08d..1b54288 100644 > --- a/incl

Re: [PATCH 0/4] Fast connect.

Hi Mohamed, > These patches will add fast scan support. This patches changes the way > we call wpa_supplicant scan. For fast scan request connman will append > ssids and frequencies for the last four AP's we connected to so > supplicat will send active ssid scans only for these frequencies. so e

Re: [PATCH v1 01/13] main: Do not call syslog in signal handler

Hi Lucas, > > It's unsafe to call syslog in the terminat signal handler > > because syslog takes an lock. So when the signal handler > > kicks in and we were already in syslog, we have a nice > > deadlock. > > --- > > src/main.c |2 -- > > 1 files changed, 0 insertions(+), 2 deletions(-) > >

Re: [PATCH_v2 1/2] doc: Update private network method prototypes

Hi Denis, > >> doc/manager-api.txt | 11 +-- > >> 1 files changed, 5 insertions(+), 6 deletions(-) > >> > >> diff --git a/doc/manager-api.txt b/doc/manager-api.txt > >> index cf26978..57b13c9 100644 > >> --- a/doc/manager-api.txt > >> +++ b/doc/manager-api.txt > >> @@ -195,21 +195,20 @@

[PATCH 4/4] Add ssids and frequencies to wpa_supplicant scan for fast scan.

For fast scan append ssids and frequencies to scan request so wpa_supplicant will only issue active scans for these passed in frequencies. --- gsupplicant/gsupplicant.h | 16 gsupplicant/supplicant.c | 144 +-- plugins/wifi.c| 216 +

[PATCH 3/4] Add support to append char ** entries to dbus dict.

--- gsupplicant/dbus.c | 28 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/gsupplicant/dbus.c b/gsupplicant/dbus.c index e014265..8eb4c11 100644 --- a/gsupplicant/dbus.c +++ b/gsupplicant/dbus.c @@ -520,3 +520,31 @@ void supplicant_dbus_property_ap

[PATCH 1/4] Add frequency support to service.

Get the frequncy of gsupplicant network on connman network creation, and always save the frequency of the wifi service. --- gsupplicant/gsupplicant.h |1 + gsupplicant/supplicant.c | 10 ++ plugins/wifi.c|3 +++ src/service.c |5 + 4 files changed

[PATCH 2/4] Add support to multi scan type.

Allow multi scan type for fast connect. --- include/device.h |9 - plugins/iwmx.c |3 ++- plugins/wifi.c |5 +++-- src/device.c |6 +++--- 4 files changed, 16 insertions(+), 7 deletions(-) diff --git a/include/device.h b/include/device.h index a82d08d..1b54288 1006

[PATCH 0/4] Fast connect.

These patches will add fast scan support. This patches changes the way we call wpa_supplicant scan. For fast scan request connman will append ssids and frequencies for the last four AP's we connected to so supplicat will send active ssid scans only for these frequencies. --- --- ___

Problem using wwan0 modem

Hello list, when using distros integrating network-manager, I can connect to the Internet using my Ericsson F3607gw (HP clone) GSM/GPRS/UMTS WWAN modem and would like to be able to do so with Linux distros (MeeGo) which integrate connman as well. GOAL I want to be able to select from betwee

Re: [PATCH v1 01/13] main: Do not call syslog in signal handler

Hi Daniel, On Wed, Jun 22, 2011 at 1:03 PM, Daniel Wagner wrote: > It's unsafe to call syslog in the terminat signal handler > because syslog takes an lock. So when the signal handler > kicks in and we were already in syslog, we have a nice > deadlock. > --- >  src/main.c |    2 -- >  1 files cha

Re: [PATCH_v2 1/2] doc: Update private network method prototypes

Hi Marcel, On 06/27/2011 12:28 PM, Marcel Holtmann wrote: > Hi Guillaume, > >> doc/manager-api.txt | 11 +-- >> 1 files changed, 5 insertions(+), 6 deletions(-) >> >> diff --git a/doc/manager-api.txt b/doc/manager-api.txt >> index cf26978..57b13c9 100644 >> --- a/doc/manager-api.txt >>

Re: [PATCH_v2 1/2] doc: Update private network method prototypes

Hi Guillaume, > doc/manager-api.txt | 11 +-- > 1 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/doc/manager-api.txt b/doc/manager-api.txt > index cf26978..57b13c9 100644 > --- a/doc/manager-api.txt > +++ b/doc/manager-api.txt > @@ -195,21 +195,20 @@ Methods di

[PATCH_v2 2/2] private_network: Update APIs to be able to use multiple private networks

--- src/connman.h |2 +- src/manager.c | 11 + src/tethering.c | 65 -- 3 files changed, 45 insertions(+), 33 deletions(-) diff --git a/src/connman.h b/src/connman.h index 0c6d6b1..e4c35da 100644 --- a/src/connman.h +++ b/src

[PATCH_v2 0/2] Private network APIs update

Hi, This new version only removes the connman_inet_ifdown() call. It is already done while closing fd in removing private network. Guillaume Zajac (2): doc: Update private network method prototypes private_network: Update APIs to be able to use multiple private networks doc/manager-api.

[PATCH_v2 1/2] doc: Update private network method prototypes

--- doc/manager-api.txt | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/doc/manager-api.txt b/doc/manager-api.txt index cf26978..57b13c9 100644 --- a/doc/manager-api.txt +++ b/doc/manager-api.txt @@ -195,21 +195,20 @@ Methods dict GetProperties()

Re: [PATCH 2/2] private_network: Update APIs to be able to use multiple private networks

Hi Samuel, On 24/06/2011 18:08, Samuel Ortiz wrote: Hi Guillaume, The patch looks pretty good. I have one question for you though: On Wed, Jun 22, 2011 at 02:10:17PM +0200, Guillaume Zajac wrote: static void remove_private_network(gpointer user_data) { struct connman_private_netwo

Re: [PATCH] oFono: Fix crash when using oFono plugin

Hi Daniel, On 27/06/2011 08:30, Daniel Wagner wrote: Hi Guillaume, I noticed when using ConnMan with oFono plugin enabled that I had a crash when I close oFono or I disable phonesim modem. It seems that we are unrefing and unregistering the network althugh it has already been done by device ob

Re: [RFC v0 0/4] Service State Machine NG

Hi Daniel, I personally like your RFC, and I wanted to add a small input (as well as setting the subject up again ^^) around __connman_service_indicate_state() code. (which will become __connman_service_ipconfig_indicate_state() with your rfc) In that function, we should take care of ipconfig's s

Re: [PATCH ipv6 gw v2 00/13] ipv6 gw: Fix route and gateway handling for IPv6

Hi Jukka, On Wed, Jun 22, 2011 at 01:37:37PM +0300, Jukka Rissanen wrote: > Hi again, > > v2 fixes these things: > > 07 - find_gateway() is changed to return struct gateway_config directly > 10 - Added description why __connman_ipconfig_address_unset() is called Ok, thanks. I tested it with an o

Re: [PATCH v1 06/13] ethernet: Take ownership of network objects

Hi Samuel, On Mon, Jun 27, 2011 at 11:08:01AM +0200, Samuel Ortiz wrote: > Hi Daniel, > > On Wed, Jun 22, 2011 at 06:03:12PM +0200, Daniel Wagner wrote: > > From: Daniel Wagner > > > > Store created networks into a hash table with the device pointer as > > key. When the device is being removed,

Re: [PATCH v1 05/13] device: Remove needless call to __connman_network_set_device()

Hi Samuel, On Mon, Jun 27, 2011 at 11:07:44AM +0200, Samuel Ortiz wrote: > Hi Daniel, > > On Wed, Jun 22, 2011 at 06:03:11PM +0200, Daniel Wagner wrote: > > From: Daniel Wagner > I would even argue about the usefulness of device->network itself. Can you elaborate a bit on this one? I see that n

Re: [PATCH v1 04/13] network: Remove connman_network_register/unregiser()

Hi Samuel, On Mon, Jun 27, 2011 at 11:07:29AM +0200, Samuel Ortiz wrote: > Hi Daniel, > > On Wed, Jun 22, 2011 at 06:03:10PM +0200, Daniel Wagner wrote: > > From: Daniel Wagner > > > > Since the service object doesn't take a reference the > > intermediate step of having a connman_network_regist

Re: [PATCH v1 00/13] Refcounting simplified

Hi Samuel, Thanks for taking the time to review these patches. > > The > > connman_network_register/unregister is gone again. This is not needed > > anymore because service is not allowed to take a reference on the > > network object. > Not allowed ? So why is service no longer taking a referenc

Re: [PATCH 5/5] device: Add command queue.

Hi Samuel, just a few things i wanted to clarify. My queries are inline. On Fri, Jun 24, 2011 at 2:59 AM, Samuel Ortiz wrote: > Hi Alok, > > On Mon, Jun 20, 2011 at 02:06:15PM +0300, Alok Barsode wrote: > > From: Alok Barsode > > > > Implement a command queue per device. It can queue power ena

Re: [PATCH v1 06/13] ethernet: Take ownership of network objects

Hi Daniel, On Wed, Jun 22, 2011 at 06:03:12PM +0200, Daniel Wagner wrote: > From: Daniel Wagner > > Store created networks into a hash table with the device pointer as > key. When the device is being removed, call > connman_device_remove_network and unref network. The changelog doesn't match the

Re: [PATCH v1 05/13] device: Remove needless call to __connman_network_set_device()

Hi Daniel, On Wed, Jun 22, 2011 at 06:03:11PM +0200, Daniel Wagner wrote: > From: Daniel Wagner I would even argue about the usefulness of device->network itself. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ ___ connma

Re: [PATCH v1 04/13] network: Remove connman_network_register/unregiser()

Hi Daniel, On Wed, Jun 22, 2011 at 06:03:10PM +0200, Daniel Wagner wrote: > From: Daniel Wagner > > Since the service object doesn't take a reference the > intermediate step of having a connman_network_register/unregister > is not needed. This function are only there to have an additional > step

Re: [PATCH v1 00/13] Refcounting simplified

Hi Daniel, On Wed, Jun 22, 2011 at 06:03:06PM +0200, Daniel Wagner wrote: > From: Daniel Wagner > > Hi, > > with this path series the refcounting for network objects gets > simplified. The plugins create the network, therefore it destroys it > in the end (with connman_network_unref). Sounds go