Re: [PATCH] service: Check NULL pointer when setting ipconfig.

2011-08-26 Thread Samuel Ortiz
Hi Jukka, On Fri, Aug 26, 2011 at 03:10:51PM +0300, Jukka Rissanen wrote: > Fixes BMC#22766 Thanks, patch applied now. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ ___ connman mailing list connman@connman.net http://lis

Re: [PATCH] network: Read only the ipconfig data if we have no address.

2011-08-26 Thread Samuel Ortiz
Hi Jukka, On Fri, Aug 26, 2011 at 02:43:10PM +0300, Jukka Rissanen wrote: > We must not read ipconfig data from file if there is already a valid > address that was set by service set_property(). > > Fixes BMC#22767 Thanks a lot, patch applied. Cheers, Samuel. -- Intel Open Source Technology Ce

[PATCH] (Re-)fix of bug #22542

2011-08-26 Thread patrik . flykt
From: Patrik Flykt Hi, Noted that the beavior is incorrect if Agent API RequestInput is cancelled. The same code path will be called in the reopened bug BCM#22542, if there is no agent registered. I added basically the same code as when not retrying in ReportError, I'm almost sure

[PATCH] service: Behave properly when RequestInput is cancelled

2011-08-26 Thread patrik . flykt
From: Patrik Flykt Do the same actions on cancelling RequestInput as when not retrying a service on ReportError. Re-fixes BMC#22542. --- src/service.c | 82 ++--- 1 files changed, 43 insertions(+), 39 deletions(-) diff --git a/src/service.c

[PATCH] service: Check NULL pointer when setting ipconfig.

2011-08-26 Thread Jukka Rissanen
Fixes BMC#22766 --- Hi, this fixes the bug https://bugs.meego.com/show_bug.cgi?id=22766 where we must check if the ipconfig is NULL before trying to access it. The problem happened as 3G connection did not have an IPv6 address. Jukka src/service.c |3 +++ 1 files changed, 3 insertions(+),

[PATCH] network: Read only the ipconfig data if we have no address.

2011-08-26 Thread Jukka Rissanen
We must not read ipconfig data from file if there is already a valid address that was set by service set_property(). Fixes BMC#22767 --- Hi, the following patches fix the bug https://bugs.meego.com/show_bug.cgi?id=22767 where user is unable to set manual ipaddress. The bug is about IPv6 but the s

[PATCH] service: Do not allow service to be moved before a VPN service.

2011-08-26 Thread Jukka Rissanen
This is needed as the default routes are not set properly if we allow a service to be moved before a VPN service. --- Hi, it would be nice to allow a service to be moved before VPN service but unfortunately it would require bigger changes in connection.c so atm just disallow this. Jukka src/se