Re: [PATCH] service: signal error property changes

2012-06-13 Thread Patrik Flykt
Hi, On Wed, 2012-06-06 at 23:15 -0700, Grant Erickson wrote: In order to allow clients to update the property in a manner similar to other service properties, signal changes in the service Error property key/value pair. The value none is used when no error is asserted because D-Bus

Re: [PATCH 1/6] dnsproxy: Only one copy of the relevant buffers will be made to a TCP request

2012-06-13 Thread Jukka Rissanen
Hi Paolo, On 10 June 2012 01:34, Paulo Pizarro paulo.piza...@gmail.com wrote: This copy will be made after scanning the list of nameservers and  only if at least one TCP server is created. Do not start the above line with space. Otherwise, it will be sent an error response to the request.

Re: [PATCH 4/6] dnsproxy: Avoiding duplication of domains in the list of domains of the TCP server

2012-06-13 Thread Jukka Rissanen
Hi Paolo, On 10 June 2012 01:34, Paulo Pizarro paulo.piza...@gmail.com wrote: The domain list is created in the tcp_server_event function  at connection time (G_IO_OUT event), so it is not necessary  to create it here too. There are extra spaces at the beginning of the line above. ---  

Re: [PATCH 6/6] dnsproxy: fix flushing pending requests

2012-06-13 Thread Jukka Rissanen
Hi Paolo, On 10 June 2012 01:34, Paulo Pizarro paulo.piza...@gmail.com wrote: ---  src/dnsproxy.c |   31 ---  1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index 1eaaa06..c667402 100644 --- a/src/dnsproxy.c +++

RE: [PATCH] service: signal error property changes

2012-06-13 Thread Grant Erickson
Patrik Flykt patrik.flykt at linux.intel.com On Wed Jun 13 00:36:52 PDT 2012, Patrik Flykt wrote: On Wed, 2012-06-06 at 23:15 -0700, Grant Erickson wrote: In order to allow clients to update the property in a manner similar to other service properties, signal changes in the service Error