On Fri, Sep 28, 2012 at 3:35 PM, Tomasz Bursztyka
wrote:
> Hi,
>
> While playing around with enabling/disabling technology I found out that if a
> technology is hardblocked through the physical switch,
> first the technology is still listed in GetTechnologies, but of course
> enabling it
> from
From: Patrik Flykt
Check test-connman offlinemode arguments and the number of arguments
in general.
Fixes BMC#25723
---
test/test-connman | 27 +++
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/test/test-connman b/test/test-connman
index 67b0c85..d047c
From: Daniel Wagner
During shutdown, e.g. ctrl-c was issued by the user, pugins are
removed first. The policy plugin will destroy the associated policy
config, therefore there is no need to do it later.
Accessing the session->policy NULL pointer later is not a good idea
anyway.
---
src/session.
From: Daniel Wagner
Hi,
This series introduces a PoC for a new policy plugin. I have called it IVI
but that is nothing specific to IVI. It just a very good short name. If you
have a better name, I am glad to accept it.
The first few patches are bug fixes ore small cleanups in general. So up
to
From: Daniel Wagner
Instead returning directly a config when create() is called
in policy plugin, use a callback function for handing over a valid
configuration from the plugin to the session core. This prepars
support for asynchronize create call.
---
include/session.h| 9 +++--
pl
From: Daniel Wagner
---
src/session.c | 50 ++
1 file changed, 34 insertions(+), 16 deletions(-)
diff --git a/src/session.c b/src/session.c
index 8957c71..f5d3a6d 100644
--- a/src/session.c
+++ b/src/session.c
@@ -1543,6 +1543,14 @@ static const G
From: Daniel Wagner
We want to use this code snippet for the error case
in __connman_session_create() too.
---
src/session.c | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/src/session.c b/src/session.c
index f5d3a6d..314a51d 100644
--- a/src/session.
From: Daniel Wagner
The creation of a new session might be deferred. This happens
in the case where a policy plugin has to do some work async. For example
the plugin might have to ask a D-Bus config daemon.
---
src/manager.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --g
From: Daniel Wagner
Move the configuration part of __connman_session_create() into
session_create_cb(). With this change the policy plugin is able
to do async work to retrieve a configuration.
---
src/session.c | 187 --
1 file changed, 102
From: Daniel Wagner
---
src/session.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/session.c b/src/session.c
index 601a373..29d98ea 100644
--- a/src/session.c
+++ b/src/session.c
@@ -1572,6 +1572,11 @@ static void session_create_cb(struct connman_session
*session,
DBG(
From: Daniel Wagner
Give the policy plugin a way to inform the session core that
some of the config values have changed.
This could be done in a more clever way, e.g. figure out only
to update the necessary info entries.
It is not expected that there are many updates so let's keep it
simple for
From: Daniel Wagner
---
src/connman.h | 6 +++---
src/storage.c | 8
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/connman.h b/src/connman.h
index c70f6ae..d035336 100644
--- a/src/connman.h
+++ b/src/connman.h
@@ -209,10 +209,10 @@ int __connman_resolvfile_remove(c
From: Daniel Wagner
---
src/config.c | 97
1 file changed, 52 insertions(+), 45 deletions(-)
diff --git a/src/config.c b/src/config.c
index 4686914..16fed8d 100644
--- a/src/config.c
+++ b/src/config.c
@@ -562,6 +562,57 @@ static int
From: Daniel Wagner
---
include/storage.h | 8 +++
src/config.c | 122 +-
src/connman.h | 5 ++
src/main.c| 2 +
src/storage.c | 155 ++
5 files changed, 172 insertions(+), 120
From: Daniel Wagner
---
Makefile.am | 2 +-
gdbus/gdbus.h | 9 +++
gdbus/selinux.c | 167
3 files changed, 177 insertions(+), 1 deletion(-)
create mode 100644 gdbus/selinux.c
diff --git a/Makefile.am b/Makefile.am
index 8693752
From: Daniel Wagner
---
include/session.h | 2 ++
src/session.c | 5 +
2 files changed, 7 insertions(+)
diff --git a/include/session.h b/include/session.h
index f178bb4..7bd8ce7 100644
--- a/include/session.h
+++ b/include/session.h
@@ -86,6 +86,8 @@ void connman_session_config_update(s
From: Daniel Wagner
---
Makefile.plugins | 12 +++
configure.ac | 6
plugins/session_policy_ivi.c | 75
3 files changed, 93 insertions(+)
create mode 100644 plugins/session_policy_ivi.c
diff --git a/Makefile.plu
From: Daniel Wagner
---
plugins/session_policy_ivi.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/plugins/session_policy_ivi.c b/plugins/session_policy_ivi.c
index c11067e..2c30b05 100644
--- a/plugins/session_policy_ivi.c
+++ b/plugins/session_policy_iv
From: Daniel Wagner
---
plugins/session_policy_ivi.c | 50 +++-
1 file changed, 49 insertions(+), 1 deletion(-)
diff --git a/plugins/session_policy_ivi.c b/plugins/session_policy_ivi.c
index 2c30b05..8a7503a 100644
--- a/plugins/session_policy_ivi.c
+++ b
From: Daniel Wagner
Instead using glib's cleanup hooks for the hash table, we implement
it ourself. The reason for doing this is that we will use the
policy_data structure via a second hash table. So there is no
direct ownership between session_hash and policy_data after we add the
second hash ta
From: Daniel Wagner
---
plugins/session_policy_ivi.c | 31 ++-
1 file changed, 22 insertions(+), 9 deletions(-)
diff --git a/plugins/session_policy_ivi.c b/plugins/session_policy_ivi.c
index 1218523..063e763 100644
--- a/plugins/session_policy_ivi.c
+++ b/plugins/ses
From: Daniel Wagner
---
plugins/session_policy_ivi.c | 116 +++
1 file changed, 116 insertions(+)
diff --git a/plugins/session_policy_ivi.c b/plugins/session_policy_ivi.c
index 063e763..5e6b04b 100644
--- a/plugins/session_policy_ivi.c
+++ b/plugins/sessi
From: Daniel Wagner
---
plugins/session_policy_ivi.c | 54
1 file changed, 54 insertions(+)
diff --git a/plugins/session_policy_ivi.c b/plugins/session_policy_ivi.c
index 5e6b04b..9d3f457 100644
--- a/plugins/session_policy_ivi.c
+++ b/plugins/sessio
From: Daniel Wagner
---
plugins/session_policy_ivi.c | 36
1 file changed, 28 insertions(+), 8 deletions(-)
diff --git a/plugins/session_policy_ivi.c b/plugins/session_policy_ivi.c
index 9d3f457..25be047 100644
--- a/plugins/session_policy_ivi.c
+++ b/plugin
From: Daniel Wagner
---
plugins/session_policy_ivi.c | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/plugins/session_policy_ivi.c b/plugins/session_policy_ivi.c
index 25be047..c4e0e42 100644
--- a/plugins/session_policy_ivi.c
+++ b/plugins/session_policy_i
From: Daniel Wagner
---
include/session.h | 4 +++
src/session.c | 76 +--
2 files changed, 56 insertions(+), 24 deletions(-)
diff --git a/include/session.h b/include/session.h
index 7bd8ce7..8299205 100644
--- a/include/session.h
+++ b/i
From: Daniel Wagner
---
plugins/session_policy_ivi.c | 94 +++-
1 file changed, 92 insertions(+), 2 deletions(-)
diff --git a/plugins/session_policy_ivi.c b/plugins/session_policy_ivi.c
index c4e0e42..d52b345 100644
--- a/plugins/session_policy_ivi.c
+++
Hi Jussi,
Hi,
While playing around with enabling/disabling technology I found out that if a
technology is hardblocked through the physical switch,
first the technology is still listed in GetTechnologies, but of course enabling
it
from dbus API will lead to nothing. User HAS to play with the ph
The inet_rtnl_cb_data struct allocated in __connman_inet_rtnl_talk()
was not deallocated if we expected data from kernel.
---
src/inet.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/src/inet.c b/src/inet.c
index db6af38..ac45eb4 100644
--- a/src/inet.c
+++ b/src/inet.
---
src/error.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/error.c b/src/error.c
index c414469..f42b60e 100644
--- a/src/error.c
+++ b/src/error.c
@@ -62,6 +62,7 @@ DBusMessage *__connman_error_failed(DBusMessage *msg, int
errnum)
case ETIMEDOUT:
return __conn
On Fri, 2012-09-28 at 15:41 +0300, Tomasz Bursztyka wrote:
> ---
> src/wispr.c | 14 --
> 1 file changed, 8 insertions(+), 6 deletions(-)
Patch has been applied, thanks!
Patrik
___
connman mailing list
connman@connman.net
http://l
On Thu, 2012-09-20 at 16:33 +0300, Tomasz Bursztyka wrote:
> ---
> Hi,
>
> Currently when setting tethering related properties, it does not send a
> PropertyChanged signal.
> From a client point of view it's not nice: either you believe the SetProperty
> return success or
> after it you run a G
On Mon, 2012-10-01 at 11:22 +0300, patrik.fl...@linux.intel.com wrote:
> From: Patrik Flykt
>
> Check test-connman offlinemode arguments and the number of arguments
> in general.
>
> Fixes BMC#25723
Applied,
Patrik
___
connman mailing list
On tis, 2012-09-25 at 13:28 +0300, patrik.fl...@linux.intel.com wrote:
> From: Patrik Flykt
>
> Calculate transmit time used in NTP as the reception time minus
> the delta of the monotonic receive and transmit times. When
> calculated this way, it does not matter if the time happens to
> be set t
On mån, 2012-10-01 at 13:15 +0300, Jukka Rissanen wrote:
> The inet_rtnl_cb_data struct allocated in __connman_inet_rtnl_talk()
> was not deallocated if we expected data from kernel.
Applied, thanks!
Patrik
___
connman mailing list
connman@conn
On Mon, 2012-10-01 at 13:15 +0300, Jukka Rissanen wrote:
> ---
> src/error.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
Patrik
___
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman
Fixes BMC#25726
---
src/dnsproxy.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/dnsproxy.c b/src/dnsproxy.c
index 719c170..fd367a5 100644
--- a/src/dnsproxy.c
+++ b/src/dnsproxy.c
@@ -1505,6 +1505,12 @@ static int ns_resolv(struct server_data *server, struct
request_data *req,
hi,
On Mon, Oct 1, 2012 at 11:03 AM, Tomasz Bursztyka <
tomasz.burszt...@linux.intel.com> wrote:
> Hi Jussi,
>
> Hi,
>>>
>>> While playing around with enabling/disabling technology I found out that
>>> if a technology is hardblocked through the physical switch,
>>> first the technology is still
I refactored the previous patchset so it proposes first the hash table fix, and
the
proper hard rfkill handling (without DBus exposure change), as well as the
rfkill cascading
issue.
Then the 2 last patches propose a fix for API 1.0: if a technology is hw
rfkilled, it won't
be exposed through
---
src/technology.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/technology.c b/src/technology.c
index d78e7b3..001208d 100644
--- a/src/technology.c
+++ b/src/technology.c
@@ -1288,7 +1288,7 @@ int __connman_technology_add_rfkill(unsigned int index,
---
src/technology.c | 39 +++
1 file changed, 27 insertions(+), 12 deletions(-)
diff --git a/src/technology.c b/src/technology.c
index 001208d..f187a08 100644
--- a/src/technology.c
+++ b/src/technology.c
@@ -72,6 +72,8 @@ struct connman_technology {
g
On some crappy hardware, there exist 2 rfkill entities for the same type, with
cascading issue: if one is soft blocked, the other one is hardblocked. But if
the hardblock switch is set, all are hardblocked. So this patch figures out that
a technology is hardblock if only all related rkill event get
If hard rfkilled, a technology will not be exposed through DBus via
GetTechnologies. If hard rfkill status change, TechnologyAdded/TechnologyRemoved
signals will be thrown accordingly.
---
src/technology.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/technolo
---
src/technology.c | 45 ++---
1 file changed, 34 insertions(+), 11 deletions(-)
diff --git a/src/technology.c b/src/technology.c
index ba47ee3..64cb5ce 100644
--- a/src/technology.c
+++ b/src/technology.c
@@ -74,6 +74,7 @@ struct connman_technology {
Hi Alok,
But you might not even have drivers for it, so it won't be possible to get
> it enabled (my patches does not fix that issue anyway, there is an issue to
> solve here)
> And #3 because API 1.0 does not propose anything about that.
>
Cant we just return an different error for hard bloc
hi Tomasz,
On Mon, Oct 1, 2012 at 12:20 PM, Tomasz Bursztyka <
tomasz.burszt...@linux.intel.com> wrote:
> Hi Alok,
>
> But you might not even have drivers for it, so it won't be possible to get
>>> > it enabled (my patches does not fix that issue anyway, there is an
>>> issue to
>>> > solve he
Hi,
On Mon, 2012-10-01 at 14:14 +0300, Tomasz Bursztyka wrote:
> static GSList *driver_list = NULL;
> @@ -962,6 +964,10 @@ static struct connman_technology
> *technology_get(enum connman_service_type type)
>
> technology->refcount = 1;
>
> + technology->hardblocked = TR
On Mon, 2012-10-01 at 14:14 +0300, Tomasz Bursztyka wrote:
> I refactored the previous patchset so it proposes first the hash table fix,
> and the
> proper hard rfkill handling (without DBus exposure change), as well as the
> rfkill cascading
> issue.
Patches 1, 2 and 3 don't cause any controver
Hi Patrik,
Patches 1, 2 and 3 don't cause any controversy except for the minor
nitpick. Maybe we should still add a patch that toggles WiFi off and
removes all associated services. As it is now, it looks somewhat funny
that all services still exist after toggling the hardblock switch.
Yes that'
On Mon, Oct 1, 2012 at 1:03 PM, Tomasz Bursztyka
wrote:
>> I've not followed connman that closely recently, so it's entirely
>> possible I'm missing something. Anyway, previous UX requirements in
>> this area were:
>>1. list the technologies that we have the hardware for
>>2. allow enablin
Hi Jussi,
Consistency. Removing any evidence that the device is wifi-capable is
just wrong. Not exposing the hw-block state to UI is wrong as well and
now that you mention it, I think I've complained about it before:)
True, you opened a bug long ago on BMC.
Anyway wifi card has no driver, wifi
Hi Tomasz,
> > Consistency. Removing any evidence that the device is wifi-capable is
> > just wrong. Not exposing the hw-block state to UI is wrong as well and
> > now that you mention it, I think I've complained about it before:)
> True, you opened a bug long ago on BMC.
>
> Anyway wifi card has
52 matches
Mail list logo