Hi,
On Thu, 2012-10-18 at 15:34 +0100, alok barsode wrote:
AccessPointName =
According to the discussion on #connman yesterday, the problem was
solved by setting AccessPointName, right?
Cheers,
Patrik
___
connman mailing list
Hi all,
This is test report for connman-1.8.27.gd10e680-1.1.i586.
In this testing,we ran 113 cases. 110 cases passed and 3 cases failed
because of known bugs. The pass rate is 97%. We found 1 new bug,
reopen 0 bug and verify 0 bugs. In this commit we found the bug that
Connmand crashes after
---
src/network.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/network.c b/src/network.c
index 69cb70a..5c66bbd 100644
--- a/src/network.c
+++ b/src/network.c
@@ -719,7 +719,7 @@ void connman_network_set_ipv6_method(struct connman_network
*network,
void
On Thu, 2012-10-18 at 14:35 +0300, Jukka Rissanen wrote:
Hi,
this patchset fixes the latest crash bug 25757.
The patches #1, #2 and #5 add more useful debugging
information.
Patch #3 fixes the crash that was reported. The crash
happened because we received data from DNS server after
we
On Fri, 2012-10-19 at 10:44 +0300, Jukka Rissanen wrote:
---
src/network.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
...and applied.
Patrik
___
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman
Hi Tomasz,
-Original Message-
From: connman-boun...@connman.net
[mailto:connman-boun...@connman.net] On Behalf Of Tomasz Bursztyka
Sent: Thursday, October 18, 2012 9:04 PM
To: connman@connman.net
Subject: Re: [PATCH] wifi: Don't set scanning to FALSE during connecting
Hi Arron,
Do you
Hi,
On Wed, 2012-10-17 at 14:42 +0200, Daniel Wagner wrote:
From: Daniel Wagner daniel.wag...@bmw-carit.de
Instead returning directly a config when create() is called
in policy plugin, use a callback function for handing over a valid
configuration from the plugin to the session
Hi again,
On Wed, 2012-10-17 at 14:42 +0200, Daniel Wagner wrote:
From: Daniel Wagner daniel.wag...@bmw-carit.de
Instead returning directly a config when create() is called
in policy plugin, use a callback function for handing over a valid
configuration from the plugin to the
Hi Arron,
Ok I see, but actually your patch is wrong because if autoscan fallback
has started, it put scanning to true, and at those place you really need
to put scanning to false.
Instead, you might try a patch on src/device.c in function
mark_network_unavailable():
change line: if
Hi,
On Wed, 2012-10-17 at 14:42 +0200, Daniel Wagner wrote:
In order to be able to passing the user configuration provided
through the D-Bus Manager.SessionCreate() call to the callback
we need to store the configuration into a local data data structure.
This can then be passed into
Hi,
if the system has multiple wifi cards and user has connected to
access point successfully using one of the cards, then we know
the credentials to that AP. So we can reuse this information
when connecting to the same AP using different card (=service).
So in patch #1 we check during
We should not set the error before state change because
the state change might clear the error in service_indicate_state().
A safe option is set the state after we have changed the state.
---
src/service.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/service.c
This is useful when checking whether agent is giving correct error.
---
src/service.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/service.c b/src/service.c
index c479143..ebc8371 100644
--- a/src/service.c
+++ b/src/service.c
@@ -3285,6 +3285,8 @@ static void set_error(struct
Hi,
On Wed, 2012-10-17 at 14:42 +0200, Daniel Wagner wrote:
From: Daniel Wagner daniel.wag...@bmw-carit.de
Give the policy plugin a way to inform the session core that
some of the config values have changed.
This could be done in a more clever way, e.g. figure out only
to update
Hi,
On Wed, 2012-10-17 at 14:42 +0200, Daniel Wagner wrote:
From: Daniel Wagner daniel.wag...@bmw-carit.de
Hi,
The first patch is something I found during writing this code. So
it is kind of unrelated.
The patches up to #7 are the base work for the IVI policy plugin. I think
Hi Daniel,
On 17.10.2012 15:42, Daniel Wagner wrote:
From: Daniel Wagner daniel.wag...@bmw-carit.de
Instead returning directly a config when create() is called
in policy plugin, use a callback function for handing over a valid
configuration from the plugin to the session core. This prepars
Hi Patrik,
On 19.10.2012 12:52, Patrik Flykt wrote:
Hi,
On Wed, 2012-10-17 at 14:42 +0200, Daniel Wagner wrote:
From: Daniel Wagner daniel.wag...@bmw-carit.de
Hi,
The first patch is something I found during writing this code. So
it is kind of unrelated.
The patches up to #7 are
On 19.10.2012 12:11, Patrik Flykt wrote:
Hi again,
On Wed, 2012-10-17 at 14:42 +0200, Daniel Wagner wrote:
From: Daniel Wagner daniel.wag...@bmw-carit.de
Instead returning directly a config when create() is called
in policy plugin, use a callback function for handing over a valid
On 19.10.2012 12:47, Patrik Flykt wrote:
Hi,
On Wed, 2012-10-17 at 14:42 +0200, Daniel Wagner wrote:
From: Daniel Wagner daniel.wag...@bmw-carit.de
Give the policy plugin a way to inform the session core that
some of the config values have changed.
This could be done in a more
Hi Jukka,
On 19.10.2012 12:55, Jukka Rissanen wrote:
After applying the patch I noticed that the assign_policy_plugin() could
be refactored a bit.
for (list = policy_list; list != NULL; list = list-next) {
policy = list-data;
session-policy = policy;
break;
On Fri, Oct 19, 2012 at 01:11:36PM +0300, Patrik Flykt wrote:
- return 0;
+ return (*session-policy-create)(session, callback, user_data);
Here also a check for the create function is needed before calling it.
I think I am going to add this test to the registration function. What do
Hi Daniel,
this looks nice but there is a small issue when we get the connman-vpn
integrated into connman. The connman-vpnd is linking storage.c as it
needs some functions from there but it does not need config.c. If we
could keep the notify stuff in config, then it would mean smaller
Hi Daniel,
On 17.10.2012 15:42, Daniel Wagner wrote:
From: Daniel Wagner daniel.wag...@bmw-carit.de
---
include/session.h | 3 ++-
src/session.c | 5 +
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/include/session.h b/include/session.h
index 086c0fc..afad9fb 100644
Hi Daniel,
the dbus stuff is quite mandatory in this plugin anyway so perhaps this
could be merged with the previous patch.
On 17.10.2012 15:42, Daniel Wagner wrote:
From: Daniel Wagner daniel.wag...@bmw-carit.de
---
plugins/session_policy_ivi.c | 18 +-
1 file changed,
Hi Jukka,
On 19.10.2012 13:50, Jukka Rissanen wrote:
Hi Daniel,
this looks nice but there is a small issue when we get the connman-vpn
integrated into connman. The connman-vpnd is linking storage.c as it
needs some functions from there but it does not need config.c. If we
could keep the notify
Hi Jukka,
On 19.10.2012 13:57, Jukka Rissanen wrote:
Hi Daniel,
the dbus stuff is quite mandatory in this plugin anyway so perhaps this
could be merged with the previous patch.
Yeah, a too small step. I thought it helps reviewing. Let me squash it
to the previous patch.
cheers,
daniel
On 19.10.2012 14:58, Daniel Wagner wrote:
Hi Jukka,
On 19.10.2012 13:50, Jukka Rissanen wrote:
Hi Daniel,
this looks nice but there is a small issue when we get the connman-vpn
integrated into connman. The connman-vpnd is linking storage.c as it
needs some functions from there but it does not
On 19.10.2012 14:13, Jukka Rissanen wrote:
On 19.10.2012 14:58, Daniel Wagner wrote:
Hi Jukka,
On 19.10.2012 13:50, Jukka Rissanen wrote:
Hi Daniel,
this looks nice but there is a small issue when we get the connman-vpn
integrated into connman. The connman-vpnd is linking storage.c as it
Hi Jukka,
if the system has multiple wifi cards and user has connected to
access point successfully using one of the cards, then we know
the credentials to that AP. So we can reuse this information
when connecting to the same AP using different card (=service).
so explain to me why this is
On fre, 2012-10-19 at 13:47 +0200, Daniel Wagner wrote:
On Fri, Oct 19, 2012 at 01:11:36PM +0300, Patrik Flykt wrote:
- return 0;
+ return (*session-policy-create)(session, callback, user_data);
Here also a check for the create function is needed before calling it.
I think I am
On Wed, 2012-10-17 at 14:42 +0200, Daniel Wagner wrote:
From: Daniel Wagner daniel.wag...@bmw-carit.de
---
include/storage.h | 8 +++
src/config.c | 122 +-
src/connman.h | 5 ++
src/main.c| 2 +
src/storage.c | 155
Hi,
gdbus/ should be kept in sync between Bluez, ConnMan, oFono and neard.
Any other code should be added elsewhere.
On Wed, 2012-10-17 at 14:42 +0200, Daniel Wagner wrote:
From: Daniel Wagner daniel.wag...@bmw-carit.de
---
Makefile.am | 2 +-
gdbus/gdbus.h | 9 +++
On Wed, 2012-10-17 at 14:42 +0200, Daniel Wagner wrote:
From: Daniel Wagner daniel.wag...@bmw-carit.de
This and the following patches could make a set of their own, no?
Cheers,
Patrik
___
connman mailing list
connman@connman.net
On fre, 2012-10-19 at 14:00 +0200, Daniel Wagner wrote:
Let me squash it to the previous patch.
+1 from me.
Patrik
___
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman
On Wed, 2012-10-17 at 14:42 +0200, Daniel Wagner wrote:
From: Daniel Wagner daniel.wag...@bmw-carit.de
---
plugins/session_policy_ivi.c | 50
+++-
1 file changed, 49 insertions(+), 1 deletion(-)
diff --git a/plugins/session_policy_ivi.c
Hi,
On Wed, 2012-10-17 at 14:42 +0200, Daniel Wagner wrote:
Move the configuration part of __connman_session_create() into
session_create_cb(). With this change the policy plugin is able
to do async work to retrieve a configuration.
---
src/session.c | 190
On ons, 2012-10-17 at 14:42 +0200, Daniel Wagner wrote:
From: Daniel Wagner daniel.wag...@bmw-carit.de
Instead using glib's cleanup hooks for the hash table, we implement
it ourself. The reason for doing this is that we will use the
policy_data structure via a second hash table. So there is
Hi,
This one could have gone in by default so that this refactoring patch
would not be needed. Of course with at commit message stating that
new_config() is to be used in a later patch in another place.
Cheers,
Patrik
___
connman
On Wed, 2012-10-17 at 14:42 +0200, Daniel Wagner wrote:
From: Daniel Wagner daniel.wag...@bmw-carit.de
---
plugins/session_policy_ivi.c | 116
+++
1 file changed, 116 insertions(+)
diff --git a/plugins/session_policy_ivi.c
Hi,
On Wed, 2012-10-17 at 14:42 +0200, Daniel Wagner wrote:
From: Daniel Wagner daniel.wag...@bmw-carit.de
---
plugins/session_policy_ivi.c | 36
1 file changed, 28 insertions(+), 8 deletions(-)
diff --git a/plugins/session_policy_ivi.c
On ons, 2012-10-17 at 14:42 +0200, Daniel Wagner wrote:
From: Daniel Wagner daniel.wag...@bmw-carit.de
---
include/session.h | 4 +++
src/session.c | 76
+--
2 files changed, 56 insertions(+), 24 deletions(-)
diff --git
On Wed, 2012-10-17 at 14:42 +0200, Daniel Wagner wrote:
From: Daniel Wagner daniel.wag...@bmw-carit.de
---
plugins/session_policy_ivi.c | 94
+++-
1 file changed, 92 insertions(+), 2 deletions(-)
diff --git a/plugins/session_policy_ivi.c
Hi there,
There are quite a few fixes in git added after the latest ConnMan
release. It would be nice if people could try out the latest and
greatest and report back if any issues are found.
Cheers,
Patrik
___
connman mailing list
43 matches
Mail list logo
