[PATCH] agent: Keep track of the driver to unref user context relevantly

2013-01-15 Thread Tomasz Bursztyka
Fixes BMC#25884 --- src/agent.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/agent.c b/src/agent.c index 3be4b61..5c3bd28 100644 --- a/src/agent.c +++ b/src/agent.c @@ -187,9 +187,10 @@ int connman_agent_queue_message(void *user_context, driver =

[PATCH] ipconfig: Do not disable IPv6 in lower up state

2013-01-15 Thread Jukka Rissanen
Disabling IPv6 in lower up causes problems in IPv6 connectivity. The interface IPv6 status can stay in disabled state because of races. So this patch reverts the commit 4ce90440a70abce7de53 and lets service IPv6 state go to READY when we get an auto configured address for the interface. Fixes

Re: [PATCH] network: Do not report any error when removing a connecting network

2013-01-15 Thread Patrik Flykt
Hi, On Tue, 2013-01-15 at 14:57 +0200, Tomasz Bursztyka wrote: Sorry for the size of the patch, it's actually nothing, really. 99.9% is just moving many static functions up into the file and that's it. The 0.1%, which is the actual fix, is in network_remove(): -

[PATCH] service: Trigger autoconnect when AutoConnect flag is enabled

2013-01-15 Thread Jukka Rissanen
--- src/service.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/service.c b/src/service.c index 5845453..a121b86 100644 --- a/src/service.c +++ b/src/service.c @@ -3045,6 +3045,9 @@ static DBusMessage *set_property(DBusConnection *conn, autoconnect_changed(service);

Re: Pre-configuring an ethernet interface

2013-01-15 Thread Patrik Flykt
Hi, On Fri, 2013-01-11 at 14:36 +0100, Bach, Pascal wrote: 1. Provide a default configuration .config file that sets the Ethernet defaults to something static instead of DHCPv4. This would be good to do some default factory configuration. This one is doable. 2. Allow the user to

Re: [PATCH] service: Update notifier state when relevant while getting ready

2013-01-15 Thread Patrik Flykt
On Tue, 2013-01-15 at 10:20 +0200, Tomasz Bursztyka wrote: When getting 1 service to online, and disonnecting it: Manager state stays at 'ready'. This is due to service updating the notifier about its state 'ready' 2 times. Once when connecting: idle - ready, and once when disconnecting:

Re: [PATCH] agent: Keep track of the driver to unref user context relevantly

2013-01-15 Thread Patrik Flykt
On Tue, 2013-01-15 at 14:57 +0200, Tomasz Bursztyka wrote: Fixes BMC#25884 Applied, thanks! Patrik ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [PATCH] ipconfig: Do not disable IPv6 in lower up state

2013-01-15 Thread Daniel Wagner
Hi Jukka, On 15.01.2013 15:11, Jukka Rissanen wrote: Disabling IPv6 in lower up causes problems in IPv6 connectivity. The interface IPv6 status can stay in disabled state because of races. So this patch reverts the commit 4ce90440a70abce7de53 and lets service IPv6 state go to READY when we

Re: [PATCH] service: Trigger autoconnect when AutoConnect flag is enabled

2013-01-15 Thread Daniel Wagner
Hi Jukka, On 15.01.2013 15:47, Jukka Rissanen wrote: --- src/service.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/service.c b/src/service.c index 5845453..a121b86 100644 --- a/src/service.c +++ b/src/service.c @@ -3045,6 +3045,9 @@ static DBusMessage

Re: [PATCH] ipconfig: Do not disable IPv6 in lower up state

2013-01-15 Thread Jukka Rissanen
Hi Daniel, On 15 January 2013 17:21, Daniel Wagner w...@monom.org wrote: I can't remember what the exact setup and problem was. But I played a bit around with AutoConnect=false/true Connect()/Disconnect() and plug/unplug the ethernet cableo on a IPv4/IPv6 network and everything seems to work

Re: [PATCH] service: Update notifier state when relevant while getting ready

2013-01-15 Thread Tomasz Bursztyka
Hi Patrik, Applied, thanks! Was there a BMC bug number for this one also? Afaik, no. Tomasz ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman