Re: [PATCH v0 00/16] Managed iptables API

2013-02-28 Thread Patrik Flykt
Hi, On Wed, 2013-02-27 at 16:55 +0100, Daniel Wagner wrote: From: Daniel Wagner daniel.wag...@bmw-carit.de Hi, This series starts with a few fixes for pretty nasty bugs which are hiddin in the iptables code. The mrore interesting part is the managed iptables API. This API

Re: [RFC v1 04/16] inet: Add functions to setup fwmark to routing table

2013-02-28 Thread Tomasz Bursztyka
Hi Daniel, + +/* + * Tie the table number to interface index number, substract 1 because + * indexes are 0 + */ +static uint32_t get_table_id(int ifindex) +{ + const uint32_t value = ('c' 24) | ('m' 16) | ('a' 8) | 'n'; + + return value + ifindex - 1; +} Don't introduce this

Re: [RFC v1 07/16] netfilter: Add netlink basic infrastructure

2013-02-28 Thread Tomasz Bursztyka
Hi Daniel, Instead of factoring out common parts from rtnl.c we add a new implementation for handling the upcoming ACCT netfilter netlink messages. The main reason is not to disturb the working rtnl code (although it has several hidden bugs, which are not triggered by the ussage pattern). The

Re: [RFC v1 02/16] iptctx: Add iptables context helper

2013-02-28 Thread Patrik Flykt
Hi, On Wed, 2013-02-27 at 16:56 +0100, Daniel Wagner wrote: This helpers allow to add a bunch of iptables rules together into a set and then apply them in a 'atomic' way. Unfortunatly, it is not garanteed to be completely automic but way better then having several places trying to

[PATCH] vpn-provider: Parse user networks correctly

2013-02-28 Thread Jukka Rissanen
Check NULL string before passing it to g_strsplit() --- vpn/vpn-provider.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/vpn/vpn-provider.c b/vpn/vpn-provider.c index 0336636..3b0ab8f 100644 --- a/vpn/vpn-provider.c +++ b/vpn/vpn-provider.c @@ -1869,9 +1869,13 @@ static

Re: [RFC v1 13/16] session: Store creation related data into a struct

2013-02-28 Thread Tomasz Bursztyka
Hi Daniel, During the creation period we need to keep track of data which is only needed during this period. Let's rename user_config to create_data and store all the necessary data there. This includes the session pointer so that we don't have to pass two void pointers around in the callbacks

Re: [PATCH] vpn-provider: Parse user networks correctly

2013-02-28 Thread Patrik Flykt
On Thu, 2013-02-28 at 11:00 +0200, Jukka Rissanen wrote: Check NULL string before passing it to g_strsplit() Applied, thanks! Patrik ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

Re: [RFC v1 07/16] netfilter: Add netlink basic infrastructure

2013-02-28 Thread Marcel Holtmann
Hi Daniel, Instead of factoring out common parts from rtnl.c we add a new implementation for handling the upcoming ACCT netfilter netlink messages. The main reason is not to disturb the working rtnl code (although it has several hidden bugs, which are not triggered by the ussage pattern).

Re: [RFC v1 07/16] netfilter: Add netlink basic infrastructure

2013-02-28 Thread Tomasz Bursztyka
Hi Marcel, Let's adapt (and fix if necessary) rtnl instead. In the near future there is a nicer netlink handling code which is coming also, so it will require a bit of work in rtnl anyway. You might want to wait for this maybe. Check this with Marcel. is ACCT netfilter plain netlink or

Autoconnect to a hidden wifi service.

2013-02-28 Thread Sameer Naik
Hello, I am using connman-1.12 on a STB platform. I have implemented a connman client and agent to handle connecting to wired and wireless services via connman. I am currently testing connections to hidden wireless services. Right now i am able to connect to hidden wifi services after responding

Understanding connman's ONLINE state change.

2013-02-28 Thread Sameer Naik
Hello, I was trying to understand the state change of services from READY to ONLINE state. From what i can gather a service state will change from READY to ONLINE once connman is able to fetch Hidden=truehttp://ipv4.connman.net/online/status.html(for ipv4). In my system i have a wired service

Re: Autoconnect to a hidden wifi service.

2013-02-28 Thread Tomasz Bursztyka
Hi Sameer, I am wondering whether connman is supposed to be able to autoconnect to this hidden wifi service or is this the expected behaviour. It should autoconnect also with hidden service. Works perfectly with my config but there is maybe an issue with yours. Could you provide the logs of

Re: Understanding connman's ONLINE state change.

2013-02-28 Thread Tomasz Bursztyka
Hi Sameer, I guess this is the expected behaviour. You guess right. I would like to know if it is possible to instruct connman to connect all available technologies, so that at startup it connects to the wired as well as the wireless services and then decides which one to setup as the

Re: Understanding connman's ONLINE state change.

2013-02-28 Thread Sameer Naik
Got it. Will try to hack the source. Will let you guys know if i get anywhere. Thanks and Regards ~Sameer On Fri, Mar 1, 2013 at 12:26 AM, Tomasz Bursztyka tomasz.burszt...@linux.intel.com wrote: Hi Sameer, I guess this is the expected behaviour. You guess right. I would like to

Connman upstream test result_20130301

2013-02-28 Thread Li, XiaX
Hi all, This is test report for commit 8397cbbc0a79d39cf3b1880f4fd3f3405b6bc6ad. In this testing,we ran 259 cases. 258 cases passed and 1 case failed. The pass rate is 99.6%. We found 0 new bug,reopen 0 bug and verify 1 bug. I n this commit we found the bug that connmanctl can't display hidden