Le 07/03/2013 16:45, Daniel Wagner a écrit :
On 03/07/2013 03:33 PM, Patrik Flykt wrote:
On Thu, 2013-03-07 at 14:35 +0100, Daniel Wagner wrote:
Currently, find_chain_tail() returns the element after the chain end.
Let's keep it the old way until there is a real reason to do something
else. I
Le 07/03/2013 15:35, Daniel Wagner a écrit :
- /* We have deleted a rule,
-* all references should be bumped accordingly */
+ /*
+* We have deleted a rule, all references should be bumped
+* accordingly
+*/
What an improvement ;]
Just kidding.
Seriou
Hi Daniel,
I really should spend more time in explaining stuff in the cover letter.
These patches are kind of left overs from the bug fixing session and
not really necessary if you think in 'does it fix a bug' or 'it's a
new feature'. These patches are just plain maintaining work which
impro
On 03/08/2013 09:09 AM, Tomasz Bursztyka wrote:
Le 07/03/2013 15:35, Daniel Wagner a écrit :
-/* We have deleted a rule,
- * all references should be bumped accordingly */
+/*
+ * We have deleted a rule, all references should be bumped
+ * accordingly
+ */
What an impro
Hi Daniel,
And then I just realized that in iptables_flush_chain() the exact open
coded update function exists:
Of course duplication is not ok.
See, it was worth being picky: now you found a interesting
refactorization point, which you patch was not correcting.
Please redo your patch with
On Tue, 2013-03-05 at 16:06 +0200, Jukka Rissanen wrote:
> The immutable settings are those that are read from .config file.
> ---
> vpn/vpn-provider.c | 29 -
> vpn/vpn.h | 2 ++
> 2 files changed, 26 insertions(+), 5 deletions(-)
>
> diff --git a/vpn/vpn-pr
Hi Tomasz,
On 03/08/2013 09:09 AM, Tomasz Bursztyka wrote:
Le 07/03/2013 16:45, Daniel Wagner a écrit :
On 03/07/2013 03:33 PM, Patrik Flykt wrote:
On Thu, 2013-03-07 at 14:35 +0100, Daniel Wagner wrote:
Currently, find_chain_tail() returns the element after the chain end.
Let's keep it the
Hi Tomasz,
On 03/08/2013 09:32 AM, Tomasz Bursztyka wrote:
I really should spend more time in explaining stuff in the cover letter.
These patches are kind of left overs from the bug fixing session and
not really necessary if you think in 'does it fix a bug' or 'it's a
new feature'. These patche
Hi,
reproduced bugs:
===
25125 - There is still IP address on client after disable-tethering bluetooth
https://bugs.meego.com/show_bug.cgi?id=25125
This one is no longer relevant to reproduce with wrong version of BlueZ.
It has been resolved/fixed f
On Thu, 2013-03-07 at 10:56 +0200, Jukka Rissanen wrote:
> Fixes BMC#25978
Applied, thanks!
Patrik
___
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman
On Thu, 2013-03-07 at 10:45 +0200, Jukka Rissanen wrote:
> Because we now support provisioning of VPN services via .config file,
> we need to keep vpnd running so that it can monitor the connman-vpn
> directory for new config files.
Applied, thanks!
Patrik
On Thu, 2013-03-07 at 12:34 +0200, Jukka Rissanen wrote:
> Because we now support provisioning of VPN services via .config file,
> we need to keep vpnd running so that it can monitor the connman-vpn
> directory for new config files.
This version was the one that got applied, sorry for the confusi
On Fri, 2013-03-08 at 12:13 +0200, Patrik Flykt wrote:
> Applied, thanks!
v2 was the one actually applied.
Patrik
___
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman
Hi Tomasz,
On 03/08/2013 10:08 AM, Tomasz Bursztyka wrote:
And then I just realized that in iptables_flush_chain() the exact open
coded update function exists:
Of course duplication is not ok.
See, it was worth being picky: now you found a interesting
refactorization point, which you patch was
On Thu, 2013-03-07 at 15:46 +0100, Daniel Wagner wrote:
> > If you make a unit test out of it, one probably should add a stub
> > implementation of xtables... not going to happen ever.
> >
> > If on the other hand the intention is to verify correct behavior of
> > kernel space components, it's welc
On 08.03.2013 11:27, Patrik Flykt wrote:
On Tue, 2013-03-05 at 16:06 +0200, Jukka Rissanen wrote:
The immutable settings are those that are read from .config file.
---
vpn/vpn-provider.c | 29 -
vpn/vpn.h | 2 ++
2 files changed, 26 insertions(+), 5 dele
On Tue, 2013-03-05 at 16:06 +0200, Jukka Rissanen wrote:
> Hi,
>
> the immutable flag handling was missing from VPN provisioning
> patch set. This patchset fixes the issue.
Applied, thanks!
Patrik
___
connman mailing list
connman@connman.net
ht
On Thu, 2013-03-07 at 18:13 +0200, Jukka Rissanen wrote:
> Hi,
>
> While debugging weird pptp vpn issues (thanks lufie!), I noticed
> some races and bugs in the current vpn code.
>
> In patch 1 we clear the data pointer (which points to ourselves)
> so that we do not accidentally try to access fr
18 matches
Mail list logo
