[PATCH v2] client: Add support for tethering

2013-04-18 Thread Patrik Flykt
Add tethering support. For WiFi also set the SSID and passphrase if they have been specified on the command line. Check that setting both SSID and passphrase succeed before trying to enable tethering. After successfully setting SSID and passphrase for WiFi, use the boolean value parsing helper

Re: DHCPv6 client compliance to RFCs.

2013-04-18 Thread harshal patel
Hi, On Wed, Apr 17, 2013 at 1:35 PM, Jukka Rissanen jukka.rissa...@linux.intel.com wrote: On 17.04.2013 10:13, harshal patel wrote: Hi Jukka, Thank you very much for your prompt reply. :-) On Wed, Apr 17, 2013 at 12:11 PM, Jukka Rissanen jukka.rissanen@linux.intel.**com

[PATCH] client: Follow coding style

2013-04-18 Thread Patrik Flykt
Follow coding style and use __connmanctl prefix for the commands() function. --- client/commands.c |2 +- client/commands.h |2 +- client/input.c|7 --- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/client/commands.c b/client/commands.c index 1a5f638..5937c54

Re: DHCPv6 client compliance to RFCs.

2013-04-18 Thread Jukka Rissanen
On 18.04.2013 09:48, harshal patel wrote: Hi, On Wed, Apr 17, 2013 at 1:35 PM, Jukka Rissanen jukka.rissa...@linux.intel.com mailto:jukka.rissa...@linux.intel.com wrote: On 17.04.2013 10:13, harshal patel wrote: Hi Jukka, Thank you very much for your prompt reply. :-)

[PATCH v1 3/5] session: Do not fail when creating default policy configuration

2013-04-18 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de Do not handle the small alloc failures because glib will abort when memory is tight anyway. --- include/session.h | 2 +- plugins/session_policy_local.c | 13 + src/session.c | 16 +++- 3 files

[PATCH v1 2/5] session: Change to func_t postfix to callback typedef

2013-04-18 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de Streamline the callback typedefs with the rest of the code. --- include/session.h | 4 ++-- plugins/session_policy_local.c | 6 +++--- src/session.c | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff

[PATCH v1 0/5] Preperation patches for UID/GID feature

2013-04-18 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de Hi, v1: Rebased this patch set on the current master. These patches prepare the stage for the UID/GID policy plugin feature. I have grouped the patches based where the changes happens. Previously I had a different ordering but this one seems

[PATCH v1 4/5] dbus: Refactor callback helper struct

2013-04-18 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de The helper struct will be used by a new dbus function which uses a different callback signature. Therefore, we need to use a void pointer for storing the callback. --- src/dbus.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-)

[PATCH v1 1/5] session_policy_local: Use callback helpers

2013-04-18 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de Use the generic callback helpers to encapsulate struct create_data. In a later patch we will add some more data elemets to struct create_data. That is the reason why it is not remove here. --- plugins/session_policy_local.c | 16 +--- 1

[PATCH v1 5/5] dbus: Add connman_dbus_get_connnection_unix_user()

2013-04-18 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de --- include/dbus.h | 8 + src/dbus.c | 93 ++ 2 files changed, 101 insertions(+) diff --git a/include/dbus.h b/include/dbus.h index c00488e..85e8ede 100644 --- a/include/dbus.h +++

[PATCH] iptabes-test2: Rename iptables-unit

2013-04-18 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de This is an end to end test and not a prober unit test. --- .gitignore | 2 +- Makefile.am| 14 +- tools/iptables-test2.c | 556 + tools/iptables-unit.c | 556

Re: DHCPv6 client compliance to RFCs.

2013-04-18 Thread harshal patel
Hi, On Thu, Apr 18, 2013 at 12:36 PM, Jukka Rissanen jukka.rissa...@linux.intel.com wrote: On 18.04.2013 09:48, harshal patel wrote: Hi, On Wed, Apr 17, 2013 at 1:35 PM, Jukka Rissanen jukka.rissanen@linux.intel.**com jukka.rissa...@linux.intel.commailto:

Re: DHCPv6 client compliance to RFCs.

2013-04-18 Thread Patrik Flykt
Hi, On Thu, 2013-04-18 at 14:27 +0530, harshal patel wrote: The network should know better than the user what is the correct setting. The end user probably has no idea what the dhcpv6 mode should be or what dhcpv6 even means. There is also a issue that if the network says we

Re: [PATCH v1 0/5] Preperation patches for UID/GID feature

2013-04-18 Thread Patrik Flykt
On Thu, 2013-04-18 at 09:07 +0200, Daniel Wagner wrote: From: Daniel Wagner daniel.wag...@bmw-carit.de Hi, v1: Rebased this patch set on the current master. Applied, thanks! Patrik ___ connman mailing list connman@connman.net

[PATCH v0 00/11] Add UID/GID support to session policies

2013-04-18 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de Hi, [In case you are confused about the previous version I already sent out ignore them. I restart again with v0 on this set.] This is against the current master. This series contains in the first part a few refactoring patches which are all

[PATCH v0 01/11] session_policy_local: Do not handle small allocation

2013-04-18 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de Let's remove the small allocations error path because glib will abort on memory exhausting anyway. Basically we remove dead code. --- plugins/session_policy_local.c | 33 - 1 file changed, 4 insertions(+), 29

[PATCH v0 03/11] session_policy_local: Add some more debug infos

2013-04-18 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de --- plugins/session_policy_local.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/plugins/session_policy_local.c b/plugins/session_policy_local.c index 42cd1dd..f616219 100644 ---

[PATCH v0 04/11] session_policy_local: Print warning if loading of policy fails

2013-04-18 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de Also continue reading the rest of the policy files when starting up. This makes the startup behavior consistent with the runtime behavior. --- plugins/session_policy_local.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-)

[PATCH v0 05/11] session_policy_local: Track policy data structure in a separate list

2013-04-18 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de We want to make the lifetime of the policy data structure independent of the policy_hash table. --- plugins/session_policy_local.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/plugins/session_policy_local.c

[PATCH v0 06/11] session_policy_local: Use policy_hash only to track the policy files

2013-04-18 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de Let's move the owner ship to the policy_list. The policy_hash is only used to lookup the policy data structure. This patch removes the requirement that the 'ident' is key to lookup the policy data. Now we are able to define set of rules how we want

[PATCH v0 08/11] session_policy_local: Rename ident to filename

2013-04-18 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de ident is not shared anymore between the session policy and the file policy. Let's make this clear be renaming this member. --- plugins/session_policy_local.c | 45 +- 1 file changed, 23 insertions(+), 22

[PATCH v0 07/11] session_policy_local: Rename policy_hash to file_hash

2013-04-18 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de Which reflects the new usage of the hash much better. --- plugins/session_policy_local.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/plugins/session_policy_local.c b/plugins/session_policy_local.c index

[PATCH v0 10/11] session_policy_local: Retrieve UID/GID from session user

2013-04-18 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de When the session core ask to create a configuration, then we first ask the D-Bus server which UID/GID the session belongs to. If possible we also ask for the SELinux context. Then we try to figure out which file containts the configuration for

[PATCH v0 11/11] session-test: Add tests for session_policy_local

2013-04-18 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de Use the UID as identification. --- tools/session-test.c | 156 +++ 1 file changed, 156 insertions(+) diff --git a/tools/session-test.c b/tools/session-test.c index c296b95..7d62357 100644 ---

[PATCH v0 09/11] session_policy_local: Split LSM context ident from filename

2013-04-18 Thread Daniel Wagner
From: Daniel Wagner daniel.wag...@bmw-carit.de Separate the id which associates the file and the session. find_policy_by_file() and find_policy_by_lsm() contain the logic which associates the configuration file with a session. --- plugins/session_policy_local.c | 66

[PATCH 0/2] connmanctl string input enhancements

2013-04-18 Thread Patrik Flykt
Hi, Enhance connmanctl string input by providing command completion and handle spaces at command start, end and separation properly. Cheers, Patrik Patrik Flykt (2): client: Add command completion client: Trim off spaces from user input client/commands.c | 23

[PATCH 1/2] client: Add command completion

2013-04-18 Thread Patrik Flykt
Add completion support for connmanctl commands. --- client/commands.c | 23 +++ client/commands.h |1 + client/input.c| 14 ++ 3 files changed, 38 insertions(+) diff --git a/client/commands.c b/client/commands.c index cb0d5dd..dd23593 100644 ---

[PATCH 2/2] client: Trim off spaces from user input

2013-04-18 Thread Patrik Flykt
After splitting the input string into components, create a new array holding the non-zero substrings as input for the commands. Thus the input can start and end as well as divide its separate parts by any number spaces. --- client/input.c | 28 1 file changed, 20

Re: DHCPv6 client compliance to RFCs.

2013-04-18 Thread harshal patel
Hi, On Thu, Apr 18, 2013 at 2:54 PM, Patrik Flykt patrik.fl...@linux.intel.comwrote: Hi, On Thu, 2013-04-18 at 14:27 +0530, harshal patel wrote: The network should know better than the user what is the correct setting. The end user probably has no idea what the dhcpv6 mode

Re: [PATCH] iptabes-test2: Rename iptables-unit

2013-04-18 Thread Marcel Holtmann
Hi Daniel, This is an end to end test and not a prober unit test. --- .gitignore | 2 +- Makefile.am| 14 +- tools/iptables-test2.c | 556 + tools/iptables-unit.c | 556 -

Re: DHCPv6 client compliance to RFCs.

2013-04-18 Thread harshal patel
Hi Marcel, On Thu, Apr 18, 2013 at 9:35 PM, Marcel Holtmann mar...@holtmann.orgwrote: Hi Harshal, On Thu, 2013-04-18 at 14:27 +0530, harshal patel wrote: The network should know better than the user what is the correct setting. The end user probably has no idea what the dhcpv6 mode

Re: DHCPv6 client compliance to RFCs.

2013-04-18 Thread Marcel Holtmann
Hi Harshal, The network should know better than the user what is the correct setting. The end user probably has no idea what the dhcpv6 mode should be or what dhcpv6 even means. There is also a issue that if the network says we should use statefull addresses, and user configures the system

Connman upstream test result_20130419

2013-04-18 Thread Li, XiaX
Hi all, This is test report for commit d1e576cfbe3d7458e984264ba2efc3f17088a0ce. In this testing, we ran 109 cases. 104 cases passed and 5 case failed. The pass rate is 95%.We found 0 new bug, reopen 0 bug and verify 0 bug. New bug === N/A Re-open