Re: Connman network refcount

2015-01-13 Thread Patrik Flykt
On Tue, 2015-01-13 at 19:30 -0800, Naveen Singh wrote: > I did a simple test of connecting to a WiFi AP and What version of ConnMan and wpa_supplicant are you talking about? Cheers, Patrik ___ connman mailing list connman@connman.net https:/

Re: Connman network refcount

2015-01-13 Thread Tomasz Bursztyka
Hi, So Looks like decrementing the ref count from network removed was not correct. So either we add the network ref count from network_added function in supplicant or remove it from the network_removed function. Any thoughts? I am sorry, but what your are experiencing is really unclear. Con

Re: Tethering on startup?

2015-01-13 Thread David Lechner
On 01/13/2015 06:53 PM, Mike Purvis wrote: When I set up connman 1.27 to connect to an AP and then restart my machine, it seems to reconnect okay on startup (most of the time). However, when I set it to create an AP (tether) and restart my machine, it comes up with the wifi idle. Is there a way

Connman network refcount

2015-01-13 Thread Naveen Singh
I did a simple test of connecting to a WiFi AP and then doing a disconnect using connmanctl. I found that the connman crashed while trying to decrement the network ref count from network_removed() function in plugins/wifi.c static void network_removed(GSupplicantNetwork *network){ GSupplic

Tethering on startup?

2015-01-13 Thread Mike Purvis
When I set up connman 1.27 to connect to an AP and then restart my machine, it seems to reconnect okay on startup (most of the time). However, when I set it to create an AP (tether) and restart my machine, it comes up with the wifi idle. Is there a way to have it resume the tethering activity on

Re: 100% CPU when tethering

2015-01-13 Thread Mike Purvis
Works great, thanks for the quick fix! The connman 1.27 package on my PPA has now been updated to include this patch; it may be of use to anyone else running connman on Ubuntu Trusty systems: https://launchpad.net/~mikepurvis/+archive/ubuntu/network On 12 January 2015 at 09:29, Mike O'Driscoll <

[PATCH v3 6/9] rtnl: Cleanup IO watch on exit

2015-01-13 Thread Hannu Mallat
Besides the IO channel for routing events, the associated watch also needs to be cleaned up on exit. --- src/rtnl.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/rtnl.c b/src/rtnl.c index a46aa28..e03a390 100644 --- a/src/rtnl.c +++ b/src/rtnl.c @@ -1291,6 +12

[PATCH v3 7/9] peer: Clean up at exit

2015-01-13 Thread Hannu Mallat
Clean up all structures allocated at initialization. --- src/peer.c | 4 1 file changed, 4 insertions(+) diff --git a/src/peer.c b/src/peer.c index 5e9006f..b36b28f 100644 --- a/src/peer.c +++ b/src/peer.c @@ -1177,6 +1177,10 @@ void __connman_peer_cleanup(void) { DBG(""); +

[PATCH v3 5/9] technology: Clean up technology list on exit

2015-01-13 Thread Hannu Mallat
Clean up technology list when exiting. List may have been populated e.g. by rfkill events. --- src/technology.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/technology.c b/src/technology.c index cd4bc6f..8b26af0 100644 --- a/src/technology.c +++ b/src/technology.c @@ -1811,6 +1811

[PATCH v3 4/9] supplicant: Don't wait for interface removal reply if not needed

2015-01-13 Thread Hannu Mallat
Don't wait for a reply from supplicant for interface removal if there's not callback function for processing the reply. --- gsupplicant/supplicant.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c index 060a4df..ef7239f

[PATCH v3 9/9] main: Free wifi option parameter

2015-01-13 Thread Hannu Mallat
As option_wifi is allocated by the option parser, free it before exiting. --- src/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main.c b/src/main.c index ba09eb6..1c17991 100644 --- a/src/main.c +++ b/src/main.c @@ -749,6 +749,7 @@ int main(int argc, char *argv[]) g_strfre

[PATCH v3 8/9] dnsproxy: Clean up cache on exit

2015-01-13 Thread Hannu Mallat
Clean up DNS cache and any associated timer on exit. --- src/dnsproxy.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/src/dnsproxy.c b/src/dnsproxy.c index 7562067..9d7ba61 100644 --- a/src/dnsproxy.c +++ b/src/dnsproxy.c @@ -215,6 +215,7 @@ static GSList *re

[PATCH v3 1/9] bluetooth: Clean up gdbus client on exit

2015-01-13 Thread Hannu Mallat
Gdbus client for BlueZ was created on plugin initialization, but not cleaned up on plugin exit. Fixed by adding a g_dbus_client_unref() to bluetooth_exit(). --- plugins/bluetooth.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index c6f387e..533c6c

[PATCH v3 2/9] rfkill: Cleanup IO watch on exit

2015-01-13 Thread Hannu Mallat
IO watch for rfkill events needs to be cleaned up on exit. --- src/rfkill.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/src/rfkill.c b/src/rfkill.c index 960cfea..c6f9674 100644 --- a/src/rfkill.c +++ b/src/rfkill.c @@ -153,7 +153,7 @@ static gbool

[PATCH v3 0/9] Small memory allocation fixes

2015-01-13 Thread Hannu Mallat
Reworked patch 2 and 3 based on review comments; did not touch patch 6 as the channel variable is referenced in send_request(). Getting rid of that reference would require adding channel as a parameter and changing all the callers, which is probably more work than it's worth. As I had previously s

[PATCH v3 3/9] supplicant: Do not wait for D-Bus reply if it's not used

2015-01-13 Thread Hannu Mallat
Don't wait for a reply from supplicant for D-Bus calls which don't have a callback function for processing the reply. --- gsupplicant/dbus.c | 42 ++ 1 file changed, 26 insertions(+), 16 deletions(-) diff --git a/gsupplicant/dbus.c b/gsupplicant/dbus.c inde

Re: Bluetooth plugin return values.

2015-01-13 Thread David Lechner
On 01/13/2015 01:28 AM, Patrik Flykt wrote: On Mon, 2015-01-12 at 17:26 -0600, David Lechner wrote: I noticed that when enabling tethering on bluetooth (using 1.27) that it says "Error enabling bluetooth tethering: In progress". Same with disabling: "Error disabling bluetooth tethering: In progr

Re: [PATCH 6/9] rtnl: Cleanup IO watch on exit

2015-01-13 Thread Patrik Flykt
Hi, On Thu, 2015-01-08 at 11:26 -0500, Hannu Mallat wrote: > Besides the IO channel for routing events, the associated watch also > needs to be cleaned up on exit. > --- > src/rtnl.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/src/rtnl.c b/src/rt

Re: multiple scan_callback_hidden for a single wifi scan request making ref count to go to 0

2015-01-13 Thread Tomasz Bursztyka
Hi, You don't seem to have the connman from upstream. There have never been such wifi_data_ref and wifi_data_unref functions. Looks like your version has some additional patches on top. Tomasz ___ connman mailing list connman@connman.net https://list

Re: [PATCH 3/9] supplicant: Do not wait for D-Bus reply if it's not used

2015-01-13 Thread Patrik Flykt
Hi, On Thu, 2015-01-08 at 11:26 -0500, Hannu Mallat wrote: > Don't wait for a reply from supplicant for D-Bus calls which don't > have a callback function for processing the reply. > --- > gsupplicant/dbus.c | 23 --- > 1 file changed, 16 insertions(+), 7 deletions(-)

Re: [PATCH 2/9] rfkill: Cleanup IO watch on exit

2015-01-13 Thread Patrik Flykt
Hi, On Thu, 2015-01-08 at 11:26 -0500, Hannu Mallat wrote: > Besides the IO channel for rfkill events, the associated watch also > needs to be cleaned up on exit. > --- > src/rfkill.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/src/rfkill.c b/src

Re: [PATCH v2 0/6] Peer API change: Local and Remote IP

2015-01-13 Thread Patrik Flykt
On Fri, 2015-01-09 at 15:47 +0200, Tomasz Bursztyka wrote: > 2 Bugs were found in v1 and fixed. > > Each Peer object, once connected, will provide its local and remote IPv4 > addresses through the IPv4 dict. Applied all patches, thanks! Patrik ___