[RFC PATCH] Add support for EAP-FAST authentication method

Introduces two new configuration keywords: - PACFile: PAC (Protected Access Credentials) file for EAP-FAST - FASTProv: Configure different EAP-FAST provisioning modes, possible values are: 0 = provisioning disabled 1 = anonymous provisioning only 2 = authenticated provisioning only 3 = both

Re: [RFC PATCH] Add support for EAP-FAST authentication method

Saved this old WIP patch here that I found from my disk, just in case anyone finds it useful. Code is untested and does not apply to newest connman. - Henri ___ connman mailing list connman@connman.net http://lists.connman.net/listinfo/connman

[PATCH] Fixed setting proxy auto-config URL

URL can now be cleared and updates will be propagated over DBus. This could introduce a need to null-check values where this function is used (src/dhcp.c, src/network.c, src/provider.c). However, src/dhcp.c requires that URL can be cleared. --- src/service.c |5 ++--- 1 files changed, 2

[PATCH 2/2] wifi: Use agent provided credentials as a fallback

--- plugins/wifi.c | 22 ++ 1 files changed, 18 insertions(+), 4 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index c5c0273..8b7a97c 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -372,7 +372,7 @@ static GSupplicantSecurity network_security(const char

[PATCH 0/2] Fix triggering of identity/passphrase query from agent

about the issue here: http://lists.connman.net/pipermail/connman/2011-June/005038.html Henri Bragge (2): service: Store agent provided credentials separately wifi: Use agent provided credentials as a fallback plugins/wifi.c | 22 ++ src/connman.h |4 src/network.c

[PATCH 1/2] service: Store agent provided credentials separately

Add new fields for agent provided identity/passphrase in service struct (agent_identity/agent_passphrase) and network (WiFi.AgentIdentity and WiFi.AgentPassphrase). Preparing these values in prepare_8021x() is left out because the same thing is done in request_input_cb(), which is where the

[PATCH v2 1/2] Enable clearing of proxy auto-config url

This could introduce a need to null-check values where this function is used (src/dhcp.c, src/network.c, src/provider.c). However, src/dhcp.c requires that URL can be cleared. --- src/service.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/service.c

Re: [RFC v1] Fix triggering of identity/passphrase query from agent

Hi Samuel, On Thu, 2011-06-30 at 17:18 +0200, Samuel Ortiz wrote: Hi Henri, On Tue, Jun 21, 2011 at 02:38:49PM +0300, Henri Bragge wrote: Query identity/passphrase if one of them is empty, rather than depending on service immutability. Do not cache agent provided credentials in service

Re: [RFC v1] Fix triggering of identity/passphrase query from agent

On Tue, 2011-06-21 at 14:38 +0300, Henri Bragge wrote: Query identity/passphrase if one of them is empty, rather than depending on service immutability. Do not cache agent provided credentials in service struct (ask them every time user wants to connect). --- Currently identity/passphrase

[RFC v1] Fix triggering of identity/passphrase query from agent

Query identity/passphrase if one of them is empty, rather than depending on service immutability. Do not cache agent provided credentials in service struct (ask them every time user wants to connect). --- Currently identity/passphrase are never queried from the agent in 802.1X networks. This

[PATCH resend v2 6/6] test: Add script to test manager.ProvisionService method

--- Rebased to newest git. Makefile.am|2 +- test/provision-service | 28 2 files changed, 29 insertions(+), 1 deletions(-) create mode 100755 test/provision-service diff --git a/Makefile.am b/Makefile.am index b4f3511..2ff5781 100644 ---

[PATCH v2 2/6] config: Fix service configuration update

Service config should not be replaced after update (the existing struct shall be reused). --- src/config.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/src/config.c b/src/config.c index e4dfcd9..dcef4e5 100644 --- a/src/config.c +++ b/src/config.c @@ -171,6

[PATCH v2 0/6] Service provisioning method in Manager API

handling Henri Bragge (6): doc: Add service provisioning method in Manager API config: Fix service configuration update service: Provide a function to query immutability config: Export a function to load service configs Implement service provisioning via dbus test: Add script to test

[PATCH v2 6/6] test: Add script to test manager.ProvisionService method

--- Makefile.am|3 ++- test/provision-service | 28 2 files changed, 30 insertions(+), 1 deletions(-) create mode 100755 test/provision-service diff --git a/Makefile.am b/Makefile.am index 95aefc7..ec034ce 100644 --- a/Makefile.am +++ b/Makefile.am

[PATCH v2 5/6] Implement service provisioning via dbus

--- src/connman.h |1 + src/manager.c | 15 ++ src/service.c | 58 + 3 files changed, 74 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index f00cf75..1198e61 100644 --- a/src/connman.h +++

[PATCH v2 4/6] config: Export a function to load service configs

__connman_config_load_service() function can be used by other parts of ConnMan core to load service configurations, which can later be used for service provisioning. Within config.c, a special field (from_fs) will be used to mark which configurations originate from the filesystem and which do

[PATCH v2 1/6] doc: Add service provisioning method in Manager API

--- doc/manager-api.txt | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/doc/manager-api.txt b/doc/manager-api.txt index f07e185..3fd149c 100644 --- a/doc/manager-api.txt +++ b/doc/manager-api.txt @@ -117,6 +117,17 @@ Methodsdict GetProperties()

[PATCH v3 2/5] service: Add function to set identity

--- src/connman.h |2 ++ src/service.c | 15 +++ 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 01dca1b..122047e 100644 --- a/src/connman.h +++ b/src/connman.h @@ -545,6 +545,8 @@ const char

[PATCH v3 0/5] EAP login support in Agent API

comments that EAP-TLS networks must be fully provisioned v2: - dropped eap- prefix from new Passphrase types, which now are passphrase and response, for EAP passphrases and EAP challenge responses respectively Henri Bragge (5): doc: Add EAP login support in Agent API service: Add function to set

[PATCH v3 1/5] doc: Add EAP login support in Agent API

--- doc/agent-api.txt | 40 1 files changed, 36 insertions(+), 4 deletions(-) diff --git a/doc/agent-api.txt b/doc/agent-api.txt index 98499a3..c9a0b0f 100644 --- a/doc/agent-api.txt +++ b/doc/agent-api.txt @@ -61,10 +61,15 @@ Fields string

Re: [PATCH v2 4/5] agent: Implement EAP identity and passphrase query

Hi Samuel, On Thu, 2011-03-24 at 17:59 +0100, Samuel Ortiz wrote: Hi Henri, On Thu, Mar 17, 2011 at 05:20:45PM +0200, Henri Bragge wrote: EAP credentials will be queried whenever connecting to an 802.1X network unless EAP-TLS is used OR if service is provisioned via .config file

Re: PEAP configuration file

On Wed, 2011-03-23 at 21:49 -0300, Gustavo F. Padovan wrote: Hi Samuel, * Samuel Ortiz sa...@linux.intel.com [2011-03-17 00:12:28 +0100]: Hi Gustavo, On Wed, Mar 16, 2011 at 04:28:21PM -0300, Gustavo F. Padovan wrote: I'm having a similar problem with my university wireless

[PATCH v2 1/5] doc: Add EAP login support in Agent API

--- doc/agent-api.txt | 40 1 files changed, 36 insertions(+), 4 deletions(-) diff --git a/doc/agent-api.txt b/doc/agent-api.txt index 98499a3..c9a0b0f 100644 --- a/doc/agent-api.txt +++ b/doc/agent-api.txt @@ -61,10 +61,15 @@ Fields string

[PATCH v2 0/5] EAP login support in Agent API

Hi, This is v2 of the EAP login support patchset. v2: - dropped eap- prefix from new Passphrase types, which now are passphrase and response, for EAP passphrases and EAP challenge responses respectively Henri Bragge (5): doc: Add EAP login support in Agent API service: Add function

[PATCH v2 4/5] agent: Implement EAP identity and passphrase query

EAP credentials will be queried whenever connecting to an 802.1X network unless EAP-TLS is used OR if service is provisioned via .config file. Besides adding Identity field into the API, this patch also removes the restriction to receive value for only one field per response. Now both Identity

[PATCH v2 2/5] service: Add function to set identity

--- src/connman.h |2 ++ src/service.c | 15 +++ 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 42bf2e6..8275559 100644 --- a/src/connman.h +++ b/src/connman.h @@ -535,6 +535,8 @@ const char

[PATCH v2 3/5] service: Add function to get phase2 method

--- src/connman.h |1 + src/service.c |8 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 8275559..ac81091 100644 --- a/src/connman.h +++ b/src/connman.h @@ -487,6 +487,7 @@ const char *__connman_service_get_path(struct

[PATCH v2 5/5] test: Add identity response support to simple-agent

Support also responding with arbitrary combination of parameters, instead of only one property at a time. --- test/simple-agent | 21 +++-- 1 files changed, 15 insertions(+), 6 deletions(-) diff --git a/test/simple-agent b/test/simple-agent index 5c73599..b0990de 100755 ---

Re: [PATCH v4] ofono: Free network_info

Hi Daniel, On Tue, 2011-03-15 at 15:02 +0100, Daniel Wagner wrote: From: Daniel Wagner daniel.wag...@bmw-carit.de The network_info data structure is not freed. Also the error path does not handle the freeing of the data structure correctly. Works here, thanks for the patch! - Henri

Re: [PATCH v2] doc: Add EAP login support in Agent API

Hi, On Thu, 2011-03-10 at 17:53 +0100, lynxis wrote: On Fri, 2011-02-11 at 13:25 +0100, Samuel Ortiz wrote: Hi Henri, On Thu, Feb 10, 2011 at 04:05:09PM +0200, Henri Bragge wrote: --- How about this? eap- not absolutely necessary prefix for types but I tried to avoid

Re: [PATCH 5/6] Implement service provisioning via dbus

Hi Samuel, On Thu, 2011-03-10 at 01:22 +0100, Samuel Ortiz wrote: Hi Henri, On Thu, Feb 24, 2011 at 04:03:19PM +0200, Henri Bragge wrote: +static DBusMessage *provision_service(DBusConnection *conn, DBusMessage *msg, + void *data) +{ + int err

Re: [PATCH 4/6] config: Export a function to load service configs

Hi Samuel, On Thu, 2011-03-10 at 01:22 +0100, Samuel Ortiz wrote: Hi Henri, On Thu, Feb 24, 2011 at 04:03:18PM +0200, Henri Bragge wrote: __connman_config_load_service function can be used by other parts of ConnMan core to load service configurations, which can later be used

Re: dbus + eap support

Hi, On Wed, 2011-03-09 at 05:38 +0100, lynxis wrote: hey, is connman supporting wpa1/2 eap (peap + mschap2) over dbus ? what need to be done for it ? Currently EAP settings are provided via configuration files as described in doc/config-format.txt. However, I made a proposal to enable

[PATCH v2 0/3] Postpone cellular connections until needed

Hi, The v2 adapts the previous patches to element removal. Henri Bragge (3): Make __connman_network_get_connecting() available for plugins ofono: Do not connect autonomously activated contexts ofono: Connect when context activation is requested include/network.h |1 + plugins/ofono.c

[PATCH 3/3] ofono: Connect when context activation is requested

ConnMan should connect the corresponding network/service after a successful response to context activation request. If the context was already active, connecting has to happen this way instead of waiting for active property going up (it already is up). In case the context was inactive before

[PATCH v2 1/3] Make __connman_network_get_connecting() available for plugins

--- include/network.h |1 + src/connman.h |1 - src/device.c |2 +- src/network.c |2 +- src/service.c |3 +-- 5 files changed, 4 insertions(+), 5 deletions(-) diff --git a/include/network.h b/include/network.h index d898531..a673703 100644 ---

[PATCH 3/3] ofono: Connect when context activation is requested

+static void set_connected(struct network_info *info, + connman_bool_t connected); + static void set_active_reply(DBusPendingCall *call, void *user_data) { char const *path = user_data; @@ -435,7 +438,8 @@ static void set_active_reply(DBusPendingCall *call,

[PATCH v2 3/3] ofono: Connect when context activation is requested

ConnMan should connect the corresponding network/service after a successful response to context activation request. If the context was already active, connecting has to happen this way instead of waiting for active property going up (it already is up). In case the context was inactive before

Re: [PATCH v2 0/3] Postpone cellular connections until needed

On Tue, 2011-03-01 at 17:20 +0200, Henri Bragge wrote: Hi, The v2 adapts the previous patches to element removal. Please ignore the two 3/3 patches without the v2 tag, they are trash. Sorry for my carelessness. - Henri ___ connman mailing list

[PATCH 0/5] EAP login support in Agent API

be asked when connecting to a 802.1X network. Also, both username and password will be asked in every query, not just another. Henri Bragge (5): doc: Add EAP login support in Agent API service: Add function to set identity service: Add function to get phase2 method agent: Implement EAP

[PATCH 2/5] service: Add function to set identity

--- src/connman.h |2 ++ src/service.c | 15 +++ 2 files changed, 17 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 437eaed..f6540af 100644 --- a/src/connman.h +++ b/src/connman.h @@ -536,6 +536,8 @@ const char

[PATCH 1/5] doc: Add EAP login support in Agent API

--- doc/agent-api.txt | 27 +++ 1 files changed, 23 insertions(+), 4 deletions(-) diff --git a/doc/agent-api.txt b/doc/agent-api.txt index 98499a3..fbae242 100644 --- a/doc/agent-api.txt +++ b/doc/agent-api.txt @@ -61,10 +61,15 @@ Fields string Name

[PATCH 5/5] test: Add identity response support to simple-agent

Support also responding with arbitrary combination of parameters, instead of only one property at a time. --- test/simple-agent | 21 +++-- 1 files changed, 15 insertions(+), 6 deletions(-) diff --git a/test/simple-agent b/test/simple-agent index 5c73599..b0990de 100755 ---

[PATCH 4/5] agent: Implement EAP identity and password query

Besides adding Identity field into the API, this patch also removes the restriction to receive value for only one field per response. Now both Identity and Passphrase can be received in one call. --- src/agent.c | 51 +++ src/connman.h |3

Re: [PATCH 1/5] doc: Add EAP login support in Agent API

Hi Marcel, On Tue, 2011-03-01 at 11:39 -0800, Marcel Holtmann wrote: Arguments string Type - Contains the type of a field. For example psk, - wep, ssid, wpspin or plain string. + Contains the type of a field. For example psk, wep

[PATCH 1/6] doc: Add service provisioning method in Manager API

--- doc/manager-api.txt | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/doc/manager-api.txt b/doc/manager-api.txt index 332f6cd..6fb2ccf 100644 --- a/doc/manager-api.txt +++ b/doc/manager-api.txt @@ -117,6 +117,17 @@ Methodsdict GetProperties()

[PATCH 4/6] config: Export a function to load service configs

__connman_config_load_service function can be used by other parts of ConnMan core to load service configurations, which can later be used for service provisioning. Within config.c, a special field (from_fs) will be used to mark which configurations originate from filesystem and which do not. This

[PATCH 5/6] Implement service provisioning via dbus

--- src/connman.h |1 + src/manager.c | 21 + src/service.c | 54 ++ 3 files changed, 76 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 2ea3071..558530b 100644 --- a/src/connman.h +++

[PATCH 3/6] service: Provide a function to query immutability

--- src/connman.h |1 + src/service.c |8 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index f248280..7849f76 100644 --- a/src/connman.h +++ b/src/connman.h @@ -493,6 +493,7 @@ enum connman_service_security

[PATCH 2/3] ofono: Do not connect autonomously activated contexts

When activated context is found, do not connect to it unless requested to do so. --- plugins/ofono.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index ed6317b..92ab9d7 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@

[PATCH 1/3] Make __connman_network_get_connecting() available for plugins

--- include/network.h |1 + src/connman.h |1 - src/device.c |2 +- src/network.c |2 +- src/service.c |3 +-- 5 files changed, 4 insertions(+), 5 deletions(-) diff --git a/include/network.h b/include/network.h index 6b93f16..27979b8 100644 ---

[PATCH 0/3] Postpone cellular connections until needed

). The modifications should not affect the existing GPRS connection support. [1] 6.4.1.2 Default EPS bearer context activation initiated by the network: http://www.etsi.org/deliver/etsi_ts/124300_124399/124301/09.04.00_60/ts_124301v090400p.pdf Henri Bragge (3): Make __connman_network_get_connecting

[PATCH 3/3] ofono: Connect when context activation is requested

ConnMan should connect the corresponding network/service after a successful response to context activation request. If the context was already active, connecting has to happen this way instead of waiting for active property going up (it already is up). In case the context was inactive before

[PATCH] ofono: Fix memory leak in network activation

--- plugins/ofono.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 29aaa61..066e9b7 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -444,7 +444,7 @@ static int set_network_active(struct connman_network *network,

[PATCH] ofono: Fix infinite recursion in network disconnect

--- If association takes too long and connection timeout goes off, then connman will try to disconnect and ends up in infinite recursion when __connman_network_disconnect() and connman_network_set_connected() call each other. Same bug was reported and fixed in wifi plugin too:

Re: [RFC 0/3] Fix handling of provisioned APN

On Wed, 2011-02-16 at 02:07 +0100, Samuel Ortiz wrote: Hi Henri, On Mon, Feb 14, 2011 at 02:50:17PM +0200, Henri Bragge wrote: Hi, This patchset tries to fix handling of APNs that are provisioned in ofono ConnectionContexts rather than written there by connman. After reviewing your

[RFC 0/3] Fix handling of provisioned APN

for ofono plugin, so that it can store APN into service by itself. Should I do it instead? Henri Bragge (3): network: Add new functions to set/get APN Implement functions to set/get APN in network and service ofono: Use new function to set network APN include/network.h |2 ++ plugins/ofono.c

[RFC 1/3] network: Add new functions to set/get APN

--- include/network.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/network.h b/include/network.h index 6b93f16..36c706e 100644 --- a/include/network.h +++ b/include/network.h @@ -104,6 +104,8 @@ int connman_network_set_strength(struct connman_network

[RFC 3/3] ofono: Use new function to set network APN

--- plugins/ofono.c | 24 +--- 1 files changed, 13 insertions(+), 11 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 43872ff..899d3e6 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -456,7 +456,7 @@ static void set_apn(struct connman_network

Re: [PATCH v2] doc: Add EAP login support in Agent API

On Fri, 2011-02-11 at 13:25 +0100, Samuel Ortiz wrote: Hi Henri, On Thu, Feb 10, 2011 at 04:05:09PM +0200, Henri Bragge wrote: --- How about this? eap- not absolutely necessary prefix for types but I tried to avoid any confusion. PATCH v2: - dropped phase2 method, new fields

[PATCH v2] doc: Add EAP login support in Agent API

--- How about this? eap- not absolutely necessary prefix for types but I tried to avoid any confusion. PATCH v2: - dropped phase2 method, new fields types eap-password and eap-response instead PATCH v1: - dropped challenge, renamed phase2 method RFC: - initial revision

[RFC 1/2] doc: Add service provisioning method in Manager API

--- doc/manager-api.txt | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/doc/manager-api.txt b/doc/manager-api.txt index 743ba18..430dec9 100644 --- a/doc/manager-api.txt +++ b/doc/manager-api.txt @@ -117,6 +117,22 @@ Methodsdict GetProperties()

[PATCH 0/3] Add support for EAP/non-EAP phase2 differentiation

will be used. It is users responsibility to use the prefix only with EAP-TTLS. This will be mentioned in the documentation. Henri Bragge (3): supplicant: Support EAP/non-EAP differentiation in phase2 authentication methods gsupplicant: Support EAP/non-EAP differentiation in phase2 authentication

[PATCH resend 0/3] Fix EAP phase2-authentication issues

-format.txt should now work properly. Might be related to BMC#2588. Henri Bragge (3): supplicant: Drop unnecessary quotes from phase2 value gsupplicant: Drop unnecessary quotes from phase2 value gsupplicant: Use the prefixed version of phase2_auth value gsupplicant/supplicant.c |4

[PATCH resend 1/3] supplicant: Drop unnecessary quotes from phase2 value

--- plugins/supplicant.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/supplicant.c b/plugins/supplicant.c index 5f2d204..8248f85 100644 --- a/plugins/supplicant.c +++ b/plugins/supplicant.c @@ -1205,7 +1205,7 @@ static int set_network_peap(struct

[PATCH 1/3] supplicant: Drop unnecessary quotes from phase2 value

--- plugins/supplicant.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/supplicant.c b/plugins/supplicant.c index 5f2d204..8248f85 100644 --- a/plugins/supplicant.c +++ b/plugins/supplicant.c @@ -1205,7 +1205,7 @@ static int set_network_peap(struct

[PATCH 0/3] Fix EAP phase2-authentication issues

Here are few small fixes that I needed to make in order to pass functional phase2-values (inner EAP methods) to wpa_supplicant. EAP scenarios explained in doc/config-format.txt should now work properly. Might be related to BMC#2588. Henri Bragge (3): supplicant: Drop unnecessary quotes from

[PATCH 2/3] gsupplicant: Drop unnecessary quotes from phase2 value

--- gsupplicant/supplicant.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c index 934ad1c..15642e8 100644 --- a/gsupplicant/supplicant.c +++ b/gsupplicant/supplicant.c @@ -2301,7 +2301,7 @@ static void

[PATCH v3 0/2] Add support for multiple search domains

with separate calls. Search domains are stored in nameserver entry list inside resolver module, one domain per entry (with nameserver value NULL). Stored domains are exported into resolv.conf behind search keyword, maximum amount of them defined by MAXDNSRCH. Henri Bragge (2): dnsproxy: Ignore adding

[PATCH v3 1/2] dnsproxy: Ignore adding and removing of NULL servers

--- plugins/dnsproxy.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/plugins/dnsproxy.c b/plugins/dnsproxy.c index 9deeb96..8ffbc5c 100644 --- a/plugins/dnsproxy.c +++ b/plugins/dnsproxy.c @@ -776,6 +776,9 @@ static int dnsproxy_append(const char *interface, const

[PATCH v3 2/2] Add support for multiple search domains

Domains are appended to entry list just like nameservers, and finally exported to /etc/resolv.conf. Domains are written to resolv.conf in reverse order so that the most recently appended domain will have the highest priority. Search domains should only be useful for resolvfile_resolver and should

[PATCH] Add support for multiple search domains

Domains are appended to entry list just like nameservers, and finally exported to /etc/resolv.conf. Domains are written to resolv.conf in reverse order so that the most recently appended domain will have the highest priority. --- src/resolver.c | 33 +++--

[PATCH] Add support for multiple search domains

and inserts the given one. Henri Bragge (1): Add support for multiple search domains src/resolver.c | 33 +++-- src/service.c | 42 -- 2 files changed, 59 insertions(+), 16 deletions