Re: [PATCH] iptables: iptables_replace returns the wrong error code

2013-10-28 Thread Patrik Flykt
On Thu, 2013-10-24 at 07:29 -0400, Tysen Moore wrote: I have a case where the init_firewall() is failing. After some digging I've found that iptables_replace() is failing. My assumption here is that iptables_replace() is returning the wrong error code, it should be returning errno. My

Re: [PATCH] iptables: iptables_replace returns the wrong error code

2013-10-28 Thread Tysen Moore
This removes the use of spaces, I verified the rest is tabbed. diff --git a/src/iptables.c b/src/iptables.c index 49434be..f73f134 100644 --- a/src/iptables.c +++ b/src/iptables.c @@ -1380,18 +1380,27 @@ static void dump_ipt_replace(struct ipt_replace *repl) static int

Re: [PATCH] iptables: iptables_replace returns the wrong error code

2013-10-28 Thread Patrik Flykt
On Mon, 2013-10-28 at 06:53 -0400, Tysen Moore wrote: This removes the use of spaces, I verified the rest is tabbed. I'd say this is not the intended commit message. Please send a new message with a proper subject prefix including a version number (git format-patch --subject-prefix=PATCH v3

Re: [PATCH] iptables: iptables_replace returns the wrong error code

2013-10-25 Thread Daniel Wagner
Hi Tysen, On 10/24/2013 12:29 PM, Tysen Moore wrote: I have a case where the init_firewall() is failing. After some digging I've found that iptables_replace() is failing. My assumption here is that iptables_replace() is returning the wrong error code, it should be returning errno. My

Re: [PATCH] iptables: iptables_replace returns the wrong error code

2013-10-25 Thread Marcel Holtmann
Hi Daniel, I have a case where the init_firewall() is failing. After some digging I've found that iptables_replace() is failing. My assumption here is that iptables_replace() is returning the wrong error code, it should be returning errno. My assumption is based on the caller

[PATCH] iptables: iptables_replace returns the wrong error code

2013-10-24 Thread Tysen Moore
I have a case where the init_firewall() is failing. After some digging I've found that iptables_replace() is failing. My assumption here is that iptables_replace() is returning the wrong error code, it should be returning errno. My assumption is based on the caller __connman_firewall_enable()