Re: [ofono-online-v2 2/6] Log more of the ofono errors.

2010-08-19 Thread Samuel Ortiz
On Wed, Aug 18, 2010 at 07:16:51PM +0300, Pekka Pessi wrote: > Hi Samuel, > > >> +             connman_error("%s(\"%s\"): %s: %s", "SetProperty", "Active", > >> +                             error.name, error.message); > > Hmm, why not: > > +             connman_error("SetProperty(Active) %s %s",

Re: [ofono-online-v2 2/6] Log more of the ofono errors.

2010-08-18 Thread Pekka Pessi
Hi Samuel, >> +             connman_error("%s(\"%s\"): %s: %s", "SetProperty", "Active", >> +                             error.name, error.message); > Hmm, why not: > +             connman_error("SetProperty(Active) %s %s", > +                             error.name, error.message) > > then ? I

Re: [ofono-online-v2 2/6] Log more of the ofono errors.

2010-08-17 Thread Samuel Ortiz
Hi Pekka, On Mon, Aug 16, 2010 at 05:40:57PM +0300, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > --- > plugins/ofono.c | 34 +- > 1 files changed, 29 insertions(+), 5 deletions(-) > > diff --git a/plugins/ofono.c b/plugins/ofono.c > index 8254b56..b15e

[ofono-online-v2 2/6] Log more of the ofono errors.

2010-08-16 Thread Pekka . Pessi
From: Pekka Pessi --- plugins/ofono.c | 34 +- 1 files changed, 29 insertions(+), 5 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index 8254b56..b15e1f5 100644 --- a/plugins/ofono.c +++ b/plugins/ofono.c @@ -92,8 +92,8 @@ static void set_property_