Hi Pekka,
On Mon, Aug 16, 2010 at 05:40:57PM +0300, [email protected] wrote:
> From: Pekka Pessi <[email protected]>
>
> ---
> plugins/ofono.c | 34 +++++++++++++++++++++++++++++-----
> 1 files changed, 29 insertions(+), 5 deletions(-)
>
> diff --git a/plugins/ofono.c b/plugins/ofono.c
> index 8254b56..b15e1f5 100644
> --- a/plugins/ofono.c
> +++ b/plugins/ofono.c
> @@ -92,8 +92,8 @@ static void set_property_reply(DBusPendingCall *call, void
> *user_data)
> reply = dbus_pending_call_steal_reply(call);
>
> if (dbus_set_error_from_message(&error, reply)) {
> - connman_error("SetProperty(\"%s\"): %s", name,
> - error.message);
> + connman_error("%s(\"%s\"): %s: %s", "SetProperty", name,
> + error.name, error.message);
As explained with your first patch review, we don't use ':' in our error
messages.
> dbus_error_free(&error);
> }
>
> @@ -314,7 +314,7 @@ static void set_network_name(struct connman_network
> *network)
>
> if (dbus_connection_send_with_reply(connection, message,
> &call, TIMEOUT) == FALSE) {
> - connman_error("Failed to get operator");
> + connman_error("Failed to get operator name");
> goto done;
> }
>
> @@ -550,7 +550,8 @@ static void set_active_reply(DBusPendingCall *call, void
> *user_data)
>
> pending_network = NULL;
>
> - connman_error("%s", error.message);
> + connman_error("%s(\"%s\"): %s: %s", "SetProperty", "Active",
> + error.name, error.message);
Hmm, why not:
+ connman_error("SetProperty(Active) %s %s",
+ error.name, error.message)
then ?
>
> dbus_error_free(&error);
> } else
> @@ -714,7 +715,8 @@ static void create_context_reply(DBusPendingCall *call,
> void *user_data)
> reply = dbus_pending_call_steal_reply(call);
>
> if (dbus_set_error_from_message(&error, reply)) {
> - connman_error("%s", error.message);
> + connman_error("%s(): %s: %s", CREATE_CONTEXT,
> + error.name, error.message);
Ditto.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
