Re: [PATCH v5 05/13] timeserver: Add service gateway to timeserver list

Hi Alok, On 04/03/2012 11:50 PM, Alok Barsode wrote: From: Alok Barsodealok.bars...@linux.intel.com Add default service Gateway to the timeserver query list. Now the list is service timeservers(via DHCP), gateway and global timeservers, in that order. --- src/timeserver.c | 33

Re: [PATCH v5 12/13] timeservers: Add Fallback Timerservers

Hi Alok, Hi Alok, On 04/03/2012 11:51 PM, Alok Barsode wrote: From: Alok Barsodealok.bars...@linux.intel.com Add Fallback timeservers via main.conf. These timeservers are used for time corrections when there are no valid timeservers provided by the user or by the network. The list of

Re: Problem while trying to implement the set-address test application in native code using dbus C api.

Hi Stavros, On 04/03/2012 05:12 PM, Stavros Vagionitis wrote: Hi all, I am trying to expand a little the functionality of the client that exists on the client folder. I have added some functions that are used by the test-connman and connect-service python scripts. Now I am trying to put the

[PATCH v3 00/11] VPN split routing

: ca.cert, OpenVPN.Cert: foobar.cert, OpenVPN.Key: foobar.key})) Cheers, Jukka Jukka Rissanen (11): provider: Add support for user defined routes provider: Save and load user specified routes provider: Allow user to set

[PATCH v3 04/11] provider: Check if there are any routes for the provider

--- src/connman.h |1 + src/provider.c | 17 + 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 556b9e1..e97f856 100644 --- a/src/connman.h +++ b/src/connman.h @@ -498,6 +498,7 @@ int __connman_private_network_release(const

[PATCH v3 05/11] service: Allow user to do split routing for VPN services

The split routing is done when user moves the services and it is only done if there are routes defined for that specific VPN provider. --- src/service.c | 36 ++-- 1 files changed, 30 insertions(+), 6 deletions(-) diff --git a/src/service.c b/src/service.c index

[PATCH v3 06/11] service: Save/load split routing information for VPN

--- src/service.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/service.c b/src/service.c index 12b86ab..52b705e 100644 --- a/src/service.c +++ b/src/service.c @@ -297,9 +297,12 @@ static int service_load(struct connman_service *service) case

[PATCH 0/3] Memory leaks in timeserver

Hi, valgrind reported some memory leaks in timeserver code. Cheers, Jukka Jukka Rissanen (3): timeserver: Timeserver array was not freed timeserver: Fallback array was not freed timeserver: Nameserver array was not freed src/timeserver.c | 10 +- 1 files changed, 9

[PATCH 1/3] timeserver: Timeserver array was not freed

--- src/timeserver.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/timeserver.c b/src/timeserver.c index e8a9d15..2fcdb94 100644 --- a/src/timeserver.c +++ b/src/timeserver.c @@ -228,6 +228,8 @@ int __connman_timeserver_sync(struct connman_service

[PATCH 2/3] timeserver: Fallback array was not freed

--- src/timeserver.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/timeserver.c b/src/timeserver.c index 2fcdb94..fedcbca 100644 --- a/src/timeserver.c +++ b/src/timeserver.c @@ -236,6 +236,8 @@ int __connman_timeserver_sync(struct connman_service

[PATCH 3/3] timeserver: Nameserver array was not freed

--- src/timeserver.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/timeserver.c b/src/timeserver.c index fedcbca..793804c 100644 --- a/src/timeserver.c +++ b/src/timeserver.c @@ -276,8 +276,10 @@ static int timeserver_start(struct connman_service *service)

Re: [PATCH 2/3] timeserver: Fallback array was not freed

On 04/10/2012 10:28 AM, Jukka Rissanen wrote: --- src/timeserver.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/timeserver.c b/src/timeserver.c index 2fcdb94..fedcbca 100644 --- a/src/timeserver.c +++ b/src/timeserver.c @@ -236,6 +236,8 @@ int

Re: [PATCH 2/4] main: Implement 'FallbackNameservers' main.conf option

Hi Patrik, On 04/10/2012 03:25 PM, patrik.fl...@linux.intel.com wrote: From: Patrik Flyktpatrik.fl...@linux.intel.com Implement 'FallbackNameservers' main.conf configuration file option. While parsing the list of nameservers, use only the ones in numeric format. --- src/main.c | 45

Re: [PATCH 2/4] main: Implement 'FallbackNameservers' main.conf option

Hi Patrik, On 04/10/2012 03:25 PM, patrik.fl...@linux.intel.com wrote: From: Patrik Flyktpatrik.fl...@linux.intel.com Implement 'FallbackNameservers' main.conf configuration file option. While parsing the list of nameservers, use only the ones in numeric format. --- src/main.c | 45

Re: [PATCH v2 0/8] Implementation of PreferredTechnologies

Hi Patrik, ACK from me. Could one of these patchsets (DefaultAutoConnectTechnologies, PreferredTechnologies or FallbackNameservers) document the main.conf file contents and format? Cheers, Jukka On 04/05/2012 10:38 PM, patrik.fl...@linux.intel.com wrote: From: Patrik

Re: [PATCH v2 0/4] Implement DefaultAutoConnectTechnologies

Hi Patrik, patchset looks good, ACK from me. Cheers, Jukka On 04/05/2012 10:38 PM, patrik.fl...@linux.intel.com wrote: From: Patrik Flyktpatrik.fl...@linux.intel.com Hi, The second version of this patch set is rebased on latest upstream. DefaultAutoConnectTechnologies main.conf

Re: [RFC v0 2/3] service: Ignore network withouth device when reconnecting

Hi Daniel, On 04/11/2012 11:19 AM, Daniel Wagner wrote: On 05.04.2012 15:04, Daniel Wagner wrote: From: Daniel Wagnerdaniel.wag...@bmw-carit.de --- src/service.c |5 + 1 file changed, 5 insertions(+) diff --git a/src/service.c b/src/service.c index 36140f9..6be617f 100644 ---

[PATCH] config: Warn user if no configuration is found

This is useful so that user gets information that he needs to fix the config file. --- Hi, I was doing some wpa eap testing and created a config file for that. Unfortunately the config file I created had an error, then connmand read the file but ignored it silently. This patch prints a warning if

[PATCH] service: Default service notifier is called too many times

The default service notifier is invoked even when the default service has not been changed. This causes unnecessary dbus signal traffic. Fixes BMC#25030 --- src/service.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/service.c b/src/service.c index

Re: [RFC v1] notifier: Distinguish between different states

Hi Daniel, On 04/17/2012 04:17 PM, Daniel Wagner wrote: From: Daniel Wagnerdaniel.wag...@bmw-carit.de Instead of only having offline and online states, we support now having offline, idle, ready and online as on the Manager.State documenation update required. --- src/notifier.c | 65

[PATCH] pacrunner: Memory leak in dbus container

Valgrind reported memory leak here. The dbus message container must be not left open because it has allocated resources so we close the container before returning. --- plugins/pacrunner.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/plugins/pacrunner.c

[PATCH] service: Changing default service was not correctly checked

Let the default_changed() function check whether the default service is really changed as it is doing it correctly every time. The extra check in the __connman_service_indicate_default() function is causing problems if the user is moving services around. Then we might be using the old DNS service

[PATCH] service: Save new service data only after successful connect

The data for new service was saved into disk (with Favorite=false) even if the first connection failed. This is now changed and service data is only saved if user has been able to connect to a service at least once. --- src/service.c | 33 ++--- 1 files changed, 30

[PATCH] agent: Memory leak in passphrase reply

The pending call was not unreffed. --- src/agent.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/agent.c b/src/agent.c index e3433c8..b87f4e8 100644 --- a/src/agent.c +++ b/src/agent.c @@ -180,6 +180,7 @@ done:

[PATCH v2] service: Save new service data only after successful connect

The data for new service was saved into disk (with Favorite=false) even if the first connection failed. This is now changed and service data is only saved if user has been able to connect to a service at least once. --- Hi, v2 contains only indentation change. Cheers, Jukka src/service.c |

[PATCH] resolver: Use proper IPv6 source address when sending DNS queries

This will fix is for following scenario: - New interface is coming up. - There is radvd in the connected network and it is advertising IPv6 addresses and DNS servers. - Kernel receives router advertisement and picks up the DNS server information which is then routed via netlink to

Re: [PATCH] resolver: Use proper IPv6 source address when sending DNS queries

On 04/24/2012 02:00 PM, Jukka Rissanen wrote: + + if (family == AF_INET6) { + /* +* Re-create RDNSS configured servers if there are any +* for this interface. This is done because we might +* have now properly configured

[PATCH v2] resolver: Use proper IPv6 source address when sending DNS queries

This fix is for following scenario: - New interface is coming up. - There is radvd in the connected network and it is advertising IPv6 addresses and DNS servers. - Kernel receives router advertisement and picks up the DNS server information which is then routed via netlink to

[PATCH] dnsproxy: Delay cache removal

The idea here is to delay cache removal few seconds if there are no cache users any more (refcount goes to 0). This is useful for IPv6 RDNSS where new DNS servers are created right after old one is removed. In this case we do not want to loose the cache that still has perfectly valid data. --- Hi,

[PATCH] ipconfig: Do not tweak IPv6 status of ignored devices

--- Hi, this needs some more testing before committing. Cheers, Jukka src/ipconfig.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/ipconfig.c b/src/ipconfig.c index af5666d..8dc0a59 100644 --- a/src/ipconfig.c +++ b/src/ipconfig.c @@ -555,8 +555,10 @@ static

[PATCH] service: Allow connection if there are interfaces available

Allow user to initiate connection if there are multiple devices of the same technology type available (like having multiple wifi cards). --- Hi, I have been testing connman with two wifi cards and it is very annoying that if the connection attempt hangs or takes very long time, I cannot connect

Re: OpenVPN woes again

Hi Daniel, On 04/26/2012 03:08 PM, Daniel Wagner wrote: [wagi@freakazoid connman]$ route -n Kernel IP routing table Destination Gateway Genmask Flags Metric RefUse Iface 0.0.0.0 10.1.0.50.0.0.0 UG0 00 vpn0 10.1.0.110.1.0.5

[PATCH] connection: Set host route to VPN server

This is needed so that we can access hosts behind the VPN. The route might already be setup if VPN server is the same as nameserver or similar. --- Hi, this should add the missing OpenVPN route that Daniel reported. I noticed that I had the route automagically setup in my test network, but that

Re: Ethernet wont connect by default in 0.82

On 04/27/2012 12:14 PM, Marcel Holtmann wrote: Hi Ian, We are using connman on a thin client computer. For us we assume Ethernet is on by default and the user can select wireless later. Having it enabled by default saves me one step in image creation. That being said for a tablet or a

[PATCH 1/5] technology: Enable ethernet by default

Ethernet is enabled by default if settings file is not found or the Wired entry is not found in the file. --- src/technology.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/technology.c b/src/technology.c index 27ada40..c523182 100644 ---

[PATCH 0/5] Enable ethernet by default

default.profile. This is needed so that all default values can be set in technology.c The #4 saves the individual technology state if it is missing in settings file. The #5 creates the settings file in technology init if necessary. Cheers, Jukka Jukka Rissanen (5): technology: Enable ethernet

[PATCH 3/5] main: Create settings file only when migrating

The settings file is created only when migrating from default.profile. This means that technology default values are used if settings file does not exists. --- src/storage.c | 34 +++--- 1 files changed, 7 insertions(+), 27 deletions(-) diff --git a/src/storage.c

[PATCH 2/5] technology: Offline mode is OFF by default

By defalt offline mode is OFF if settings file is not found or OfflineMode entry is not found in settings file. --- src/technology.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/technology.c b/src/technology.c index c523182..26a4cc9 100644 --- a/src/technology.c

[PATCH 4/5] technology: Save technology state if entry is missing from file

So we save the technology status if the settings file does not contain it. --- src/technology.c | 58 +++-- 1 files changed, 30 insertions(+), 28 deletions(-) diff --git a/src/technology.c b/src/technology.c index 26a4cc9..9892e2b 100644 ---

[PATCH 5/5] technology: Create the settings file in init

We save offline mode status in init so that settings file gets created if it was missing. --- src/technology.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/technology.c b/src/technology.c index 9892e2b..c52c910 100644 --- a/src/technology.c +++ b/src/technology.c

Re: [PATCH 3/5] main: Create settings file only when migrating

Hmm, naturally the subject should say storage: Create settings file only when migrating here and not talk about main: On 04/27/2012 04:01 PM, Jukka Rissanen wrote: The settings file is created only when migrating from default.profile. This means that technology default values are used

[PATCH] wifi: Plugin internal variable was not static

--- plugins/wifi.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index fb70b57..6e6bbca 100644 --- a/plugins/wifi.c +++ b/plugins/wifi.c @@ -61,7 +61,7 @@ #define BGSCAN_DEFAULT simple:30:-45:300 #define AUTOSCAN_DEFAULT

[PATCH] wispr: Possible memory leak in error case

--- src/wispr.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/wispr.c b/src/wispr.c index 2126197..034cced 100644 --- a/src/wispr.c +++ b/src/wispr.c @@ -463,8 +463,10 @@ static gboolean wispr_route_request(const char *address, int ai_family,

[PATCH] wispr: Use g_strdup() instead of strdup()

Valgrind reports following error if strdup() is used here: ==12572== Invalid read of size 4 ==12572==at 0x429113B: ??? (in /lib/libc-2.11.90.so) ==12572==by 0x80A8154: wispr_route_request (wispr.c:471) ==12572==by 0x805CA4F: resolv_result (gweb.c:449) ==12572==by 0x805DD4B:

[PATCH 0/5] Autoconnect to hidden wifi service

that is set by patches #2, #3 and #4. Patch #5 allows the autoscan feature in wifi.c to do active scan of all saved hidden wifi services. This enables the service then to autoconnect to these hidden services. Cheers, Jukka Jukka Rissanen (5): wifi: Allow max number of scan entries service

[PATCH 1/5] wifi: Allow max number of scan entries

Do no limit the scan entries to 4 (G_SUPPLICANT_MAX_FAST_SCAN) but use the limit given by the driver. The limit is given by wpa_s. --- gsupplicant/gsupplicant.h | 22 +++- gsupplicant/supplicant.c | 16 +++- plugins/wifi.c| 59

[PATCH 3/5] service: Save/load service hidden status

--- src/service.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/service.c b/src/service.c index fcd64ce..8af07d0 100644 --- a/src/service.c +++ b/src/service.c @@ -487,6 +487,9 @@ static int service_load(struct connman_service *service)

[PATCH 2/5] service: Add flag that tells if the service is hidden or not

--- src/connman.h |1 + src/service.c |9 + 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 550107c..8e4af36 100644 --- a/src/connman.h +++ b/src/connman.h @@ -643,6 +643,7 @@ void __connman_service_set_pac(struct connman_service

[PATCH 4/5] network: Mark service as hidden after successfull connect

We must remember wifi service hidden status so that we can do active scan of its SSID and then autoconnect to it. --- src/network.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/network.c b/src/network.c index f729e78..fd3cbea 100644 --- a/src/network.c +++

[PATCH 5/5] wifi: Automatically scan hidden wifi services

This enables service to autoconnect to hidden wifi service. Fixes BMC#11860 --- plugins/wifi.c | 270 +--- 1 files changed, 200 insertions(+), 70 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index 2f1f7a6..1dfbc44 100644 ---

[PATCH] loopback: Check hostname/domainname to contain only valid chars

--- plugins/loopback.c | 70 +--- 1 files changed, 66 insertions(+), 4 deletions(-) diff --git a/plugins/loopback.c b/plugins/loopback.c index 1800c49..cba923c 100644 --- a/plugins/loopback.c +++ b/plugins/loopback.c @@ -32,6 +32,7 @@ #include

[PATCH 0/2] Only accept netlink messages sent by kernel

Hi, these patches make sure that we accept only netlink messages that are sent by kernel. Cheers, Jukka Jukka Rissanen (2): rtnl: Make sure that we only accept netlink messages from kernel inet: Make sure that we only accept netlink messages from kernel src/inet.c | 30

[PATCH 1/2] rtnl: Make sure that we only accept netlink messages from kernel

--- src/rtnl.c | 37 - 1 files changed, 24 insertions(+), 13 deletions(-) diff --git a/src/rtnl.c b/src/rtnl.c index 3cd6c4b..e53f5e8 100644 --- a/src/rtnl.c +++ b/src/rtnl.c @@ -1368,10 +1368,11 @@ static void rtnl_message(void *buf, size_t len)

[PATCH 2/2] inet: Make sure that we only accept netlink messages from kernel

--- src/inet.c | 30 -- 1 files changed, 20 insertions(+), 10 deletions(-) diff --git a/src/inet.c b/src/inet.c index a0f6971..e01bfb3 100644 --- a/src/inet.c +++ b/src/inet.c @@ -1991,27 +1991,37 @@ static int inet_rtnl_recv(GIOChannel *chan, gpointer user_data)

[PATCH v2 2/2] loopback: Check hostname/domainname validity

--- plugins/loopback.c | 23 +++ 1 files changed, 19 insertions(+), 4 deletions(-) diff --git a/plugins/loopback.c b/plugins/loopback.c index 1800c49..a111eee 100644 --- a/plugins/loopback.c +++ b/plugins/loopback.c @@ -39,6 +39,7 @@ #include connman/plugin.h #include

[PATCH v2 1/2] inet: Added function that checks if the hostname is valid

--- include/inet.h |1 + src/inet.c | 48 2 files changed, 49 insertions(+), 0 deletions(-) diff --git a/include/inet.h b/include/inet.h index 2048de1..aa67573 100644 --- a/include/inet.h +++ b/include/inet.h @@ -80,6 +80,7 @@ int

[PATCH v2 1/5] wifi: Allow max number of scan entries

Do no limit the scan entries to 4 (G_SUPPLICANT_MAX_FAST_SCAN) but use the limit given by the driver. The limit is given by wpa_s. If the supplicant does not return the limit, then use 4 as a max value. --- gsupplicant/gsupplicant.h | 31 ++- gsupplicant/supplicant.c | 19

[PATCH v2 0/5] Autoconnect to hidden wifi service

Hi, this v2 fixes possible memory leak in error case and also sets the limit of SSIDs to be scanned to 4 if the limit is not returned by wpa_supplicant. Cheers, Jukka Jukka Rissanen (5): wifi: Allow max number of scan entries service: Add flag that tells if the service is hidden

[PATCH v2 2/5] service: Add flag that tells if the service is hidden or not

--- src/connman.h |1 + src/service.c |9 + 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 550107c..8e4af36 100644 --- a/src/connman.h +++ b/src/connman.h @@ -643,6 +643,7 @@ void __connman_service_set_pac(struct connman_service

[PATCH v2 3/5] service: Save/load service hidden status

--- src/service.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/service.c b/src/service.c index fcd64ce..8af07d0 100644 --- a/src/service.c +++ b/src/service.c @@ -487,6 +487,9 @@ static int service_load(struct connman_service *service)

[PATCH v2 4/5] network: Mark service as hidden after successfull connect

We must remember wifi service hidden status so that we can do active scan of its SSID and then autoconnect to it. --- src/network.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/network.c b/src/network.c index f729e78..fd3cbea 100644 --- a/src/network.c +++

[PATCH v2 5/5] wifi: Automatically scan hidden wifi services

This enables service to autoconnect to hidden wifi service. Fixes BMC#11860 --- plugins/wifi.c | 257 --- 1 files changed, 187 insertions(+), 70 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index 2f1f7a6..ef096bd 100644 ---

[PATCH 0/3] Misc DHCPv6 fixes

in error case. Patch #2 refactors timer clearing code so that it is easier to use by patch #3. Patch #3 clears the timer in error case so that we do not have any stale pointer issues. Cheers, Jukka Jukka Rissanen (3): dhcpv6: Possible memory leak dhcpv6: Refactor timer clearing dhcpv6

[PATCH 1/3] dhcpv6: Possible memory leak

--- src/dhcpv6.c | 16 1 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/dhcpv6.c b/src/dhcpv6.c index 9b15e6a..1d1feb2 100644 --- a/src/dhcpv6.c +++ b/src/dhcpv6.c @@ -342,12 +342,16 @@ static int dhcpv6_info_request(struct connman_dhcpv6 *dhcp)

[PATCH 2/3] dhcpv6: Refactor timer clearing

--- src/dhcpv6.c | 33 + 1 files changed, 13 insertions(+), 20 deletions(-) diff --git a/src/dhcpv6.c b/src/dhcpv6.c index 1d1feb2..5d09799 100644 --- a/src/dhcpv6.c +++ b/src/dhcpv6.c @@ -74,6 +74,14 @@ static GHashTable *network_table; static int

[PATCH 3/3] dhcpv6: Remove timer properly in error cases

Needed so that we do not access stale pointers from timer handler. --- src/dhcpv6.c | 12 ++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/dhcpv6.c b/src/dhcpv6.c index 5d09799..bf764c8 100644 --- a/src/dhcpv6.c +++ b/src/dhcpv6.c @@ -343,20 +343,24 @@ static int

[PATCH v3 0/6] Autoconnect to hidden wifi service

Hi, this v3 rebases patch #4 so that it can be applied. I also split the last patch into two pieces so that they are more readable. Cheers, Jukka Jukka Rissanen (6): wifi: Allow max number of scan entries service: Add flag that tells if the service is hidden or not service: Save/load

[PATCH v3 1/6] wifi: Allow max number of scan entries

Do no limit the scan entries to 4 (G_SUPPLICANT_MAX_FAST_SCAN) but use the limit given by the driver. The limit is given by wpa_s. If the supplicant does not return the limit, then use 4 as a max value. --- gsupplicant/gsupplicant.h | 31 ++- gsupplicant/supplicant.c | 19

[PATCH v3 2/6] service: Add flag that tells if the service is hidden or not

--- src/connman.h |1 + src/service.c |9 + 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/connman.h b/src/connman.h index 90d1e1f..734213d 100644 --- a/src/connman.h +++ b/src/connman.h @@ -645,6 +645,7 @@ void __connman_service_set_pac(struct connman_service

[PATCH v3 3/6] service: Save/load service hidden status

--- src/service.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/service.c b/src/service.c index f8cdff8..9e52dd3 100644 --- a/src/service.c +++ b/src/service.c @@ -487,6 +487,9 @@ static int service_load(struct connman_service *service)

[PATCH v3 4/6] network: Mark service as hidden after successfull connect

We must remember wifi service hidden status so that we can do active scan of its SSID and then autoconnect to it. --- src/network.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/network.c b/src/network.c index 55c49f1..10f1bf3 100644 --- a/src/network.c +++

[PATCH v3 5/6] wifi: Refactor code

Move add_scan_param() to start of the file for the next patch. --- plugins/wifi.c | 138 1 files changed, 69 insertions(+), 69 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index 2f1f7a6..d2f6799 100644 --- a/plugins/wifi.c

[PATCH v3 6/6] wifi: Automatically scan hidden wifi services

This enables service to autoconnect to hidden wifi service. Fixes BMC#11860 --- plugins/wifi.c | 115 +++- 1 files changed, 114 insertions(+), 1 deletions(-) diff --git a/plugins/wifi.c b/plugins/wifi.c index d2f6799..a88835a 100644 ---

[PATCH] agent: Memory leak in error reply

The pending call was not unreffed. --- src/agent.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/agent.c b/src/agent.c index 33a11ec..feeb48e 100644 --- a/src/agent.c +++ b/src/agent.c @@ -632,6 +632,7 @@ static void report_error_reply(DBusPendingCall *call, void

[PATCH] test: Show autoconnect and state in services list

Show the autoconnect A and state Ready or Online indicators in the services list. --- test/test-connman | 15 ++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/test/test-connman b/test/test-connman index 473af62..67b0c85 100755 --- a/test/test-connman +++

Re: [PATCH] connection: Fix host route to VPN server

Hi Daniel, I could not test the cellular + VPN combination but at least this one did not break the non P-t-P VPN case so ACK from me. Cheers, Jukka On 05/07/2012 06:31 PM, Daniel Wagner wrote: From: Daniel Wagnerdaniel.wag...@bmw-carit.de The kernel will ignore host routes which are

Re: [PATCH] connection.c: Fix possible NULL dereference __connman_connection_gateway_add

Hi Adrien, ACK with modifications to the subject, should probably say something like connection: Fix possible NULL dereference Cheers, Jukka On 05/08/2012 05:26 PM, Adrien Bustany wrote: From: Adrien Bustanyadrien.bust...@nokia.com --- src/connection.c | 34

[PATCH] connection: Refactor VPN route setup

--- Hi, this patch refactors the __connman_connection_gateway_add() function because it looks quite complicated atm. The VPN route setup is now only in one function set_vpn_routes(). Because the diff looks quite a mess so it might be easier to review is applied first. Cheers, Jukka

[PATCH 2/3] dhcpv6: Check NULL pointer dereference

--- src/dhcpv6.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/dhcpv6.c b/src/dhcpv6.c index bf764c8..7d89bf7 100644 --- a/src/dhcpv6.c +++ b/src/dhcpv6.c @@ -291,7 +291,8 @@ static void info_req_cb(GDHCPClient *dhcp_client, gpointer user_data)

[PATCH 0/3] Misc dhcp fixes

to use g_list_length() instead of traversing the list manually. Cheers, Jukka Jukka Rissanen (3): dhcp: Check NULL pointer dereference dhcpv6: Check NULL pointer dereference dhcp: Use g_list_length() to calculate the list length src/dhcp.c | 12 ++-- src/dhcpv6.c |6

[PATCH 3/3] dhcp: Use g_list_length() to calculate the list length

--- src/dhcp.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/dhcp.c b/src/dhcp.c index 22eca60..f4de736 100644 --- a/src/dhcp.c +++ b/src/dhcp.c @@ -244,8 +244,7 @@ static void lease_available_cb(GDHCPClient *dhcp_client, gpointer user_data)

[PATCH 1/3] dhcp: Check NULL pointer dereference

--- src/dhcp.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/dhcp.c b/src/dhcp.c index b267074..22eca60 100644 --- a/src/dhcp.c +++ b/src/dhcp.c @@ -294,7 +294,8 @@ static void lease_available_cb(GDHCPClient *dhcp_client, gpointer user_data)

Re: Wifi won't connect

Hi On 05/10/2012 01:53 PM, Tomasz Bursztyka wrote: Hi, configuring at run time through scripts (unless you are running connman in a box on which you did not plug any input device, display... But then connman is not really thought to work that way) That is exactly what I plan to do. I want a

Re: Wifi won't connect

On 05/10/2012 02:20 PM, Tomasz Bursztyka wrote: Le 10/05/2012 14:11, Jukka Rissanen a écrit : Hi On 05/10/2012 01:53 PM, Tomasz Bursztyka wrote: Hi, configuring at run time through scripts (unless you are running connman in a box on which you did not plug any input device, display

[PATCH] gdhcp: Message type is required in DHCPv4

--- gdhcp/client.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/client.c index c308b83..a51857f 100644 --- a/gdhcp/client.c +++ b/gdhcp/client.c @@ -1897,8 +1897,11 @@ static gboolean listener_event(GIOChannel *channel, GIOCondition

[PATCH] gdhcp: Make sure we have the message before accessing it

--- gdhcp/client.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/gdhcp/client.c b/gdhcp/client.c index a51857f..ec1b2a2 100644 --- a/gdhcp/client.c +++ b/gdhcp/client.c @@ -1865,6 +1865,9 @@ static gboolean listener_event(GIOChannel *channel, GIOCondition condition,

Re: Static analysis errors [fixed]

Hi Henrique, some comments: Dead store Dead assignment src /rtnl.c 837 1 View Report False positive. Debugging print is disabled, probably will not be changed. Dead store Dead assignment tools /wispr.c 355 1 View Report False positive. If we remove the

[PATCH 0/4] Handle DNSSL RA option properly

the code so that we do not try to get the service if server is not set. Cheers, Jukka Jukka Rissanen (4): resolver: Follow connman coding style resolver: Allow update to domain if server is not set resolver: Do not try to update service if server is not set rtnl: Domain search list

[PATCH 1/4] resolver: Follow connman coding style

--- src/resolver.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/resolver.c b/src/resolver.c index 9656838..d273e3a 100644 --- a/src/resolver.c +++ b/src/resolver.c @@ -360,10 +360,10 @@ int connman_resolver_append_lifetime(const char *interface, const char

[PATCH 2/4] resolver: Allow update to domain if server is not set

--- src/resolver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/resolver.c b/src/resolver.c index d273e3a..f27f22c 100644 --- a/src/resolver.c +++ b/src/resolver.c @@ -354,7 +354,7 @@ int connman_resolver_append_lifetime(const char *interface, const char *domain,

[PATCH 3/4] resolver: Do not try to update service if server is not set

--- src/resolver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/resolver.c b/src/resolver.c index f27f22c..58af2f7 100644 --- a/src/resolver.c +++ b/src/resolver.c @@ -283,7 +283,7 @@ static int append_resolver(const char *interface, const char *domain,

[PATCH 4/4] rtnl: Domain search list was not handled according to RFC 6106

Domain search list option can exist in options without RDNSS option. --- Note that the DNSSL support is not yet in linux kernel (3.4-rc7) so we will not yet get DNSSL option in RA options from netlink and thus the following patch is not fully tested. The rtnl_newnduseropt() required some major

Re: [PATCH] Send RS before RDNSS lifetime expires

Hi Elena, On 05/11/2012 02:56 PM, Elena Tebesoi wrote: Implemented feature from RFC 6106 section '5.1. Recursive DNS Server Option': Lifetime 32-bit unsigned integer. ... Hosts MAY send a Router Solicitation to ensure the RDNSS information is fresh before

[PATCH] gsupplicant: Avoid critical errors

wpa_supplicant sends error if wlan interface cannot be created. Do not treat this error as critical because after calling g_critical() the program logging will be disabled. --- gsupplicant/supplicant.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH] Send RS before RDNSS lifetime expires

Hi Elena, On 05/15/2012 03:37 PM, Elena Tebesoi wrote: Hi Jukka, Thank you for the quick review and please find my answers inline. A new version of the patch is due, taking into account your suggestions. Regards, Elena On Mon, May 14, 2012 at 2:21 PM, Jukka Rissanen jukka.rissa

Re: [PATCH]resolver: Fixed cleanup of Resolver timer

Hi Elena, On 05/18/2012 05:54 PM, Elena Tebesoi wrote: When connman is restarted, DNS servers are removed and added again with function __connman_resolver_redo_servers(). While removing a DNS entry, one should also remove the resolver timer registered for it. Not doing so, causes the timeout

Re: [PATCH v2] Send RS before RDNSS lifetime expires

Hi Elena, some minor nit picking On 05/18/2012 05:54 PM, Elena Tebesoi wrote: Implemented feature from RFC 6106 section '5.1. Recursive DNS Server Option': Lifetime 32-bit unsigned integer. ... Hosts MAY send a Router Solicitation to ensure the RDNSS information

Re: [PATCH v3] Send RS before RDNSS lifetime expires

Hi, On 05/21/2012 03:49 PM, Elena Tebesoi wrote: Implemented feature from RFC 6106 section '5.1. Recursive DNS Server Option': Lifetime 32-bit unsigned integer. ... Hosts MAY send a Router Solicitation to ensure the RDNSS information is fresh before the interval expires.

Re: [PATCH v2]resolver: Fixed cleanup of Resolver timer

Hi Elena, On 05/21/2012 06:48 PM, Elena Tebesoi wrote: When connman is restarted, DNS servers are removed and added again with function __connman_resolver_redo_servers(). While removing a DNS entry, one should also remove the resolver timer registered for it. Not doing so, causes the timeout

Re: [PATCH 3/4] agent: Implementing the new type and argument for RequestInput method call

Hi Tomasz, On 05/23/2012 03:01 PM, Tomasz Bursztyka wrote: This implements the usage of PreviousPassphrase argument as an informational field type. --- src/agent.c | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/src/agent.c b/src/agent.c index

<    2   3   4   5   6   7   8   9   10   11   >