Re: execvpe and glibc 2.10

2009-07-29 Thread Martin Buchholz
Joe, thanks for the review. I've pushed fixes for this problem to openjdk6 and openjdk7/tl Martin On Wed, Jul 29, 2009 at 21:22, Joseph D. Darcy wrote: > Martin Buchholz wrote: >> >> Of course, it's all my fault. >> First, for having used a symbol that libc implementers are likely to add. >> Sec

hg: jdk7/tl/jdk: 2 new changesets

2009-07-29 Thread martinrb
Changeset: bfd7abda8f79 Author:jjb Date: 2009-07-29 14:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bfd7abda8f79 6804124: Replace "modified mergesort" in java.util.Arrays.sort with timsort Summary: Easy port of timsort from android Reviewed-by: martin ! make/java/java/F

Re: execvpe and glibc 2.10

2009-07-29 Thread Joseph D. Darcy
Martin Buchholz wrote: Of course, it's all my fault. First, for having used a symbol that libc implementers are likely to add. Second, for actually asking glibc implementers to add that very symbol. Third, for forgetting that this is an issue in openjdk6 as well. Anyways, I intend to commit thes

Re: execvpe and glibc 2.10

2009-07-29 Thread Martin Buchholz
Of course, it's all my fault. First, for having used a symbol that libc implementers are likely to add. Second, for actually asking glibc implementers to add that very symbol. Third, for forgetting that this is an issue in openjdk6 as well. Anyways, I intend to commit these patches to their respec

hg: jdk7/tl/jdk: 6866554: Misc. javadoc warnings

2009-07-29 Thread martinrb
Changeset: 61d174a58edf Author:martin Date: 2009-07-29 13:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/61d174a58edf 6866554: Misc. javadoc warnings Reviewed-by: alanb ! src/share/classes/java/nio/channels/DatagramChannel.java ! src/share/classes/java/nio/channels/packag

hg: jdk7/tl/langtools: 4777949: Javap Rewrite : Warn javap usage on package classes with simple name.

2009-07-29 Thread jonathan . gibbons
Changeset: c2dfab9e2f39 Author:jjg Date: 2009-07-29 13:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/c2dfab9e2f39 4777949: Javap Rewrite : Warn javap usage on package classes with simple name. Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javap/JavapFi

Re: Review request #0: 6863566 (Java should support the freedesktop.org startup notification specification)

2009-07-29 Thread Damjan Jovanovic
On Wed, Jul 29, 2009 at 2:10 PM, Alan Bateman wrote: > Anthony Petrov wrote: >> >> Hello, >> >> Please review the fix contributed by Damjan Jovanovic: >> >> RFE: https://bugs.openjdk.java.net/show_bug.cgi?id=100094 >> >> webrev: http://cr.openjdk.java.net/~anthony/7-24-startupNotify-6863566.0/ >> >

Re: Review request #0: 6863566 (Java should support the freedesktop.org startup notification specification)

2009-07-29 Thread Damjan Jovanovic
On Wed, Jul 29, 2009 at 1:13 PM, Anthony Petrov wrote: > Hello, > > Please review the fix contributed by Damjan Jovanovic: > > RFE: https://bugs.openjdk.java.net/show_bug.cgi?id=100094 > > webrev: http://cr.openjdk.java.net/~anthony/7-24-startupNotify-6863566.0/ > > Since the patch includes changes

hg: jdk7/tl/jdk: 3 new changesets

2009-07-29 Thread xueming . shen
Changeset: 8cabd2931621 Author:sherman Date: 2009-07-24 11:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8cabd2931621 5063507: (fmt) missing exception for "%#s" format specifier Summary: throw appropriate exception when necessary Reviewed-by: alanb ! src/share/classes/ja

Re: Review request #0: 6863566 (Java should support the freedesktop.org startup notification specification)

2009-07-29 Thread Oleg Sukhodolsky
Hi, just a short question: do we really have to change the launcher? Why we can not add the changes to AWT's native code (somewhere near LoadLibrary())? Oleg. On Wed, Jul 29, 2009 at 3:13 PM, Anthony Petrov wrote: > Hello, > > Please review the fix contributed by Damjan Jovanovic: > > RFE: http

Re: execvpe and glibc 2.10

2009-07-29 Thread Andrew John Hughes
2009/7/28 Martin Buchholz : > On Tue, Jul 28, 2009 at 06:08, Michael McMahon wrote: >> Andrew John Hughes wrote: >>> >>> 2009/7/28 Michael McMahon : >>> Andrew John Hughes wrote: > > 2009/7/9 Martin Buchholz : > > >>> >>> rename-execvpe is the one I'm particularl

Re: Review request #0: 6863566 (Java should support the freedesktop.org startup notification specification)

2009-07-29 Thread Alan Bateman
Anthony Petrov wrote: Hello, Please review the fix contributed by Damjan Jovanovic: RFE: https://bugs.openjdk.java.net/show_bug.cgi?id=100094 webrev: http://cr.openjdk.java.net/~anthony/7-24-startupNotify-6863566.0/ Since the patch includes changes to the src/solaris/bin/java_md.c, I'm CC'in

Review request #0: 6863566 (Java should support the freedesktop.org startup notification specification)

2009-07-29 Thread Anthony Petrov
Hello, Please review the fix contributed by Damjan Jovanovic: RFE: https://bugs.openjdk.java.net/show_bug.cgi?id=100094 webrev: http://cr.openjdk.java.net/~anthony/7-24-startupNotify-6863566.0/ Since the patch includes changes to the src/solaris/bin/java_md.c, I'm CC'ing Kumar and Core Libs a