Re: zlib1.2.3

2009-08-21 Thread Martin Buchholz
I like very much that you are saving local changes in the form of patches (I've been advocating this style of modification of upstream sources for a while now), but... - please generate your patches in unidiff form (diff -u) - the extension .patch is, I think, preferable to .diff (or put them

Re: Which classes need to be supplied by any JVM?

2009-08-21 Thread Florian Weimer
* David Holmes: If you were thinking about this from a basic language perspective - eg we must have Object, and we must have Class, and array implies Serializable etc, then there is a core set of classes that form the transitive closure of the JVM bootstrap process. If you are interested in

Re: Which classes need to be supplied by any JVM?

2009-08-21 Thread Stephen Colebourne
I was actually interested in the thrust of the original question, let me rephrase it. If you wanted to code from scratch a JVM, but not include the rest of the Java SE platform (such as the .class files), what would you need to include? Is Object.class mandatory for a pure JVM? Anything else?

Re: Which classes need to be supplied by any JVM?

2009-08-21 Thread David Holmes - Sun Microsystems
Stephen, Stephen Colebourne said the following on 08/21/09 18:14: If you wanted to code from scratch a JVM, but not include the rest of the Java SE platform (such as the .class files), what would you need to include? Is Object.class mandatory for a pure JVM? Anything else? The answers given

Re: zlib1.2.3

2009-08-21 Thread Xueming Shen
Martin Buchholz wrote: I like very much that you are saving local changes in the form of patches (I've been advocating this style of modification of upstream sources for a while now), but... - please generate your patches in unidiff form (diff -u) - the extension .patch is, I think, preferable

Core review request for 6378701 (enum) Unclear purpose of EnumConstantNotPresentException

2009-08-21 Thread Joseph D. Darcy
Hello. Please review the patch below is clarify the use of certain exception types to address bug 6378701 (enum) Unclear purpose of EnumConstantNotPresentException. Five exceptions/errors can be thrown by the methods of the AnnotatedElement interface; those methods are used to retrieve

Re: Core review request for 6378701 (enum) Unclear purpose of EnumConstantNotPresentException

2009-08-21 Thread Lance J. Andersen
Hi Joe, The changes are fine and make things clearer. Regards Lance Joseph D. Darcy wrote: Hello. Please review the patch below is clarify the use of certain exception types to address bug 6378701 (enum) Unclear purpose of EnumConstantNotPresentException. Five exceptions/errors can be

Re: Core review request for 6378701 (enum) Unclear purpose of EnumConstantNotPresentException

2009-08-21 Thread Andrew John Hughes
2009/8/21 Lance J. Andersen lance.ander...@sun.com: Hi Joe, The changes are fine and make things clearer. Regards Lance Joseph D. Darcy wrote: Hello. Please review the patch below is clarify the use of certain exception types to address bug 6378701 (enum) Unclear purpose of

Re: zlib1.2.3

2009-08-21 Thread Xueming Shen
Martin, webrev has been updated to (1)use unidiff (and the correct order of src and target) (2)put those diffs into a patches dir (3)remove the minigzip.c from the ws (this one is not included in the file_c list...) http://cr.openjdk.java.net/~sherman/zlib123/webrev Thanks Sherman Martin

hg: jdk7/tl/langtools: 6873849: suppress notes generated by javac

2009-08-21 Thread jonathan . gibbons
Changeset: 61c1f735df67 Author:jjg Date: 2009-08-21 11:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/61c1f735df67 6873849: suppress notes generated by javac Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/util/Log.java + test/tools/javac/T6873849.java

Re: hg: jdk7/tl/jdk: 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be.

2009-08-21 Thread Andrew John Hughes
2009/8/21 Mark Wielaard m...@klomp.org: Hi Mark, On Thu, 2009-08-20 at 15:40 -0700, Mark Reinhold wrote: This change was integrated prematurely.  I've rolled it back in the jdk7/tl/jdk repository. If at all possible, please don't do this. It plays havoc with already checked out repos

Re: Core review request for 6378701 (enum) Unclear purpose of EnumConstantNotPresentException

2009-08-21 Thread Joseph D. Darcy
Alan Bateman wrote: Joseph D. Darcy wrote: Hello. Please review the patch below is clarify the use of certain exception types to address bug 6378701 (enum) Unclear purpose of EnumConstantNotPresentException. Five exceptions/errors can be thrown by the methods of the AnnotatedElement

hg: jdk7/tl/langtools: 6873845: refine access to symbol file

2009-08-21 Thread jonathan . gibbons
Changeset: d9febdd5ae21 Author:jjg Date: 2009-08-21 14:58 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d9febdd5ae21 6873845: refine access to symbol file Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/Lint.java !

Re: Which classes need to be supplied by any JVM?

2009-08-21 Thread Jeremy Manson
Even with just a bytecode execution engine, you would need pretty much all of the Throwables in java.lang - NullPointerException, OutOfMemoryError, ArithmeticException, VerifyError, ClassFormatError, IndexOutOfBoundsException and the like. The flip side of what classes does the VM need is what VM