Re: zlib1.2.3

2009-08-23 Thread Xueming Shen
Martin Buchholz wrote: On Sat, Aug 22, 2009 at 20:37, Xueming Shen wrote: - 31 @@ -39,7 +63,7 @@ 32 typedef unsigned int u4; 33 #else 34 # if (ULONG_MAX == 0xUL) 35 - typedef unsigned long u4; 36 + typedef uLong u4; 37 # else

Re: zlib1.2.3

2009-08-23 Thread Martin Buchholz
On Fri, Aug 21, 2009 at 08:46, Xueming Shen wrote: > Martin Buchholz wrote: >> >> Do we really need to rename files?  That's quite confusing. > > The names conflict with our CRC32.c and Adler.c on Windows platform. YUK! I finally understand this problem. Good makefile hygiene would be to build z

Re: zlib1.2.3

2009-08-23 Thread Martin Buchholz
On Sat, Aug 22, 2009 at 20:37, Xueming Shen wrote: >> - >>  31 @@ -39,7 +63,7 @@ >>  32         typedef unsigned int u4; >>  33  #    else >>  34  #      if (ULONG_MAX == 0xUL) >>  35 -         typedef unsigned long u4; >>  36 +         typedef uLong u4; >>  37  #      else >>  

Re: zlib1.2.3

2009-08-23 Thread Martin Buchholz
On Sat, Aug 22, 2009 at 20:37, Xueming Shen wrote: >> - >> >>  35 +/* for _LP64 */ >>  36 +#include >>  37 + >>  38  /* >>  39   * If you *really* need a unique prefix for all types and >> library functions, >>  40   * compile with -DZ_PREFIX. The "standard" zlib should be >> compiled

Re: zlib1.2.3

2009-08-23 Thread Martin Buchholz
On Sun, Aug 23, 2009 at 11:04, Xueming Shen wrote: > Martin, > > Forgot to mentioned in last email, the original zlib.h actually has crc32 > declared using uLong, so > we have a compiling error on 64-bit after we define the uLong to 32-bit > unsigned, since the unsigned > long is 64-bit in crc32.c.

Re: zlib1.2.3

2009-08-23 Thread Xueming Shen
Martin, Forgot to mentioned in last email, the original zlib.h actually has crc32 declared using uLong, so we have a compiling error on 64-bit after we define the uLong to 32-bit unsigned, since the unsigned long is 64-bit in crc32.c. sherman Xueming Shen wrote: I'm suspicious that the ch

hg: jdk7/tl/jdk: 3 new changesets

2009-08-23 Thread alan . bateman
Changeset: 99a55f6f1cef Author:alanb Date: 2009-08-22 17:40 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/99a55f6f1cef 6874521: Remove @note tags Reviewed-by: andrew, darcy ! src/share/classes/java/nio/channels/Channels.java ! src/share/classes/java/nio/channels/FileChannel

Re: hg: jdk7/tl/jdk: 6843995: Added RowsetFactory and Deprecate COMMIT_ON_ACCEPT_CHANGES, make constants final that needed to be.

2009-08-23 Thread Andrew John Hughes
2009/8/22 Mark Wielaard : > Hi Andrew, > > On Fri, 2009-08-21 at 20:35 +0100, Andrew John Hughes wrote: >> 2009/8/21 Mark Wielaard : >> > On Thu, 2009-08-20 at 15:40 -0700, Mark Reinhold wrote: >> >> This change was integrated prematurely.  I've rolled it back in the >> >> jdk7/tl/jdk repository. >

Re: Currency updates in JDK 7

2009-08-23 Thread Alan Bateman
Stephen Colebourne wrote: I've been reviewing the Javadoc for the JDK 7 Currency class changes. http://download.java.net/jdk7/docs/api/java/util/Currency.html The updates appear to allow users the ability to override the built in currency data, as indicated in the class javadoc: "Users can su