On Sat, Aug 22, 2009 at 20:37, Xueming Shen<xueming.s...@sun.com> wrote: >> ------------- >> >> 35 +/* for _LP64 */ >> 36 +#include <sys/types.h> >> 37 + >> 38 /* >> 39 * If you *really* need a unique prefix for all types and >> library functions, >> 40 * compile with -DZ_PREFIX. The "standard" zlib should be >> compiled without it. >> 41 @@ -261,7 +288,11 @@ >> 42 typedef unsigned char Byte; /* 8 bits */ >> 43 #endif >> 44 typedef unsigned int uInt; /* 16 bits or more */ >> 45 +#ifdef _LP64 >> 46 +typedef unsigned int uLong; /* 32 bits or more */ >> 47 +#else >> 48 typedef unsigned long uLong; /* 32 bits or more */ >> 49 +#endif >> >> zlib (intentionally) doesn't have much of a configure layer, >> so we take our best shots at portability. >> I think the above probably works fine, but I would do the very simple >> >> typedef unsigned int uLong; >> > > sure. if this is important for you, I can make the change as you suggested. > I have just finished > all the testing on the platforms I can get here (solaris sparc 32-bit, > solaris x86 32-bit, linux 64-bit, > windows xp 32bit, vista 32-bit and windows 2003 64-bit). The regression/unit > tests have been > on all platforms via jprt. So I will have to go through the build/test > circle again if I'm going to > make this change:-) provided you are convinced that keep the crc32 asis...
As you know, I am an incurable nitpicker. I haven't found any bug in your code, so feel free to commit. Especially since this is a pre-existing Sun modification. But I'll keep sending you comments anyways.
