hg: jdk7/tl/langtools: 6909470: langtools stub generator should prune unnecessary imports

2010-01-11 Thread jonathan . gibbons
Changeset: 51011e02c02f Author:jjg Date: 2010-01-11 16:18 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/51011e02c02f 6909470: langtools stub generator should prune unnecessary imports Reviewed-by: darcy ! make/tools/GenStubs/GenStubs.java

hg: jdk7/tl/jdk: 6828204: NavigableSet.subSet() documentation refers to nonexistent parameters

2010-01-11 Thread joe . darcy
Changeset: 9d38ab65acff Author:darcy Date: 2010-01-11 15:35 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9d38ab65acff 6828204: NavigableSet.subSet() documentation refers to nonexistent parameters Reviewed-by: martin ! src/share/classes/java/util/NavigableMap.java ! src/sha

Re: Code review request for 6828204 NavigableSet.subSet() documentation refers to nonexistent parameters

2010-01-11 Thread Martin Buchholz
Approved! Thanks for the fix. Martin On Mon, Jan 11, 2010 at 13:17, Joseph D. Darcy wrote: > Hello. > > Please review this simple typo fix for 6828204 "NavigableSet.subSet() > documentation refers to nonexistent parameters": > > --- old/src/share/classes/java/util/NavigableMap.java    2010-01-1

hg: jdk7/tl/langtools: 6915497: test test/tools/javac/nio/compileTest/CompileTest.java fails under Hudson

2010-01-11 Thread jonathan . gibbons
Changeset: 14a4c45ef734 Author:jjg Date: 2010-01-11 14:17 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/14a4c45ef734 6915497: test test/tools/javac/nio/compileTest/CompileTest.java fails under Hudson Reviewed-by: darcy ! test/tools/javac/nio/compileTest/CompileTest.j

hg: jdk7/tl/langtools: 6915476: java.util.regex.PatternSyntaxException in com.sun.tools.javac.nio.PathFileObject

2010-01-11 Thread jonathan . gibbons
Changeset: ca6bc36b2305 Author:jjg Date: 2010-01-11 14:12 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/ca6bc36b2305 6915476: java.util.regex.PatternSyntaxException in com.sun.tools.javac.nio.PathFileObject Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/n

hg: jdk7/tl/langtools: 6764569: [PATCH] Fix unused imports in list resource bundles

2010-01-11 Thread jonathan . gibbons
Changeset: f983c1dca202 Author:jjg Date: 2010-01-11 14:09 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f983c1dca202 6764569: [PATCH] Fix unused imports in list resource bundles Reviewed-by: ksrini Contributed-by: jesse.gl...@sun.com ! make/tools/CompileProperties/Com

hg: jdk7/tl/langtools: 6326754: Compiler will fail to handle -Xmaxerrs with -ve numbers

2010-01-11 Thread jonathan . gibbons
Changeset: d02e99d31cc0 Author:jjg Date: 2010-01-11 14:05 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d02e99d31cc0 6326754: Compiler will fail to handle -Xmaxerrs with -ve numbers Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/util/Log.java + test/tools

hg: jdk7/tl/jdk: 6915313: Reorganize implementation to make it more feasible to port to JDK6

2010-01-11 Thread christopher . hegarty
Changeset: fc5578368a0c Author:chegar Date: 2010-01-11 16:04 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fc5578368a0c 6915313: Reorganize implementation to make it more feasible to port to JDK6 Summary: This makes the SCTP implementation easier to run with Suns JDK6. Revie

Code review request for 6828204 NavigableSet.subSet() documentation refers to nonexistent parameters

2010-01-11 Thread Joseph D. Darcy
Hello. Please review this simple typo fix for 6828204 "NavigableSet.subSet() documentation refers to nonexistent parameters": --- old/src/share/classes/java/util/NavigableMap.java2010-01-11 13:13:28.0 -0800 +++ new/src/share/classes/java/util/NavigableMap.java2010-01-11 13:13

Re: The new Objects class

2010-01-11 Thread Paulo Levi
Well. Avoid the need for the warning. But i see what you mean. A simple array would have to include the warning anyway, if it was a one element array.

Re: The new Objects class

2010-01-11 Thread Marek Kozieł
2010/1/11 Paulo Levi : > Possibly two overloadings? > One that takes a array > public static int hash(Object[] values) > The other > hash(Object value1, Object value2, Object... restOfValues) > > The one object case is just > object.hashcode() right? > > Can you tell me what target you want to obt

Re: The new Objects class

2010-01-11 Thread Paulo Levi
Possibly two overloadings? One that takes a array public static int hash(Object[] values) The other* *hash(Object value1, Object value2, Object... restOfValues) The one object case is just object.hashcode() right? On Mon, Jan 11, 2010 at 10:20 AM, Marek Kozieł wrote: > 2010/1/10 Neal Gafter : >

Re: The new Objects class

2010-01-11 Thread Marek Kozieł
2010/1/10 Neal Gafter : > On Sun, Jan 10, 2010 at 12:14 AM, Paulo Levi wrote: >> Just seen the new Objects class in the java.util. >> >> I'd like to ask why does the >> >> public static int hash(Object... values) >> >> method, has the warning: >> Warning: When a single object reference is supplied