Re: JDK 8 code review request for 7075098: Remove unused fdlibm files

2011-08-04 Thread Dr Andrew John Hughes
On 13:09 Thu 04 Aug , Joe Darcy wrote: > > The JDK makefiles specially compile the FDLIBM sources under lower > optimization levels to try to avoid such problems. Over the years, we > have had our share of C compiler bugs tripping up FDLIBM, which have > been caught by our testing. One of

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

2011-08-04 Thread Alexandre Boulgakov
On 8/3/2011 10:44 PM, Joe Darcy wrote: David Holmes wrote: Joe Darcy said the following on 08/04/11 12:33: David Holmes wrote: Using wildcards makes the subtyping work along the type argument axis. So what is the right fix here? To declare the underlying Vector as a Vector and cast it to s

Re: JDK 8 code review request for 7075098: Remove unused fdlibm files

2011-08-04 Thread Joe Darcy
Hi Mike. Mike Duigou wrote: Looks good to me. I did wonder if we have a policy for tracking fdlibm updates. To a first approximation (and even a second approximation), fdlibm doesn't have updates any more any hasn't for many years. The changes in in 5.3 were to fix a few bugs I and others

Re: JDK 8 code review request for 7075098: Remove unused fdlibm files

2011-08-04 Thread Mike Duigou
Looks good to me. I did wonder if we have a policy for tracking fdlibm updates. The fdlibm people don't seem to ascribe dates to their releases or think to include version numbers in their headers. Are we using 5.3, the apparent latest version? Their release page mentions an outstanding incorr

Re: JDK 8 code review request for 7075098: Remove unused fdlibm files

2011-08-04 Thread Alan Bateman
Joe Darcy wrote: Hello. Please review these straightforward changes for 7075098: Remove unused fdlibm files http://cr.openjdk.java.net/~darcy/7075098.0/ The JDK math libraries in java.lang.{Math, StrictMath} do not expose all the functionality implemented in the embedded copy of FDLIBM

JDK 8 code review request for 7075098: Remove unused fdlibm files

2011-08-04 Thread Joe Darcy
Hello. Please review these straightforward changes for 7075098: Remove unused fdlibm files http://cr.openjdk.java.net/~darcy/7075098.0/ The JDK math libraries in java.lang.{Math, StrictMath} do not expose all the functionality implemented in the embedded copy of FDLIBM (freely distribut

hg: jdk8/tl/langtools: 7071246: Enclosing string literal in parenthesis in switch-case crashes javac

2011-08-04 Thread joe . darcy
Changeset: 64b9b7ae3366 Author:darcy Date: 2011-08-04 11:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/64b9b7ae3366 7071246: Enclosing string literal in parenthesis in switch-case crashes javac Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/L

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

2011-08-04 Thread Rémi Forax
On 08/04/2011 07:39 PM, Colin Decker wrote: Well, Iterator doesn't have an iterator() method. It also looks like you'd have to have a reference to a single Enumeration already there? I was suggesting using a method reference to an Enumeration-returning method so that a fresh Enumeration could b

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

2011-08-04 Thread Colin Decker
Well, Iterator doesn't have an iterator() method. It also looks like you'd have to have a reference to a single Enumeration already there? I was suggesting using a method reference to an Enumeration-returning method so that a fresh Enumeration could be retrieved to back each Iterator created by the

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

2011-08-04 Thread Rémi Forax
On 08/04/2011 06:52 PM, Colin Decker wrote: No, that copies the Enumeration. I'm talking about something that creates lazy Iterators backed by Enumerations. -- Colin Ok, why not adding a method iterator(Enumeration) that takes an Enumeration and returns an Iterator and then do a method refere

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

2011-08-04 Thread Colin Decker
No, that copies the Enumeration. I'm talking about something that creates lazy Iterators backed by Enumerations. -- Colin On Thu, Aug 4, 2011 at 12:34 PM, Rémi Forax wrote: > On 08/04/2011 06:17 PM, Colin Decker wrote: > >> One better way to handle this in Java 8 would be to have a utility me

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

2011-08-04 Thread Rémi Forax
On 08/04/2011 06:17 PM, Colin Decker wrote: One better way to handle this in Java 8 would be to have a utility method that takes a Supplier> SAM argument (with a no-arg method that returns an Enumeration) and returns an Iterable that gets a new Enumeration from the supplier each time iterator()

Re: Code Review Request : 7011591 JDWP socket transport should restart interrupted system calls (EINTR)

2011-08-04 Thread Daniel D. Daugherty
On 8/4/11 9:50 AM, Alan Bateman wrote: David Buck wrote: Hi! I would like to request that my fix for 7011591 be reviewed for push into JDK8 (and JDK7u if possible). CR: 7011591 JDWP socket transport should restart interrupted system calls (EINTR) : Webrev: http://cr.openjdk.java.net/~dbuc

hg: jdk8/tl/jdk: 7073296: Executable.equalParamTypes() incorrectly returns true when the number of params differs.

2011-08-04 Thread mike . duigou
Changeset: 56e89034 Author:mduigou Date: 2011-08-04 08:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/56e89034 7073296: Executable.equalParamTypes() incorrectly returns true when the number of params differs. Reviewed-by: alanb, darcy ! src/share/classes/java/lan

Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

2011-08-04 Thread Colin Decker
One better way to handle this in Java 8 would be to have a utility method that takes a Supplier> SAM argument (with a no-arg method that returns an Enumeration) and returns an Iterable that gets a new Enumeration from the supplier each time iterator() is called. It could then be used with method re

Re: Code Review Request : 7011591 JDWP socket transport should restart interrupted system calls (EINTR)

2011-08-04 Thread Alan Bateman
David Buck wrote: Hi! I would like to request that my fix for 7011591 be reviewed for push into JDK8 (and JDK7u if possible). CR: 7011591 JDWP socket transport should restart interrupted system calls (EINTR) : Webrev: http://cr.openjdk.java.net/~dbuck/7011591/webrev.00/ I've added servicea

hg: jdk8/tl/jdk: 7061379: [Kerberos] Cross-realm authentication fails, due to nameType problem

2011-08-04 Thread weijun . wang
Changeset: e68db408d08c Author:weijun Date: 2011-08-04 18:18 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e68db408d08c 7061379: [Kerberos] Cross-realm authentication fails, due to nameType problem Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/PrincipalName.ja