Re: Request for review Remove "private" cause in jdk exceptions

On Aug 25, 2011, at 8:00 PM, Sebastian Sickelmann wrote: > Am 26.08.2011 00:24, schrieb Sebastian Sickelmann: >> Am 26.08.2011 00:03, schrieb Sebastian Sickelmann: >>> I have found more places in jdk source where an Exception has a private >>> cause field. >>> >>> share/classes/javax/management/r

Re: Enhance toString() to return structured info, for certificate and probably more

Well, I mentioned toString() there just to make it look absurd so that I can promote my alternative method. :) As for the toDescription() method, do you know if there are other cases it can be useful? Thanks Max On 08/26/2011 10:03 AM, Mike Duigou wrote: On Aug 25 2011, at 14:01 , Dr Andr

Re: Enhance toString() to return structured info, for certificate and probably more

On Aug 25 2011, at 14:01 , Dr Andrew John Hughes wrote: > On 10:41 Thu 25 Aug , Weijun Wang wrote: >> Hi All >> >> I was talking with Xuelei on how to better display certificate info. >> There are 3 cases we can currently think of: >> >> 1. debug output >> 2. keytool/jarsigner output >> 3.

Request for review Remove "private" cause in jdk exceptions

Am 26.08.2011 00:24, schrieb Sebastian Sickelmann: Am 26.08.2011 00:03, schrieb Sebastian Sickelmann: I have found more places in jdk source where an Exception has a private cause field. share/classes/javax/management/remote/JMXProviderException.java: private Throwable cause = null; share/

Re: hg: jdk8/tl/jdk: 7082727: VirtualMachineError should declare its serialVersionUID

Dr Andrew John Hughes wrote: On 16:43 Thu 25 Aug , joe.da...@oracle.com wrote: Changeset: 624cc18a6cf9 Author:darcy Date: 2011-08-25 09:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/624cc18a6cf9 7082727: VirtualMachineError should declare its serialVersionUID Re

Re: hg: jdk8/tl/jdk: 7082727: VirtualMachineError should declare its serialVersionUID

Am 25.08.2011 22:53, schrieb Dr Andrew John Hughes: On 16:43 Thu 25 Aug , joe.da...@oracle.com wrote: IChangeset: 624cc18a6cf9 Author:darcy Date: 2011-08-25 09:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/624cc18a6cf9 7082727: VirtualMachineError should declare it

Re: Enhance toString() to return structured info, for certificate and probably more

On 10:41 Thu 25 Aug , Weijun Wang wrote: > Hi All > > I was talking with Xuelei on how to better display certificate info. > There are 3 cases we can currently think of: > > 1. debug output > 2. keytool/jarsigner output > 3. Java plugin display > > The 1st one is the most primitive one and

Re: hg: jdk8/tl/jdk: 7082727: VirtualMachineError should declare its serialVersionUID

On 16:43 Thu 25 Aug , joe.da...@oracle.com wrote: > Changeset: 624cc18a6cf9 > Author:darcy > Date: 2011-08-25 09:42 -0700 > URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/624cc18a6cf9 > > 7082727: VirtualMachineError should declare its serialVersionUID > Reviewed-by: alanb > >

Re: Enumeration adapters in SE 8

Some other candidates for Iterable: Bug 6793773 - Let CharsetProvider implement Iterable Bug 6935695 - String should implement Iterable -Ulf Am 25.08.2011 10:19, schrieb

Re: Code review request 7077769: (zipfs) ZipFileSystem.writeCEN() writes wrong "data size" for ZIP64 extended information extra field

Alan Webrev has been updated to (1) use the new try(resource){} (2) update the existing test case LargetZip to a) be able to add one more entry at the end of the > 4g zip via ZipFileSystem b) read through all entries inside the large zipfile, given zipfile's self-crc-check i

Re: JDK 8 code review request for 7082727 VirtualMachineError should declare its serialVersionUID

Looks good. Thanks For fixing. -- Sebastian Joe Darcy schrieb: >Hello. > >Please review the patch below to add an explicit serialVersionUID to >VirtualMachineError: > >7082727 VirtualMachineError should declare its serialVersionUID >http://cr.openjdk.java.net/~darcy/7082727.0/ > >Tha

Re: JDK 8 code review request for 7082727 VirtualMachineError should declare its serialVersionUID

Looks good joe. On Aug 25, 2011, at 12:37 PM, Joe Darcy wrote: > Hello. > > Please review the patch below to add an explicit serialVersionUID to > VirtualMachineError: > > 7082727 VirtualMachineError should declare its serialVersionUID > http://cr.openjdk.java.net/~darcy/7082727.0/ > > Tha

Re: hg: jdk8/tl/jdk: 7080020: Add conventional constructors to InternalError and VirtualMachineError

Yeah, I guess so. We'd have to add @SuppressWarnings("serial") to some non-public classes but so what. Éamonn On 25/8/11 6:01 PM, Joe Darcy wrote: Eamonn McManus wrote: Could we perhaps have the JDK build use an annotation processor that requires every public class in java.* javax.* etc that

hg: jdk8/tl/jdk: 7082727: VirtualMachineError should declare its serialVersionUID

Changeset: 624cc18a6cf9 Author:darcy Date: 2011-08-25 09:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/624cc18a6cf9 7082727: VirtualMachineError should declare its serialVersionUID Reviewed-by: alanb ! src/share/classes/java/lang/VirtualMachineError.java

Re: JDK 8 code review request for 7082727 VirtualMachineError should declare its serialVersionUID

Joe Darcy wrote: Hello. Please review the patch below to add an explicit serialVersionUID to VirtualMachineError: 7082727 VirtualMachineError should declare its serialVersionUID http://cr.openjdk.java.net/~darcy/7082727.0/ Thanks, -Joe --- old/src/share/classes/java/lang/VirtualMachi

JDK 8 code review request for 7082727 VirtualMachineError should declare its serialVersionUID

Hello. Please review the patch below to add an explicit serialVersionUID to VirtualMachineError: 7082727 VirtualMachineError should declare its serialVersionUID http://cr.openjdk.java.net/~darcy/7082727.0/ Thanks, -Joe --- old/src/share/classes/java/lang/VirtualMachineError.java 2

Re: hg: jdk8/tl/jdk: 7080020: Add conventional constructors to InternalError and VirtualMachineError

Eamonn McManus wrote: Could we perhaps have the JDK build use an annotation processor that requires every public class in java.* javax.* etc that is serializable to either declare a serialVersionUID or have @SuppressWarnings("serial")? The amount of grief we have had over the years with this w

hg: jdk8/tl/jdk: 7044870: java/nio/channels/DatagramChannel/SelectWhenRefused.java failed on SUSE Linux 10

Changeset: c9e78769c0da Author:chegar Date: 2011-08-25 16:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9e78769c0da 7044870: java/nio/channels/DatagramChannel/SelectWhenRefused.java failed on SUSE Linux 10 Reviewed-by: alanb, chegar Contributed-by: kurchi.subhra.ha...@o

Re: hg: jdk8/tl/jdk: 7080020: Add conventional constructors to InternalError and VirtualMachineError

Could we perhaps have the JDK build use an annotation processor that requires every public class in java.* javax.* etc that is serializable to either declare a serialVersionUID or have @SuppressWarnings("serial")? The amount of grief we have had over the years with this would easily justify the

Re: hg: jdk8/tl/jdk: 7080020: Add conventional constructors to InternalError and VirtualMachineError

Sebastian Sickelmann wrote: : I have build(make clean, make all, make images) the jdk-repo only. Or does i have to pull in the changes of my jdk8/tl/jdk clone to my jdk8/jdk8/jdk clone to check this? Has someone in the past evaluated if there is a good way to do regression tests for serialV

Re: Enumeration adapters in SE 8

Hi I know this is slightly off topic but f there is a discussion on enhancing the for each loop ... 1 is there any chance that we could use ARM functionality and allow a ClosableIterator to be introduced. There are many occasions that an iterator is backed by some resource (list of lines in a f

Re: hg: jdk8/tl/jdk: 7080020: Add conventional constructors to InternalError and VirtualMachineError

Am 25.08.2011 08:28, schrieb Alan Bateman: Joe Darcy wrote: Hi Alan. I did check for that point in my review :-) The VirtualMachineError class is abstract so as long as all its subclasses declare a serialVersionUID, like InternalError does, I think we're fine. We need to check the serializat

Re: hg: jdk8/tl/jdk: 7080020: Add conventional constructors to InternalError and VirtualMachineError

Alan Bateman wrote: Joe Darcy wrote: Hi Alan. I did check for that point in my review :-) The VirtualMachineError class is abstract so as long as all its subclasses declare a serialVersionUID, like InternalError does, I think we're fine. We need to check the serialization protocol but I'm pr