Re: Request-Review: Remove two simple warnings in HttpsURLConnection.java

Xuelei Fan wrote: Hi Sebastian, Thank you for your contribution on OpenJDK. The update looks fine to me. Do you have a CR (Change Request) for this update? BTW, have you signed the Oracle Contribution Agreement [1]? I did not find you name in the OpenJDK people list. I don't think there is

Re: Request-Review: Remove two simple warnings in HttpsURLConnection.java

Hi Sebastian, Thank you for your contribution on OpenJDK. The update looks fine to me. Do you have a CR (Change Request) for this update? BTW, have you signed the Oracle Contribution Agreement [1]? I did not find you name in the OpenJDK people list. Thanks, Xuelei [1] http://openjdk.java.net/c

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 973d923af88c Author:sherman Date: 2011-08-26 15:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/973d923af88c 7077769: (zipfs) ZipFileSystem.writeCEN() writes wrong "data size" for ZIP64 extended information extra field Summary: fixed the wrong size when writing

Re: Request-Review: Remove two simple warnings in HttpsURLConnection.java

Please ignored this email. My apology. Wrong click. On 08/26/2011 03:16 PM, Xueming Shen wrote: On 08/26/2011 02:45 PM, Alan Bateman wrote: Sebastian Sickelmann wrote: Hi, is there someone who wants to review / support this simple warning removal? The webrev is: http://oss-patches.24.eu/o

Re: Request-Review: Remove two simple warnings in HttpsURLConnection.java

On 08/26/2011 02:45 PM, Alan Bateman wrote: Sebastian Sickelmann wrote: Hi, is there someone who wants to review / support this simple warning removal? The webrev is: http://oss-patches.24.eu/openjdk8/Simple_Warning/ -- Sebastian* * This is JSSE so probably best if someone from the security

Re: Request-Review: Remove two simple warnings in HttpsURLConnection.java

Sebastian Sickelmann wrote: Hi, is there someone who wants to review / support this simple warning removal? The webrev is: http://oss-patches.24.eu/openjdk8/Simple_Warning/ -- Sebastian* * This is JSSE so probably best if someone from the security area pushes this for Sebastian. -Alan.

Re: Code review request 7077769: (zipfs) ZipFileSystem.writeCEN() writes wrong "data size" for ZIP64 extended information extra field

Xueming Shen wrote: On 08/26/2011 01:17 PM, Alan Bateman wrote: Xueming Shen wrote: Alan Webrev has been updated to (1) use the new try(resource){} (2) update the existing test case LargetZip to a) be able to add one more entry at the end of the > 4g zip via ZipFileSystem b) read t

hg: jdk8/tl/jdk: 7060243: (dc) Multicasting tests fail on Windows XP if IPv6 is enabled

Changeset: 6d2f09eed4e3 Author:alanb Date: 2011-08-26 22:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6d2f09eed4e3 7060243: (dc) Multicasting tests fail on Windows XP if IPv6 is enabled Reviewed-by: alanb Contributed-by: kurchi.subhra.ha...@oracle.com ! test/java/nio/ch

Re: Code review request 7077769: (zipfs) ZipFileSystem.writeCEN() writes wrong "data size" for ZIP64 extended information extra field

On 08/26/2011 01:17 PM, Alan Bateman wrote: Xueming Shen wrote: Alan Webrev has been updated to (1) use the new try(resource){} (2) update the existing test case LargetZip to a) be able to add one more entry at the end of the > 4g zip via ZipFileSystem b) read through all entries in

Re: Request Review: 7080622: Remove varargs warnings from rmic

Sebastian Sickelmann wrote: I updated my webrev to fix a small failure i introduces with my initial CR in logging off XIconWindow. Is there any change to rename the bug. Or should i provide 2 CRs for this? I changed the synopsis to simply "Remove vargs warnings" as one CR is sufficient for this

Request-Review: Remove two simple warnings in HttpsURLConnection.java

Hi, is there someone who wants to review / support this simple warning removal? The webrev is: http://oss-patches.24.eu/openjdk8/Simple_Warning/ -- Sebastian* *

Request Review: 7080622: Remove varargs warnings from rmic

Am 19.08.2011 06:50, schrieb Sebastian Sickelmann: Am 18.08.2011 16:11, schrieb Alan Bateman: Mandy Chung wrote: Thumbs up from me. Are you going to include this change with another CR that you have a fix to be pushed? Mandy I think it's best to separate this fix and so I've created the f

Re: hg: jdk8/tl/jdk: 7080020: Add conventional constructors to InternalError and VirtualMachineError

On 8/26/2011 12:49 PM, Sebastian Sickelmann wrote: Am 25.08.2011 10:46, schrieb Alan Bateman: Sebastian Sickelmann wrote: : I have build(make clean, make all, make images) the jdk-repo only. Or does i have to pull in the changes of my jdk8/tl/jdk clone to my jdk8/jdk8/jdk clone to check this

Re: Code review request 7077769: (zipfs) ZipFileSystem.writeCEN() writes wrong "data size" for ZIP64 extended information extra field

Xueming Shen wrote: Alan Webrev has been updated to (1) use the new try(resource){} (2) update the existing test case LargetZip to a) be able to add one more entry at the end of the > 4g zip via ZipFileSystem b) read through all entries inside the large zipfile, given zipfile's self

Request for review: More cause-chaining for InternalError

Am 23.08.2011 14:16, schrieb Sebastian Sickelmann: Am 22.08.2011 21:19, schrieb Joe Darcy: Sebastian Sickelmann wrote: Am 17.08.2011 03:11, schrieb joe.da...@oracle.com: Hello. On 8/14/2011 11:17 PM, Sebastian Sickelmann wrote: Hi, some time ago, i wrote[5] with Joe and David about advancin

Re: hg: jdk8/tl/jdk: 7080020: Add conventional constructors to InternalError and VirtualMachineError

Am 25.08.2011 10:46, schrieb Alan Bateman: Sebastian Sickelmann wrote: : I have build(make clean, make all, make images) the jdk-repo only. Or does i have to pull in the changes of my jdk8/tl/jdk clone to my jdk8/jdk8/jdk clone to check this? Has someone in the past evaluated if there is a

Re: Request for review Remove "private" cause in jdk exceptions

Am 26.08.2011 13:05, schrieb Dalibor Topic: On 8/26/11 12:59 PM, Sebastian Sickelmann wrote: Am 26.08.2011 08:32, schrieb Peter Jones: Public fields like RemoteException.detail, ill-advised as they may have been, cannot be removed (would break binary compatibility). Sorry for that. It was mor

Re: Request for review Remove "private" cause in jdk exceptions

On 8/26/11 1:15 PM, Sebastian Sickelmann wrote: >Thanks for reviewing/supporting on my CRs. (Does CR mean Change Request???) Yes. See http://wikis.sun.com/display/OpenJdkBuilds/JDK+Glossary+of+Terms cheers, dalibor topic -- Oracle Dalibor Topic | Java F/OSS Ambassador Pho

Re: Request for review Remove "private" cause in jdk exceptions

On 8/26/11 12:59 PM, Sebastian Sickelmann wrote: > Am 26.08.2011 08:32, schrieb Peter Jones: >> Public fields like RemoteException.detail, ill-advised as they may have >> been, cannot be removed (would break binary compatibility). > Sorry for that. It was more a reflex (remove "evil" public fields

Re: Request for review Remove "private" cause in jdk exceptions

Am 26.08.2011 09:22, schrieb Alan Bateman: Sebastian Sickelmann wrote: OK. Webrev is there: http://oss-patches.24.eu/openjdk8/NoSuchMechanismException/REBASED_ON_8018d541a7b2_2/ Can someone review this? I think this one will require careful review and I'm not even sure that it's worth it.

Re: Request for review Remove "private" cause in jdk exceptions

Am 26.08.2011 08:32, schrieb Peter Jones: On Aug 25, 2011, at 8:00 PM, Sebastian Sickelmann wrote: Am 26.08.2011 00:24, schrieb Sebastian Sickelmann: Am 26.08.2011 00:03, schrieb Sebastian Sickelmann: I have found more places in jdk source where an Exception has a private cause field. share/

hg: jdk8/tl/jdk: 7024697: SessionRef.dispose() should determine if the token referred to by the token object is still valid

Changeset: 3a13b7ab57f7 Author:coffeys Date: 2011-08-26 10:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3a13b7ab57f7 7024697: SessionRef.dispose() should determine if the token referred to by the token object is still valid Reviewed-by: valeriep ! src/share/classes/sun

Re: Enhance toString() to return structured info, for certificate and probably more

* Weijun Wang: > What's your ideas? Do you also need such a method? I suspect that many applications which need to look at certificates in detail would benefit more from an official ASN.1 decoder. Defining yet another data model for X.509 certificates (after ASN.1 and the current Java API) seems

Re: Request for review Remove "private" cause in jdk exceptions

Sebastian Sickelmann wrote: OK. Webrev is there: http://oss-patches.24.eu/openjdk8/NoSuchMechanismException/REBASED_ON_8018d541a7b2_2/ Can someone review this? I think this one will require careful review and I'm not even sure that it's worth it. Using serialPersistentFields and overriding