Re: Request for review - change two include header files according to POSIX.1-2008

2011-10-12 Thread David Holmes
Hi Charles, On 13/10/2011 2:54 PM, Charles Lee wrote: Thanks Alan. Below is the patch I am failed to attach. It is trivial... Do you need someone to sponsor this for you, or are you able to drive this via other IBM folk that can generate webrevs on cr.openjdk.java.net and ultimately do the p

Re: Request for review - change two include header files according to POSIX.1-2008

2011-10-12 Thread Charles Lee
On 10/12/2011 10:16 PM, Alan Bateman wrote: David Holmes wrote: : We'll need to verify the changes for in the genUnixConstants code. There tends to be a reason (often historical and possibly no longer applicable) for using the sys variants (though sometimes it was just that the non-sys vers

hg: jdk8/tl/jdk: 7027061: Testcase failure: java/util/Locale/Bug6989440.java - java.util.ConcurrentModificationException

2011-10-12 Thread naoto . sato
Changeset: 829c3a8d23fa Author:naoto Date: 2011-10-12 12:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/829c3a8d23fa 7027061: Testcase failure: java/util/Locale/Bug6989440.java - java.util.ConcurrentModificationException Reviewed-by: dholmes, chegar ! src/share/classes/s

Re: Request for review - change two include header files according to POSIX.1-2008

2011-10-12 Thread Alan Bateman
David Holmes wrote: : We'll need to verify the changes for in the genUnixConstants code. There tends to be a reason (often historical and possibly no longer applicable) for using the sys variants (though sometimes it was just that the non-sys version didn't exist at some point in time). Thi

Re: Request for review - change two include header files according to POSIX.1-2008

2011-10-12 Thread Anthony Petrov
Changes to the splashscreen_config.h look fine. Thanks. -- best regards, Anthony On 10/12/2011 11:36 AM, David Holmes wrote: On 12/10/2011 5:23 PM, Charles Lee wrote: On 10/12/2011 03:12 PM, David Holmes wrote: On 12/10/2011 4:26 PM, Charles Lee wrote: sys/unistd.h, sys/fcntl.h are not suppor

hg: jdk8/tl/jdk: 7092375: Security Libraries don't build with javac -Werror

2011-10-12 Thread xuelei . fan
Changeset: ffa762153af4 Author:xuelei Date: 2011-09-28 15:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ffa762153af4 7092375: Security Libraries don't build with javac -Werror Summary: Changes to security related java and make files to remove warnings Reviewed-by: xuelei

Re: Patch to Throwable and StackTraceElement (reduced CPU usage)

2011-10-12 Thread Patrick Reinhart
Hi Mike Zitat von "David Holmes" : Patrick - this is why you idea doesn't really provide the answer, there is still a StringBuilder created for each line of stack trace printed, and probably a resize as the line is probably > 16 chars, as well as 2 writes for each line Ups, I missed the toSt

Re: Patch to Throwable and StackTraceElement (reduced CPU usage)

2011-10-12 Thread mike.ske...@talk21.com
Hi David I will update and retest by the end of week Regards Mike

Re: Request for review - change two include header files according to POSIX.1-2008

2011-10-12 Thread Charles Lee
On 10/12/2011 03:36 PM, David Holmes wrote: On 12/10/2011 5:23 PM, Charles Lee wrote: On 10/12/2011 03:12 PM, David Holmes wrote: On 12/10/2011 4:26 PM, Charles Lee wrote: sys/unistd.h, sys/fcntl.h are not supported in AIX. And according to the POSIX.1-2008 (http://pubs.opengroup.org/onlinepub

Re: Request for review - change two include header files according to POSIX.1-2008

2011-10-12 Thread David Holmes
On 12/10/2011 5:23 PM, Charles Lee wrote: On 10/12/2011 03:12 PM, David Holmes wrote: On 12/10/2011 4:26 PM, Charles Lee wrote: sys/unistd.h, sys/fcntl.h are not supported in AIX. And according to the POSIX.1-2008 (http://pubs.opengroup.org/onlinepubs/9699919799/), I have changed them to unistd

Re: Request for review - change two include header files according to POSIX.1-2008

2011-10-12 Thread Charles Lee
On 10/12/2011 03:12 PM, David Holmes wrote: Hi Charles, On 12/10/2011 4:26 PM, Charles Lee wrote: sys/unistd.h, sys/fcntl.h are not supported in AIX. And according to the POSIX.1-2008 (http://pubs.opengroup.org/onlinepubs/9699919799/), I have changed them to unistd.h and fcntl.h. The patch has

Re: Request for review - change two include header files according to POSIX.1-2008

2011-10-12 Thread David Holmes
Hi Charles, On 12/10/2011 4:26 PM, Charles Lee wrote: sys/unistd.h, sys/fcntl.h are not supported in AIX. And according to the POSIX.1-2008 (http://pubs.opengroup.org/onlinepubs/9699919799/), I have changed them to unistd.h and fcntl.h. The patch has been tested on both linux and aix. I also ch

Re: Request for review - change two include header files according to POSIX.1-2008

2011-10-12 Thread Charles Lee
On 10/12/2011 02:26 PM, Charles Lee wrote: Hi guys, sys/unistd.h, sys/fcntl.h are not supported in AIX. And according to the POSIX.1-2008 (http://pubs.opengroup.org/onlinepubs/9699919799/), I have changed them to unistd.h and fcntl.h. The patch has been tested on both linux and aix. I also