Re: sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-17 Thread Deven You
On 04/18/2012 01:34 PM, Mandy Chung wrote: On 4/17/2012 12:33 AM, Deven You wrote: I think this could still run into CME. System Properties is not a synchronized map and the setter methods (System.setProperty or Properties.put method) doesn't synchronize on the Properties object. Hi Mandy

Re: sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-17 Thread Mandy Chung
On 4/17/2012 12:33 AM, Deven You wrote: I think this could still run into CME. System Properties is not a synchronized map and the setter methods (System.setProperty or Properties.put method) doesn't synchronize on the Properties object. Hi Mandy, I didn't catch you. Do you mean there are

Re: Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

2012-04-17 Thread David Holmes
On 18/04/2012 1:15 PM, Sean Chou wrote: Hi David, The current implementation uses static char array to keep the error message, so it is possible when two errors happen at the same time, the error message will be modified. I have a testcase attached in http://mail.openjdk.java.net/pipermail/

Re: Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

2012-04-17 Thread Sean Chou
Hi David, The current implementation uses static char array to keep the error message, so it is possible when two errors happen at the same time, the error message will be modified. I have a testcase attached in http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-April/009766.html .

Re: Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

2012-04-17 Thread David Holmes
Hi Sean, On 18/04/2012 12:37 PM, Sean Chou wrote: To free the error string in ZIP_Open is a result of discussion with hotspot. They said the error string is never used and they do not want to do the free work in hotspot for ZIP_Open... Ok. I assume there are no other callers of this metho

Re: Replace the static error string in ZIP_Put_In_Cache0 with on stack memory

2012-04-17 Thread Sean Chou
Hi David, To free the error string in ZIP_Open is a result of discussion with hotspot. They said the error string is never used and they do not want to do the free work in hotspot for ZIP_Open... strdup would cause a NULL error string if memory allocation is failed. If strdup is not used,

Re: Reviewer needed: 6282196 There should be Math.mod(number, modulo) methods

2012-04-17 Thread Joe Darcy
On 04/17/2012 07:50 AM, Roger Riggs wrote: I'm not sure have all the history around the Math vs StrictMath distinction. For the more "interesting" mathematical methods where multiple implementations are reasonable, the StrictMath version provides cross-platform reproducibility by specifying t

Re: Review for 7157656 (zipfs) SeekableByteChannel to entry in zip file...

2012-04-17 Thread Xueming Shen
Given the sequential nature of the zip stream, it's a kinda of hard to implement the position(long) method for a "pure" zip byte channel. You don't want to jump either backward or forward N bytes when writing and appending (we don't have a "position mapping" between the compressed and uncompr

Re: Codereview request 7067045: replaceAll("\u20ac", "$"); causses java.lang.StringIndexOutOfBoundsExceptio

2012-04-17 Thread Xueming Shen
Hi Paul, I'm fine with the more detailed the exception messages. Though personally I don't see the necessity of using String.format(...) for those String and integer arguments, a simple concatenation might be good enough here. Are you interested to start from filing a new bug on this issue and

hg: jdk8/tl/jdk: 7157893: Warnings Cleanup in java.util.*

2012-04-17 Thread kurchi . subhra . hazra
Changeset: 1757f049e8c0 Author:khazra Date: 2012-04-17 12:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1757f049e8c0 7157893: Warnings Cleanup in java.util.* Summary: Minor code changes to cleanup warnings in java.util.* Reviewed-by: mduigou, naoto, smarks Contributed-by:

hg: jdk8/tl/jdk: 7152856: TEST_BUG: sun/net/www/protocol/jar/B4957695.java failing on Windows

2012-04-17 Thread kurchi . subhra . hazra
Changeset: 31c15e2f51ba Author:khazra Date: 2012-04-17 11:59 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31c15e2f51ba 7152856: TEST_BUG: sun/net/www/protocol/jar/B4957695.java failing on Windows Summary: Remove usage of HTTP Server at test/sun/net/www/httptest Reviewed-by:

hg: jdk8/tl/jdk: 7160380: Sync JDK8 with JAXP 1.4.5

2012-04-17 Thread huizhe . wang
Changeset: 6cf68360cfaf Author:joehw Date: 2012-04-17 11:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6cf68360cfaf 7160380: Sync JDK8 with JAXP 1.4.5 Summary: bring JDK8 up to date to what we have in 7u4 Reviewed-by: lancea, mullan ! src/share/lib/security/java.security

hg: jdk8/tl/jaxp: 7160380: Sync JDK8 with JAXP 1.4.5

2012-04-17 Thread huizhe . wang
Changeset: ceae213d9812 Author:joehw Date: 2012-04-17 11:17 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/ceae213d9812 7160380: Sync JDK8 with JAXP 1.4.5 Summary: bring JDK8 up to date to what we have in 7u4 Reviewed-by: lancea, mullan + src/com/sun/org/apache/xalan/intern

Re: Codereview request 7067045: replaceAll("\u20ac", "$"); causses java.lang.StringIndexOutOfBoundsExceptio

2012-04-17 Thread Paul Sandoz
Hi Sherman, Here is an example: http://cr.openjdk.java.net/~psandoz/errors-in-matcher/webrev.0/ I am not sure what, if any, are the JDK guidelines for stuffing information in exception messages. Paul. On Apr 16, 2012, at 10:24 AM, Paul Sandoz wrote: > Hi Sherman, > > IMHO it is worth spen

hg: jdk8/tl/jdk: 7159320: change default ZIP_DEBUGINFO_FILES back to '1' after fix for 7133529 is available

2012-04-17 Thread daniel . daugherty
Changeset: cce6147632cf Author:dcubed Date: 2012-04-17 09:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cce6147632cf 7159320: change default ZIP_DEBUGINFO_FILES back to '1' after fix for 7133529 is available Reviewed-by: ohair, jmelvin, sspitsyn ! make/common/Defs-linux

hg: jdk8/tl/jdk: 3 new changesets

2012-04-17 Thread staffan . larsen
Changeset: 869f53f58692 Author:sla Date: 2012-04-17 06:45 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/869f53f58692 7147848: com.sun.management.UnixOperatingSystem uses hardcoded dummy values [macosx] Summary: Provide the missing implementation UnixOperatingSystem on Mac O

Re: review request: 4244896: (process) Provide System.getPid(), System.killProcess(String pid)

2012-04-17 Thread Rob McKenna
New webrev at: http://cr.openjdk.java.net/~robm/4244896/webrev.01/ Differences: - implemented Process.waitFor(long timeout). I figured I'd throw it in and let you decide if you want to keep it / replace isAlive. - implemented defaults in Process.java - destroyForcibly now returns the Process o

Re: Reviewer needed: 6282196 There should be Math.mod(number, modulo) methods

2012-04-17 Thread Roger Riggs
I'm not sure have all the history around the Math vs StrictMath distinction. There are many cross references between Math and StrictMath for common functions, for example, ulp, getExponent, copySign, etc. The distinction is clearer for floating point operations than for int/log computations. Ro

hg: jdk8/tl/jdk: 7116200: (cs) test/java/nio/charset/coders/StreamTimeout.java fails with "Address already in use"

2012-04-17 Thread alan . bateman
Changeset: 9c1d7507ca37 Author:alanb Date: 2012-04-17 15:46 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9c1d7507ca37 7116200: (cs) test/java/nio/charset/coders/StreamTimeout.java fails with "Address already in use" Reviewed-by: alanb, chegar Contributed-by: jim.g...@oracl

hg: jdk8/tl/jdk: 7118373: (se) Potential leak file descriptor when deregistrating at around the same time as an async close

2012-04-17 Thread rob . mckenna
Changeset: b700f85a8f29 Author:robm Date: 2012-04-17 07:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b700f85a8f29 7118373: (se) Potential leak file descriptor when deregistrating at around the same time as an async close Reviewed-by: alanb ! src/share/classes/sun/nio/c

hg: jdk8/tl/jdk: 7015981: java.net.HttpCookie.domainMatches returns false if domain doesn't start with a dot

2012-04-17 Thread dmitry . degrave
Changeset: d09775066f8a Author:dmeetry Date: 2012-04-17 16:13 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d09775066f8a 7015981: java.net.HttpCookie.domainMatches returns false if domain doesn't start with a dot Reviewed-by: chegar ! src/share/classes/java/net/HttpCookie.

Re: Review for 7157656 (zipfs) SeekableByteChannel to entry in zip file...

2012-04-17 Thread Alan Bateman
"On 17/04/2012 11:28, Paul Sandoz wrote: : One thing I notice, and nothing to do with your patch, is that the position(long) method is missing an implementation, it shouldn't throw UOE. There is a comment: // sbc.position(pos) is not supported in current version in the test code. I put test c

Re: Review for 7157656 (zipfs) SeekableByteChannel to entry in zip file...

2012-04-17 Thread Paul Sandoz
On Apr 17, 2012, at 11:50 AM, Alan Bateman wrote: > On 16/04/2012 17:55, Paul Sandoz wrote: >> Hi, >> >> I ain't got permission to publish webrevs yet. So attached is a patch >> produced by hg export on the jdk tree for: >> >> 7157656 (zipfs) SeekableByteChannel to entry in zip file always r

Re: Review for 7157656 (zipfs) SeekableByteChannel to entry in zip file...

2012-04-17 Thread Alan Bateman
On 16/04/2012 17:55, Paul Sandoz wrote: Hi, I ain't got permission to publish webrevs yet. So attached is a patch produced by hg export on the jdk tree for: 7157656 (zipfs) SeekableByteChannel to entry in zip file always reports its position as 0 Paul. Sherman wrote this zip provider and

Re: Code Review Request - Bug #6948101 & 7142596: RMI JPRT tests are failing

2012-04-17 Thread Alan Bateman
On 16/04/2012 19:34, Darryl Mocek wrote: Ah, yes, with -agentvm specified, many tests fail. I'll have to add java/rmi and sun/rmi back to the list of tests which must be run in othervm mode and I should probably add back othervm to the tests I removed it from. At least with the port conflict

Re: sun.management.Agent: the properties.putAll API may fail with ConcurrentModifcationException on multi-thread scenario

2012-04-17 Thread Deven You
On 04/12/2012 10:09 AM, Mandy Chung wrote: On 4/11/2012 12:36 AM, Deven You wrote: Hi core-libs-devs, I am not sure if sun.management.Agent belongs to jmx-dev mailing list, if so please anyone tell me. serviceability-dev (cc'ed) is the mailing list for this patch. This issue is that the