hg: jdk8/tl/jdk: 39 new changesets

Changeset: c2d9166f3284 Author:ihse Date: 2012-05-11 08:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c2d9166f3284 7168208: Change use of @ in one sed command involving paths to different character Reviewed-by: ohair ! make/common/Release.gmk Changeset: 8d665b69ebf1 Au

hg: jdk8/tl/hotspot: 32 new changesets

Changeset: 36538fd1225e Author:amurillo Date: 2012-05-04 15:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/36538fd1225e 7166615: new hotspot build - hs24-b10 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 8bafad97cd26 Author:jiangli Date: 2012-05-02

hg: jdk8/tl: 5 new changesets

Changeset: 955a3e8ed4f0 Author:ohair Date: 2012-05-10 08:26 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/955a3e8ed4f0 7167593: Changed get_source.sh to allow for getting full oracle jdk repo forest Reviewed-by: erikj, asaha, chegar, sla, dholmes, mbykov, coleenp ! get_source.s

hg: jdk8/tl/langtools: 4 new changesets

Changeset: 8b869afd2eb4 Author:katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8b869afd2eb4 Added tag jdk8-b39 for changeset a9f547c218d9 ! .hgtags Changeset: 86e0dad6aadf Author:lana Date: 2012-05-21 11:44 -0700 URL: http

hg: jdk8/tl/corba: 2 new changesets

Changeset: 56d030e5035f Author:katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/56d030e5035f Added tag jdk8-b39 for changeset 785af00e2827 ! .hgtags Changeset: 113f0d5f0a08 Author:katleman Date: 2012-05-24 16:15 -0700 URL: http

hg: jdk8/tl/jaxws: 2 new changesets

Changeset: 09a0ddda03cb Author:katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/09a0ddda03cb Added tag jdk8-b39 for changeset 7f6b44fd3034 ! .hgtags Changeset: f2072b164b05 Author:katleman Date: 2012-05-24 16:15 -0700 URL: http

hg: jdk8/tl/jaxp: 2 new changesets

Changeset: 9ecfdbd6aed4 Author:katleman Date: 2012-05-17 06:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/9ecfdbd6aed4 Added tag jdk8-b39 for changeset f95fdbe525c8 ! .hgtags Changeset: 6f5c0e17415d Author:katleman Date: 2012-05-24 16:15 -0700 URL: http:

Re: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps

Am 23.05.2012 07:16, schrieb Mike Duigou: Webrevs for the Java 7u6 and 8 changes are available for download at [2] and [3] for your review. There are some important differences between the Java 7 and 8 implementations of this enhancement. Most specifically in the Java 8 implementation alternat

Re: Review request for CR 171917 CachedRowSetImpl.populate does not handle map properly

Hi Dave, No, I should be able to make that change. Thanks for the suggestion. Once I do and rerun the unit tests, jck and sqe, I will send the diff back out. Best Lance On May 25, 2012, at 7:35 PM, David Schlosnagle wrote: > On Fri, May 25, 2012 at 3:50 PM, Lance Andersen - Oracle > wrote: >

Re: Review request for CR 171917 CachedRowSetImpl.populate does not handle map properly

On Fri, May 25, 2012 at 3:50 PM, Lance Andersen - Oracle wrote: > The populate() method needs to check for a size of 0 for the map in case a > webrowset xml file has an empty map tag,  which would result in calling > setobject specifying a map and not all databases/drivers support this. > > simp

Re: Re : Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps [private fields]

Agreed on JDK code, but since accessors are also generated for access to outer class' private fields/methods from inner class, wouldn't want people to increase visibility of those fields/methods just to get rid of the accessors in their own code thinking that there are serious problems associated w

Re: Request for Review : CR#6924259: Remove String.count/String.offset

Am 25.05.2012 17:05, schrieb Jim Gish: On 05/25/2012 09:48 AM, Mike Duigou wrote: I too mostly prefer casts without a space. The code was reformatted with an IDE because I'm actually terrible about being consistent in my formatting. Mechanically formatted code, like mechanically separated meat,

Re: Request for Review : CR#6924259: Remove String.count/String.offset

On 05/26/2012 12:09 AM, Mike Duigou wrote: On May 25 2012, at 06:57 , Rémi Forax wrote: Hi Mike, Hi Alan, Hi all, in my opinion, EMPTY_STRING_VALUE is a premature optimization, the idea is, I think, to avoid to create an empty char but if you want to do that, it's better to do that in StringBu

Re: Re : Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps [private fields]

On 05/26/2012 12:17 AM, Vitaly Davidovich wrote: I assume you're referring to instanceKlass::_host_klass? The comment on that field says it's only non-null for an anonymous class, no mention of named inner classes. Are you sure it's used for named inner classes to point back to their parent?

Re: Re : Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps [private fields]

On 05/26/2012 12:09 AM, Vitaly Davidovich wrote: Yes, methods/constructors as well - I should've pointed that out but only answered the field question that was originally asked. Valid points on metadata and stack pollution, although a bit pedantic for real code :). given that this code i

Re: Re : Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps [private fields]

I assume you're referring to instanceKlass::_host_klass? The comment on that field says it's only non-null for an anonymous class, no mention of named inner classes. Are you sure it's used for named inner classes to point back to their parent? Cheers Sent from my phone On May 25, 2012 6:06 PM, "

Re: Re : Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps [private fields]

Yes, methods/constructors as well - I should've pointed that out but only answered the field question that was originally asked. Valid points on metadata and stack pollution, although a bit pedantic for real code :). Thanks Sent from my phone On May 25, 2012 6:03 PM, "Rémi Forax" wrote: > On 0

Re: Request for Review : CR#6924259: Remove String.count/String.offset

On May 25 2012, at 06:57 , Rémi Forax wrote: > Hi Mike, Hi Alan, Hi all, > in my opinion, EMPTY_STRING_VALUE is a premature optimization, > the idea is, I think, to avoid to create an empty char but if you want to do > that, > it's better to do that in StringBuilder.toString() to avoid to create

Re: Re : Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps [private fields]

On 05/25/2012 11:55 PM, Vitaly Davidovich wrote: In case it's not clear, by JVM not allowing them I simply mean that it doesn't know about nested classes (not a first class concept), so since it's emulated by javac, javac creates these package private synthetic accessors. BTW, the VM knows what

Re: Re : Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps [private fields]

On 05/25/2012 11:50 PM, Vitaly Davidovich wrote: This is specific to private fields in inner classes - and methods and constructors java allows access to them from the outer class, but the JVM doesn't so javac generates synthetic accessor methods for them. Don't think it's a problem for JIT

Re: Re : Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps [private fields]

In case it's not clear, by JVM not allowing them I simply mean that it doesn't know about nested classes (not a first class concept), so since it's emulated by javac, javac creates these package private synthetic accessors. Sent from my phone On May 25, 2012 5:50 PM, "Vitaly Davidovich" wrote: >

Re: Re : Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps [private fields]

This is specific to private fields in inner classes - java allows access to them from the outer class, but the JVM doesn't so javac generates synthetic accessor methods for them. Don't think it's a problem for JIT compiler though as it should inline them. Sent from my phone On May 25, 2012 5:23 P

Re: Re : Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps [private fields]

Am 25.05.2012 22:30, schrieb Jeff Hain: Hello. In HashMap, the class Holder should not declare the static final fields 'private' because the compiler will generate an accessor in that case, I wasn't aware that making fields private could have a downside (other than making them non-visible). C

Re : Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps [private fields]

Hello. >In HashMap, the class Holder should not declare the static final fields >'private' because the compiler will generate an accessor in that case, I wasn't aware that making fields private could have a downside (other than making them non-visible). Could you, or anyone, please give (a link

Review request CR 7171918 XmlReaderContentHandler.endElement does not handle a Delete Tag properly

Attached is the fix for 7171918. If a WebRowSet is written to disk that contains a row marked for deletion and then read back into a WebRowSet, it was not marked again as a deleted row. Here is the fix to endElement() to address this. hg diff XmlReaderContentHandler.java diff -r 4580652d982

Review request for CR 171917 CachedRowSetImpl.populate does not handle map properly

Attached is the fix for bug 171917 . The populate() method needs to check for a size of 0 for the map in case a webrowset xml file has an empty map tag, which would result in calling setobject specifying a map and not all databases/drivers support this. simple 1 line change: hg diff CachedRow

hg: jdk8/tl/jdk: 7170449: Management is completely broken at least on Solaris 11 X86

Changeset: 82134992123c Author:dcubed Date: 2012-05-25 08:20 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/82134992123c 7170449: Management is completely broken at least on Solaris 11 X86 Summary: Work around 'gobjcopy' failures on Solaris by adding temporary tools to add t

Re: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps

On 05/24/2012 09:34 PM, Mike Duigou wrote: Hello All; I have updated the webrevs for alternative hashing for String with feedback from Remi, Doug, Ulf and internal reviewers. Additional feedback is welcome. Mike [1] althashing "7" webrev : http://cr.openjdk.java.net/~mduigou/althashing7/9/w

Re: Request for Review : CR#6924259: Remove String.count/String.offset

>> On 24/05/2012 21:45, Mike Duigou wrote: >>> >>> Hello all; >>> >>> For a long time preparations and planing have been underway to remove the >>> offset and count fields from java.lang.String. These two fields enable >>> multiple String instances to share the same backing character buffer. Shared

Re: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps

On 05/25/2012 04:41 AM, Krystal Mok wrote: Hi Mike, On Fri, May 25, 2012 at 10:12 AM, Mike Duigouwrote: On May 24 2012, at 16:32 , Vitaly Davidovich wrote: That's a bit odd as I thought the Klass object in the VM stored something like 7 supers, which includes interfaces (if I'm not mistaken

Please review: 7168401: pack200 does not produce a compatible pack file

Hi, Please review, changes has been internally reviewed by John. http://cr.openjdk.java.net/~ksrini/7168401/webrev.0/ Thanks Kumar

Re: Request for Review : CR#6924259: Remove String.count/String.offset

On 05/25/2012 09:48 AM, Mike Duigou wrote: A non-material comment is that there are a couple of style changes that I found annoying. Everyone is an expert on such matters, I'm not, but the one that bugged me a bit was adding the space after the cast, eg: (toffset> (long) value.length - len) I

hg: jdk8/tl/jdk: 7171474: Incorrect @see tags in java.lang.NumberFormatException javadoc

Changeset: f92325f12654 Author:jgish Date: 2012-05-24 11:11 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f92325f12654 7171474: Incorrect @see tags in java.lang.NumberFormatException javadoc Summary: update javadoc for NumberFormatException Reviewed-by: alanb ! src/share/cl

Re: Request for Review : CR#6924259: Remove String.count/String.offset

Hi Mike, Hi Alan, Hi all, in my opinion, EMPTY_STRING_VALUE is a premature optimization, the idea is, I think, to avoid to create an empty char but if you want to do that, it's better to do that in StringBuilder.toString() to avoid to create the String at all. I'm worried about one pathologica

Re: Request for Review : CR#6924259: Remove String.count/String.offset

> A non-material comment is that there are a couple of style changes that I > found annoying. Everyone is an expert on such matters, I'm not, but the one > that bugged me a bit was adding the space after the cast, eg: > (toffset > (long) value.length - len) > I found myself needing to re-read it

Space notation for cast

Am 25.05.2012 14:08, schrieb Alan Bateman: A non-material comment is that there are a couple of style changes that I found annoying. Everyone is an expert on such matters, I'm not, but the one that bugged me a bit was adding the space after the cast, eg: (toffset > (long) value.length - len) I

hg: jdk8/tl/jdk: 7017818: NLS: JConsoleResources.java cannot be handled by translation team

Changeset: 1def6b6bfbd9 Author:egahlin Date: 2012-05-25 12:24 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1def6b6bfbd9 7017818: NLS: JConsoleResources.java cannot be handled by translation team Reviewed-by: mchung, mfang ! make/netbeans/jconsole/build.xml ! make/sun/jcons

Re: Request for Review : CR#6924259: Remove String.count/String.offset

On 24/05/2012 21:45, Mike Duigou wrote: Hello all; For a long time preparations and planing have been underway to remove the offset and count fields from java.lang.String. These two fields enable multiple String instances to share the same backing character buffer. Shared character buffers wer

Re: hg: jdk8/tl/jdk: 7094176: (tz) Incorrect TimeZone display name when DST not applicable / disabled

On 25/05/2012 11:05, Masayoshi Okutsu wrote: Another option would be to write a native program to change the system setup and run a Java program to detect the change. But it requires the administrator privilege and is a bit risky. A test failure may leave a test machine in an unusual state.

Re: hg: jdk8/tl/jdk: 7094176: (tz) Incorrect TimeZone display name when DST not applicable / disabled

On 5/25/2012 6:37 PM, Alan Bateman wrote: On 25/05/2012 10:32, Masayoshi Okutsu wrote: Hi Deven, Sorry. I didn't review the test case... You can use applet to write a manual test. You will find some manual tests under test/java/awt such as: test/java/awt/TextField/ScrollSelectionTest/Scroll

Re: Request for Review : CR#6924259: Remove String.count/String.offset

Am 25.05.2012 01:11, schrieb Mike Duigou: On May 24 2012, at 15:56 , Ulf Zibis wrote: Am 24.05.2012 22:45, schrieb Mike Duigou: A patch of the changes to java.lang.String for JDK 8 are at. The changes for JDK 7 have only superficial diff

Re: hg: jdk8/tl/jdk: 7094176: (tz) Incorrect TimeZone display name when DST not applicable / disabled

On 25/05/2012 10:32, Masayoshi Okutsu wrote: Hi Deven, Sorry. I didn't review the test case... You can use applet to write a manual test. You will find some manual tests under test/java/awt such as: test/java/awt/TextField/ScrollSelectionTest/ScrollSelectionTest.{html,java} Thanks, Masay

Re: hg: jdk8/tl/jdk: 7094176: (tz) Incorrect TimeZone display name when DST not applicable / disabled

Hi Deven, Sorry. I didn't review the test case... You can use applet to write a manual test. You will find some manual tests under test/java/awt such as: test/java/awt/TextField/ScrollSelectionTest/ScrollSelectionTest.{html,java} Thanks, Masayoshi On 5/25/2012 4:41 PM, Deven You wrote: Hi

Re: hg: jdk8/tl/jdk: 7094176: (tz) Incorrect TimeZone display name when DST not applicable / disabled

Hi Alan, Thanks for your reminder, I was going to point that this a manual test case and need someone guide me how to configure it as manual with jtreg. But I missed it by chance. So Masayoshi or someone else, I'd very appreciate if you could guide me how to configure a test case as manual i

Re: hg: jdk8/tl/jdk: 7094176: (tz) Incorrect TimeZone display name when DST not applicable / disabled

Deven, The test with this fix seems to be a manual test but doesn't seem to be tagged as such (/manual). I assume this means it will fail on all platforms. Do you mind re-examining it? Masayoshi may have some advice on how configuration like this can be tested. It may be that it's just not po