Re: Patch review request - Test bug 7123972 test/java/lang/annotation/loaderLeak/Main.java fails intermittently

Hi Eric, On 21/06/2012 4:05 PM, Eric Wang wrote: I come from Java SQE team who are interested in regression test bug fix. Here is the first simple fix for bug 7123972 , Can you please help to review and comment? Attachment is the patch Thanks!

Patch review request - Test bug 7123972 test/java/lang/annotation/loaderLeak/Main.java fails intermittently

Hi All, I come from Java SQE team who are interested in regression test bug fix. Here is the first simple fix for bug 7123972 , Can you please help to review and comment? Attachment is the patch Thanks! This bug is caused by wrong assumption

hg: jdk8/tl/jdk: 7178483: Change version string for Embedded releases

Changeset: dfe5617c18b4 Author:dholmes Date: 2012-06-20 22:40 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dfe5617c18b4 7178483: Change version string for Embedded releases Reviewed-by: dholmes, lancea Contributed-by: Gary Collins ! make/common/Defs-embedded.gmk

Re: Trivial review: 7178483 - Change of Embedded version string

Looks OK David On Jun 20, 2012, at 9:41 PM, David Holmes wrote: > Trivial change to the Defs-embedded.gmk build file to change the version > string used for SE Embedded. > > http://cr.openjdk.java.net/~dholmes/7178483/webrev/ > > or see below. > > Contributed by Gary Collins, and reviewed by m

Trivial review: 7178483 - Change of Embedded version string

Trivial change to the Defs-embedded.gmk build file to change the version string used for SE Embedded. http://cr.openjdk.java.net/~dholmes/7178483/webrev/ or see below. Contributed by Gary Collins, and reviewed by myself. I'd appreciate one TL reviewer as I will push to TL. Thanks, David di

hg: jdk8/tl/langtools: 7174143: encapsulate doc comment table

Changeset: 5c0b3faeb0b0 Author:jjg Date: 2012-06-20 13:23 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5c0b3faeb0b0 7174143: encapsulate doc comment table Reviewed-by: ksrini, mcimadamore ! src/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/share/classes

Re: Bug 7176907 - Patches for javac warnings cleanup (text and util) from Adopt OpenJDK

We'll look into it, hopefully have an answer for you shortly - M On 20 June 2012 17:07, Kurchi Subhra Hazra wrote: > Hi, > >   I was just going through the patches, there are some more fallthrough > cases in > src/share/classes/java/util/regex/Pattern.java.(for example in line 2247). > Are these

Re: Bug 7176907 - Patches for javac warnings cleanup (text and util) from Adopt OpenJDK

Hi, I was just going through the patches, there are some more fallthrough cases in src/share/classes/java/util/regex/Pattern.java.(for example in line 2247). Are these not generating warnings? - Kurchi On 6/20/12 7:30 AM, Martijn Verburg wrote: Hi all, Apologies, I didn't check that atta

Re: Bug 7176907 - Patches for javac warnings cleanup (text and util) from Adopt OpenJDK

Hi Remi, On 20 June 2012 15:08, Rémi Forax wrote: > On 06/20/2012 01:51 PM, Martijn Verburg wrote: >> >> Hi all, >> >> Apologies, I didn't check that attachments were stripped.  The patches >> can be found at: >> >> >> https://raw.github.com/AdoptOpenJDK/PatchReview/master/submitted/core_java_tex

Re: Bug 7176907 - Patches for javac warnings cleanup (text and util) from Adopt OpenJDK

On 06/20/2012 01:51 PM, Martijn Verburg wrote: Hi all, Apologies, I didn't check that attachments were stripped. The patches can be found at: https://raw.github.com/AdoptOpenJDK/PatchReview/master/submitted/core_java_text.patch https://raw.github.com/AdoptOpenJDK/PatchReview/master/submitted/c

Re: Bug 7176907 - Patches for javac warnings cleanup (text and util) from Adopt OpenJDK

Hi all, Apologies, I didn't check that attachments were stripped. The patches can be found at: https://raw.github.com/AdoptOpenJDK/PatchReview/master/submitted/core_java_text.patch https://raw.github.com/AdoptOpenJDK/PatchReview/master/submitted/core_java_util.patch Cheers, Martijn On 20 June

Bug 7176907 - Patches for javac warnings cleanup (text and util) from Adopt OpenJDK

Hi Stuart, As requested - attached are 2 patch files, one covering util, the other text. I'm aware some fixes did go in recently, so if these patches are out of date and need re-spinning, then please let me know. Cheers, Martijn (on behalf of Adopt OpenJDK)