Hi Remi, On 20 June 2012 15:08, Rémi Forax <fo...@univ-mlv.fr> wrote: > On 06/20/2012 01:51 PM, Martijn Verburg wrote: >> >> Hi all, >> >> Apologies, I didn't check that attachments were stripped. The patches >> can be found at: >> >> >> https://raw.github.com/AdoptOpenJDK/PatchReview/master/submitted/core_java_text.patch >> >> https://raw.github.com/AdoptOpenJDK/PatchReview/master/submitted/core_java_util.patch >> >> Cheers, >> Martijn > > > Hi Martijn, > the two patches looks good. > > A minor nit, why is there a space between the '(' and the readUByte() in > readUShort.
Thanks for the quick review! No reason on the whitespace, I've fixed that now. Quick question. Is there a checkstyle or jcheck that we should be applying to any corelib patches going forwards? Cheers, Martijn
