Re: Patch review request - Test bug 7123972 test/java/lang/annotation/loaderLeak/Main.java fails intermittently

Hi Alan, Looks that the core-libs-dev group rejects zip file, so i reattached the patches again, can you please help to review? There's another bug 6948101 which is caused by same reason as this one, I'll send the fix in another mail thread.

[PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

Hi All, Please help to review the fix attached for test bug 6948101 which is same root cause as bug 7123972 . The test makes wrong assumption that GC is started immediately to recycle unused

hg: jdk8/tl/jdk: 4244896: (process) Provide System.getPid(), System.killProcess(String pid)

Changeset: ff0da4ea08a2 Author:robm Date: 2012-06-26 13:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ff0da4ea08a2 4244896: (process) Provide System.getPid(), System.killProcess(String pid) Reviewed-by: alanb ! src/share/classes/java/lang/Process.java ! src/solaris/class

Re: review request: 4244896: (process) Provide System.getPid(), System.killProcess(String pid)

Thanks Thomas, As per Alan's mail, we're going to deal with this as a separate issue after we've discussed it. -Rob On 25/06/12 10:52, Alan Bateman wrote: On 25/06/2012 09:56, Thomas Stüfe wrote: Hi, Rob, src/solaris/native/java/lang/UNIXProcess_md.c: You never check the return code o

Re: String.subSequence and CR#6924259: Remove offset and count fields from java.lang.String

If String.substring(int, int) now performs a copy of the underlying char[] array and if there is no String.subSequence(int, int) providing the old functionality, maybe the following implications should be investigated? StringBuilder.append(...) Since, in order to avoid a

Re: Fwd: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

On 26/06/2012 07:00, Xueming Shen wrote: On 6/25/12 10:58 PM, Xueming Shen wrote: Hi, While I still believe that case-insensitive is the right choice for File/Path on MacOSX, it is suggested that we might want to be a little conservative in this patch, with the assumption that this patch will

Re: RFR: 7161229 - PriorityBlockingQueue keeps hard reference to last removed element

On 25/06/2012 05:26, David Holmes wrote: webrev: http://cr.openjdk.java.net/~dholmes/7161229/webrev/ When removing the last element from the PBQ the "sift down" logic would store it back in as array[0]. The simple fix is for the sift-down to be a no-op if the queue size is zero. The fix has

Re: String.subSequence and CR#6924259: Remove offset and count fields from java.lang.String

On Jun 26 2012, at 07:13 , Martin Desruisseaux wrote: > If String.substring(int, int) now performs a copy of the underlying char[] > array and if there is no String.subSequence(int, int) providing the old > functionality, maybe the following implications should be investigated? > > > StringBu

Re: Bug 7176907 - Patches for javac warnings cleanup (text and util) from Adopt OpenJDK

Thanks for updating this. This looks good to me. I guess Stuart will be sponsoring the patch. There are a couple of other switch statements in src/share/classes/java/util/regex/Pattern.java. which are not throwing fallthrough warnings (in Netbeans at least), although there is fallthrough happ

Re: String.subSequence and CR#6924259: Remove offset and count fields from java.lang.String

Le 26/06/12 20:10, Mike Duigou a écrit : StringBuilder.append(string.substring(lower, upper)); by: StringBuilder.append(string, lower, upper); This would seem to be a good refactoring regardless of the substring implementation as it avoids creation of a temporary object. The ratio

Code Review Request: 7160252: (prefs) NodeAddedEvent was not delivered when new node add when new Node

Hi, On Mac OS X, for Preferences, a new child added event was not being delivered to a NodeChangeListener since the existing code depended on the return value of addNode() in the native code, which returns true if a new node is added. However, since addNode() was being called erroneously aft

Re: [PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

Hi Eric, On 26/06/2012 7:26 PM, Eric Wang wrote: Please help to review the fix attached for test bug 6948101 which is same root cause as bug 7123972 . The test makes wrong assumption that GC is

Re: RFR [7u6]: 7166896: DocumentBuilder.parse(String uri) is not IPv6 enabled. It throws MalformedURLException

Hi Paul, That method was contributed by engineers from Korea and intended to handle paths that contained international characters, so that was how it was named. It was an extra processing added. Outside of that scenario, we'd want to skip the process and get back to letting URL handle the in

Re: Patch review request - Test bug 7123972 test/java/lang/annotation/loaderLeak/Main.java fails intermittently

Thanks Eric. So to summarize: - we create a custom classloader, load a class through it and store a reference to that Class in a WeakReference - we then drop the reference to the loader At this point the only reference to the loader is from the Class loaded, which in turn is only weakly reac

hg: jdk8/tl/jaxp: 7166896: DocumentBuilder.parse(String uri) is not IPv6 enabled. It throws MalformedURLException

Changeset: 7920ead2cc75 Author:joehw Date: 2012-06-26 15:28 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/7920ead2cc75 7166896: DocumentBuilder.parse(String uri) is not IPv6 enabled. It throws MalformedURLException Summary: skip the added international character handling f

Re: [PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

Hi Eric, Alan Bateman asked me to help you out with this since he's going to be unavailable for a couple weeks. I didn't see you on the OpenJDK census [1] so you might not have an Author role and thus the ability to post webrevs. If indeed you don't, I can post a webrev for you. I can also p

Re: Fwd: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

Alan, Webrev has been updated accordingly at http://cr.openjdk.java.net/~sherman/7130915/webrev with changes (1) added a CFStringCreateMutable(...) != null check in both io and nio native, though it is unlikely to fail here because we are passing a NULL and 0 length, like new StringBui

Re: RFR: 7161229 - PriorityBlockingQueue keeps hard reference to last removed element

On 27/06/2012 2:35 AM, Alan Bateman wrote: On 25/06/2012 05:26, David Holmes wrote: webrev: http://cr.openjdk.java.net/~dholmes/7161229/webrev/ When removing the last element from the PBQ the "sift down" logic would store it back in as array[0]. The simple fix is for the sift-down to be a no-o

hg: jdk8/tl/jdk: 7161229: PriorityBlockingQueue keeps hard reference to last removed element

Changeset: 94b525ce3653 Author:dholmes Date: 2012-06-27 01:36 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/94b525ce3653 7161229: PriorityBlockingQueue keeps hard reference to last removed element Reviewed-by: dholmes, forax, alanb Contributed-by: Doug Lea ! src/share/clas

Re: Patch review request - Test bug 7123972 test/java/lang/annotation/loaderLeak/Main.java fails intermittently

Eric, Ignore my comment about adding the timeouts. As Alan reminded me if the test would hang then jtreg will time it out after two minutes anyway. So this is good to go as far as I am concerned. Thanks, David On 27/06/2012 7:51 AM, David Holmes wrote: Thanks Eric. So to summarize: - we c

Re: Fwd: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

On 27/06/2012 04:33, Xueming Shen wrote: Alan, Webrev has been updated accordingly at http://cr.openjdk.java.net/~sherman/7130915/webrev with changes (1) added a CFStringCreateMutable(...) != null check in both io and nio native, though it is unlikely to fail here because we are passin

Re: RFR [7u6]: 7166896: DocumentBuilder.parse(String uri) is not IPv6 enabled. It throws MalformedURLException

Hi, On Jun 26, 2012, at 11:59 PM, Joe Wang wrote: > Hi Paul, > > That method was contributed by engineers from Korea and intended to handle > paths that contained international characters, so that was how it was named. > It was an extra processing added. Outside of that scenario, we'd want to

Re: Patch review request - Test bug 7123972 test/java/lang/annotation/loaderLeak/Main.java fails intermittently

Hi David, Thank you! I run the test several times on 3 platforms (windows, solaris and linux), the average execution time is 30secs to 60secs. if the test hang 2 minutes, there should be something wrong. Hi Marks, I don't have the author role, Can you please help to review and post the webr

Re: [PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

Hi David & Stuart, Thank you for the help! please review the in webrev 6948101.zip in attachment. Regards, Eric On 2012/6/27 9:14, Stuart Marks wrote: Hi Eric, Alan Bateman asked me to help you out with this since he's going to be unavailable for a couple weeks. I didn't see you on the O