Re: Fwd: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-27 Thread Xueming Shen
Thanks Alan! The webrev has been updated to throw OOME as your other nio native dispatcher does. http://cr.openjdk.java.net/~sherman/7130915/webrev. I can wait for your back from the vacation:-) -Sherman On 6/26/12 11:41 PM, Alan Bateman wrote: On 27/06/2012 04:33, Xueming Shen wrote: Al

hg: jdk8/tl/jaxws: Added tag jdk8-b44 for changeset f6a417540ef1

2012-06-27 Thread lana . steuck
Changeset: e80ac58b5ba9 Author:katleman Date: 2012-06-21 17:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/e80ac58b5ba9 Added tag jdk8-b44 for changeset f6a417540ef1 ! .hgtags

hg: jdk8/tl/corba: 9 new changesets

2012-06-27 Thread lana . steuck
Changeset: ad3ba4b392cc Author:katleman Date: 2012-06-21 17:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/ad3ba4b392cc Added tag jdk8-b44 for changeset 439d9bf8e4ff ! .hgtags Changeset: 5222b7d658d4 Author:coffeys Date: 2012-03-26 14:01 +0100 URL: http:

hg: jdk8/tl/langtools: 2 new changesets

2012-06-27 Thread lana . steuck
Changeset: a39c99192184 Author:katleman Date: 2012-06-21 17:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a39c99192184 Added tag jdk8-b44 for changeset 59cbead12ff4 ! .hgtags Changeset: e111e4587cca Author:lana Date: 2012-06-25 21:39 -0700 URL: http

hg: jdk8/tl: 4 new changesets

2012-06-27 Thread lana . steuck
Changeset: 8fb4cd2f05a1 Author:mbykov Date: 2012-06-19 14:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/8fb4cd2f05a1 7178241: Basic script for JDK source code legal headers conformance verification Summary: A new script lic_check.sh to check license headers in JDK source code

hg: jdk8/tl/hotspot: 45 new changesets

2012-06-27 Thread lana . steuck
Changeset: 6e2633440960 Author:amurillo Date: 2012-06-01 15:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/6e2633440960 7173438: new hotspot build - hs24-b14 Reviewed-by: jcoomes ! make/hotspot_version Changeset: fab99b17c1de Author:mikael Date: 2012-06-01 2

hg: jdk8/tl/jdk: 36 new changesets

2012-06-27 Thread lana . steuck
Changeset: 9d88f2ce6338 Author:katleman Date: 2012-06-21 17:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9d88f2ce6338 Added tag jdk8-b44 for changeset db471a7af031 ! .hgtags Changeset: eb50eeb2eb7d Author:prr Date: 2012-06-13 12:46 -0700 URL: http://hg.o

Re: [PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

2012-06-27 Thread David Holmes
On 27/06/2012 4:57 PM, Eric Wang wrote: Hi David & Stuart, Thank you for the help! please review the in webrev 6948101.zip in attachment. Thanks Eric. That fix also seems fine to me. David Regards, Eric On 2012/6/27 9:14, Stuart Marks wrote: Hi Eric, Alan Bateman asked me to help you ou

Re: Bug 7176907 - Patches for javac warnings cleanup (text and util) from Adopt OpenJDK

2012-06-27 Thread Martijn Verburg
Hi Kurchi, > Thanks for updating this. This looks good to me. I guess Stuart will be > sponsoring the patch. For his sins he's kindly offered to do so yes :-) > There are a couple of other switch statements in >  src/share/classes/java/util/regex/Pattern.java. > which are not throwing fallthroug

Re: [PATCH] Review Request - Test bug: 6948101 java/rmi/transport/pinLastArguments/PinLastArguments.java failing intermittently

2012-06-27 Thread Eric Wang
Hi David, Thank you for review! Hi Stuart, Can you please help to review and post the webrev, Thanks a lot! Eric On 2012/6/27 15:32, David Holmes wrote: On 27/06/2012 4:57 PM, Eric Wang wrote: Hi David & Stuart, Thank you for the help! please review the in webrev 6948101.zip in attachment.

Re: Bug 7176907 - Patches for javac warnings cleanup (text and util) from Adopt OpenJDK

2012-06-27 Thread Martijn Verburg
Hi all, We've been working on improving the workflow for our patch review system and so the new locations for the patches are at: https://raw.github.com/AdoptOpenJDK/PatchReview/master/5-submitted/javac_warnings/core_java_text.patch https://raw.github.com/AdoptOpenJDK/PatchReview/master/5-submitt

Re: RFR : 7162902 / 6893617 Umbrella port of a number of corba bug fixes from JDK 6 to jdk7u/8

2012-06-27 Thread Lance Andersen - Oracle
Hi Sean, I think this looks good. ship it :-) Best Lance On Jun 25, 2012, at 4:26 PM, Sean Coffey wrote: > Hi, > > I'm looking for a code review around the following corba changes. It turns > out that we've a few bug fixes in corba area for jdk6 that were never forward > ported to jdk7 or 8.

Re: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-27 Thread David Kocher
I welcome this issue is getting some serious attention then. When will this be backported to 7u? -- David On 24.06.2012, at 18:58, Xueming Shen wrote: > > Yes, I believe the issue described in MACOSX_PORT-165 is the > same issue this patch is trying to solve. > > Btw, it appears there are typ

Re: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-27 Thread David Kocher
Will this address issue MACOSX_PORT-165 [1]? [1] http://java.net/jira/browse/MACOSX_PORT-165 -- David On 22.06.2012, at 19:01, Xueming Shen wrote: > Hi > > Here is the proposed change to support Unicode nfd/nfc and case insensitive > file path on MacOSX file system. > > 7130915: File.equals

Re: Codereview request for 7130915: File.equals does not give expected results when path contains Non-English characters on Mac OS X

2012-06-27 Thread Gregg Wonderly
On Jun 26, 2012, at 10:02 AM, Alan Bateman wrote: > > Do the tests assume they are run on HFS? Just wondering if you you need to > look at the FileStore name/type to check. TensComplement's ZFS port (ZEVO) to MacOSX may need some consideration if HFS is going to be the only test bed. Gregg W

Re: String.subSequence and CR#6924259: Remove offset and count fields from java.lang.String

2012-06-27 Thread Peter Levart
Hi Mike, Yes, all that you say below is true. CharSequence is an interface that does not define the contract of identity when implementations/subtypes of CharSequence do - each in it's own way. Much like java.util.Collection and List vs. Set. It's always dangerous for methods that return such i

hg: jdk8/tl/jdk: 6893617: JDK 6 CNCtx always uses the default ORB

2012-06-27 Thread sean . coffey
Changeset: 612e56cf284c Author:coffeys Date: 2012-06-27 21:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/612e56cf284c 6893617: JDK 6 CNCtx always uses the default ORB Reviewed-by: lancea ! src/share/classes/com/sun/jndi/cosnaming/CNCtx.java

hg: jdk8/tl/corba: 7162902: Umbrella port of a number of corba bug fixes from JDK 6 to jdk7u/8

2012-06-27 Thread sean . coffey
Changeset: 47adb42076f1 Author:coffeys Date: 2012-06-27 21:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/47adb42076f1 7162902: Umbrella port of a number of corba bug fixes from JDK 6 to jdk7u/8 Reviewed-by: lancea ! src/share/classes/com/sun/corba/se/impl/encoding/Cach

Re: Patch review request - Test bug 7123972 test/java/lang/annotation/loaderLeak/Main.java fails intermittently

2012-06-27 Thread Stuart Marks
I've posted the webrev here: http://cr.openjdk.java.net/~smarks/yiming.wang/7123972/webrev.0/ I've looked at the changes and they seem fine. It's interesting that the run times take 30-60 sec in your experience. I've run them on my system (Linux in a virtual machine) and they usually run in 10

Re: Patch review request - Test bug 7123972 test/java/lang/annotation/loaderLeak/Main.java fails intermittently

2012-06-27 Thread Eric Wang
Hi Stuart, Thank you for help to publish the fix, my pleasure to contribute to OpenJDK project. Thanks, Eric On 2012/6/28 12:40, Stuart Marks wrote: I've posted the webrev here: http://cr.openjdk.java.net/~smarks/yiming.wang/7123972/webrev.0/ I've looked at the changes and they seem fine.