Hi all, We've been working on improving the workflow for our patch review system and so the new locations for the patches are at:
https://raw.github.com/AdoptOpenJDK/PatchReview/master/5-submitted/javac_warnings/core_java_text.patch https://raw.github.com/AdoptOpenJDK/PatchReview/master/5-submitted/javac_warnings/core_java_util.patch Cheers, Martijn On 27 June 2012 08:58, Martijn Verburg <martijnverb...@gmail.com> wrote: > Hi Kurchi, > >> Thanks for updating this. This looks good to me. I guess Stuart will be >> sponsoring the patch. > > For his sins he's kindly offered to do so yes :-) > >> There are a couple of other switch statements in >> src/share/classes/java/util/regex/Pattern.java. >> which are not throwing fallthrough warnings (in Netbeans at least), >> although there is fallthrough happening from one case to another. From what >> I notice, only if there is a break statement >> missing before the "default" case, does Netbeans throw some warning. Is the >> fallthrough warning technically >> supposed to be thrown only when the logic falls through to the default case >> then? > > That's my understanding with the javac compiler yes. I think it was the > balance > that the javac folk thought was a sensible compromise in terms of not > generating > too many false positive warnings. > > Cheers, > Martijn
