Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-05 Thread Xueming Shen
On 8/5/2012 2:00 PM, Alan Bateman wrote: On 03/08/2012 19:33, Andrew Hughes wrote: : http://cr.openjdk.java.net/~andrew/syslibs/zlib/webrev.02/ is an updated version which checks if ZLIB_LIBS is set on Solaris, GNU/Linux and MacOS X and sets it to -lz if not. I wasn't sure what to do with W

Re: Improve registering signal handlers in java.lang.Terminator.setup()

2012-08-05 Thread David Holmes
Hi Frank, On 3/08/2012 5:39 PM, Frank Ding wrote: Hi guys, I found that in java.lang.Terminator, setup() method, The following code of registering default signal handlers can be improved: / try { Signal.handle(new Signal("INT"), sh); Signal.handle(new Signal("TERM"), sh); } catch (IllegalArgumen

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-05 Thread Alan Bateman
On 03/08/2012 19:33, Andrew Hughes wrote: : http://cr.openjdk.java.net/~andrew/syslibs/zlib/webrev.02/ is an updated version which checks if ZLIB_LIBS is set on Solaris, GNU/Linux and MacOS X and sets it to -lz if not. I wasn't sure what to do with Windows but something can be added there if n