Re: Please review: 4722265 (spec str) StringBuffer.ensureCapacity() should mention that capacity is mutable

2012-09-18 Thread David Holmes
I also think this is a non-issue - particularly from a report 10 years ago. I wouldn't waste time on it. You can't document every nuance of every method when used in conjunction with other methods. If you feel the need to complete this now then the shorter the better: "Note that subsequent ope

hg: jdk8/tl/jdk: 7198070: Eliminate static dependency from JMX to java.beans.ConstructorProperties

2012-09-18 Thread mandy . chung
Changeset: 045a0962b430 Author:mchung Date: 2012-09-18 15:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/045a0962b430 7198070: Eliminate static dependency from JMX to java.beans.ConstructorProperties Reviewed-by: alanb ! src/share/classes/com/sun/jmx/mbeanserver/DefaultM

hg: jdk8/tl/jdk: 7195933: There is incorrect link to "Info-ZIP Application Note 970311" in doc page of Package java.util.zip

2012-09-18 Thread kurchi . subhra . hazra
Changeset: e143d8f8e477 Author:dxu Date: 2012-09-18 14:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e143d8f8e477 7195933: There is incorrect link to "Info-ZIP Application Note 970311" in doc page of Package java.util.zip Summary: Correct a java doc link in java.util.zip

Please Review : Javadoc - docencoding not available to stylesheet post 7006270

2012-09-18 Thread jayashree viswanathan
Hi all , Looking for a reviewer for a change request . This change is in Javadoc tool , which doesn't seems to take up value of the docencoding getting passed unlike the other generated HTML files . webrev is available at http://cr.openjdk.java.net/~luchsh/7006270/ Recreation steps and rest

Re: Please Review : Javadoc - docencoding not available to stylesheet post 7006270

2012-09-18 Thread jayashree viswanathan
Hi Alan, True , but I am not seeing any mail conversations there,while I have posted there as well :-) Any suggestions would really help . Thanks a lot your quick response ! Regards, Jayashree Viswanathan On 13-09-2012 2:58 PM, Alan Bateman wrote: On 13/09/2012 10:05, jayashree viswanathan wr

hg: jdk8/tl/jdk: 7190273: Deprecate com.sun.security.auth.callback.DialogCallbackHandler

2012-09-18 Thread alan . bateman
Changeset: db381a2c0083 Author:alanb Date: 2012-09-18 21:21 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/db381a2c0083 7190273: Deprecate com.sun.security.auth.callback.DialogCallbackHandler Reviewed-by: mullan ! src/share/classes/com/sun/security/auth/callback/DialogCallba

Re: Please review: 4722265 (spec str) StringBuffer.ensureCapacity() should mention that capacity is mutable

2012-09-18 Thread Chris Hegarty
Jim, I'm not all that sure that this is really such an issue. The methods that can reduce the capacity seem to be clearly specified. But others may have a stronger opinion, for or against, than me. Coming up with small concise wording for these type of issues is always difficult. I don't hav

Please review: 4722265 (spec str) StringBuffer.ensureCapacity() should mention that capacity is mutable

2012-09-18 Thread Jim Gish
Please review this minor usage note change for Bug 4722265: diff -r 8a454e92aaf1 src/share/classes/java/lang/AbstractStringBuilder.java --- a/src/share/classes/java/lang/AbstractStringBuilder.javaMon Sep 17 12:40:33 2012 +0200 +++ b/src/share/classes/java/lang/AbstractStringBuilder.javaT

hg: jdk8/tl/jdk: 7199249: TEST_BUG : Add /othervm to Collisions.java @run main with -D definitions

2012-09-18 Thread mike . duigou
Changeset: e7add6d98729 Author:mduigou Date: 2012-09-18 11:04 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e7add6d98729 7199249: TEST_BUG : Add /othervm to Collisions.java @run main with -D definitions Reviewed-by: alanb ! test/java/util/Map/Collisions.java

hg: jdk8/tl/jdk: 7198984: Add java/text/Bidi/Bug6665028.java to ProblemList.txt

2012-09-18 Thread naoto . sato
Changeset: 0136fca60652 Author:naoto Date: 2012-09-18 10:34 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0136fca60652 7198984: Add java/text/Bidi/Bug6665028.java to ProblemList.txt Reviewed-by: alanb Contributed-by: yiming.w...@oracle.com ! test/ProblemList.txt

Re: Review Request for 7195933: There is incorrect link to "Info-ZIP Application Note 970311" in doc page of Package java.util.zip

2012-09-18 Thread Xueming Shen
Change looks fine. Thanks, -Sherman On 9/17/2012 10:29 PM, Dan Xu wrote: Hi, This is the change to correct a java doc link in java.util.zip package page. The webrev can be reviewed at http://cr.openjdk.java.net/~dxu/7195933/webrev/. Thanks! -Dan

hg: jdk8/tl/jdk: 7199066: Typo in method name

2012-09-18 Thread xuelei . fan
Changeset: 88a4f699d233 Author:xuelei Date: 2012-09-18 06:51 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/88a4f699d233 7199066: Typo in method name Reviewed-by: mullan ! src/share/classes/sun/security/ssl/SSLContextImpl.java ! src/share/classes/sun/security/ssl/SSLEngineIm

hg: jdk8/tl/jdk: 7142919: TEST_BUG: java/nio/channels/AsyncCloseAndInterrupt.java failing intermittently [sol11]

2012-09-18 Thread alan . bateman
Changeset: bc5e7ec12717 Author:dxu Date: 2012-09-18 13:14 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bc5e7ec12717 7142919: TEST_BUG: java/nio/channels/AsyncCloseAndInterrupt.java failing intermittently [sol11] Reviewed-by: alanb ! test/ProblemList.txt ! test/java/nio/ch

Re: Review Request for 7195933: There is incorrect link to "Info-ZIP Application Note 970311" in doc page of Package java.util.zip

2012-09-18 Thread Lance Andersen - Oracle
looks OK Dan and I was able to access the URL and download the zip Best Lance On Sep 18, 2012, at 1:29 AM, Dan Xu wrote: > Hi, > > This is the change to correct a java doc link in java.util.zip package page. > > The webrev can be reviewed at > http://cr.openjdk.java.net/~dxu/7195933/webrev/. T

hg: jdk8/tl/jdk: 7198901: correct the field size check when decoding a point on ECC curve

2012-09-18 Thread vincent . x . ryan
Changeset: 95a93f039e5c Author:vinnie Date: 2012-09-18 11:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/95a93f039e5c 7198901: correct the field size check when decoding a point on ECC curve Reviewed-by: xuelei ! src/share/classes/sun/security/ec/ECParameters.java

hg: jdk8/tl/jdk: 7198871: cleanup security tests in problem lists with no CR attached

2012-09-18 Thread weijun . wang
Changeset: 53ca38f76eaa Author:weijun Date: 2012-09-18 17:38 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/53ca38f76eaa 7198871: cleanup security tests in problem lists with no CR attached Reviewed-by: alanb ! test/ProblemList.txt

Re: Review Request for 7195933: There is incorrect link to "Info-ZIP Application Note 970311" in doc page of Package java.util.zip

2012-09-18 Thread Chris Hegarty
Looks fine to me Dan. -Chris. On 18/09/12 06:29, Dan Xu wrote: Hi, This is the change to correct a java doc link in java.util.zip package page. The webrev can be reviewed at http://cr.openjdk.java.net/~dxu/7195933/webrev/. Thanks! -Dan